Fix CameraProjection panic and improve CameraProjectionPlugin - #11808
Merged
Conversation
Contributor
Author
|
This is now unblocked since #11766 has been merged. |
NthTensor
reviewed
Apr 23, 2024
NthTensor
left a comment
Contributor
There was a problem hiding this comment.
Code looks like a big improvement. Will approve later after I get the chance to evaluate this on examples.
Contributor
|
@doonv I did a rebase and fixed conflicts: doonv#3 Notable conflicts:
|
Zoomulator
approved these changes
Apr 23, 2024
Zoomulator
left a comment
Contributor
There was a problem hiding this comment.
Been running this in my own bevy fork for my game and it's been working well with my custom projection + pbr shadows. No complaints :)
…meraprojection-crash
Zoomulator
approved these changes
Apr 26, 2024
Zoomulator
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Well spotted to not need the check_visibility.after given the recently added .before(CheckVisibility) above.
NthTensor
approved these changes
Apr 26, 2024
mockersf
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix #11799 and improve
CameraProjectionPluginSolution
CameraProjectionPluginis now an all-in-one plugin for adding a customCameraProjection. I also addedPbrProjectionPluginwhich is likeCameraProjectionPluginbut for PBR.P.S. I'd like to get this merged after #11766.
Changelog
CameraProjectionPluginto be an all-in-one plugin for adding aCameraProjectionVisibilitySystems::{UpdateOrthographicFrusta, UpdatePerspectiveFrusta, UpdateProjectionFrusta}, now replaced withVisibilitySystems::UpdateFrustaPbrProjectionPluginfor projection-specific PBR functionality.Migration Guide
VisibilitySystems'sUpdateOrthographicFrusta,UpdatePerspectiveFrusta, andUpdateProjectionFrustavariants were removed, they were replaced withVisibilitySystems::UpdateFrusta