chore: Disable test while we reevaluate the assumption that INetworkM… #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etricEvent interfaces must be reported from MLAPI.
Comment on lines
18
to
19
| // Disable test while we reevaluate the assumption that INetworkMetricEvent interfaces must be reported from MLAPI. | ||
| //[TestCaseSource(nameof(s_MetricTypes))] |
There was a problem hiding this comment.
Does [Ignore] not work?
becksebenius-unity
approved these changes
Sep 10, 2021
SamuelBellomo
added a commit
that referenced
this pull request
Sep 13, 2021
…nsform * develop: fix: add `link.xml` to prevent IL2CPP stripping `Unity.PerformanceTesting` (#1172) chore: add boilerplate for `ClientNetworkTransform` sample (#1168) chore: remove `ClientNetworkVariable` (#1167) chore: Disable test while we reevaluate the assumption that INetworkM… (#1163) docs: rename Manual.md to Index.md Only track one metric for scene sync and do not report scene name (#1159) test: create job definitions for mobile build and test (#1152) test: make test runner scene ignored by default for BaseMultiInstanceTest (#1154) fix: remove left-over reference to SyncTransform (#1155) chore: remove unused SyncTransform.cs (#1153) chore!: remove NetworkNavMeshAgent (#1150) fix: NetworkObject parenting support in scene transitioning (#1148) chore!: rename Prototyping asmdef to Components (#1145) feat: add bootstrap sample to package (#1140) chore: remove `--yamato` param from `standards.py` (#1144) fix: MTT-504 connection approval messages and comparing networkconfig (#1138) refactor!: remove NetworkChannel and MultiplexTransportAdapter (#1133) # Conflicts: # com.unity.netcode.gameobjects/Components/Interpolator.meta # com.unity.netcode.gameobjects/Components/Interpolator/BufferedLinearInterpolator.cs # com.unity.netcode.gameobjects/Components/Interpolator/BufferedLinearInterpolator.cs.meta # testproject/Assets/Prefabs/PlayerCube.prefab
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
Unity-Technologies#1163) * chore: Disable test while we reevaluate the assumption that INetworkMetricEvent interfaces must be reported from MLAPI. * Use ignore attribute Co-authored-by: becksebenius-unity <74328025+becksebenius-unity@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etricEvent interfaces must be reported from MLAPI.