test: make test runner scene ignored by default for BaseMultiInstanceTest #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update allows one to add an additional start initialization action to be invoked when just after the server-host is started and after each client is started for scenarios where you need to access sub-systems that are only initialized when the NetworkManager is started (client, host, or server). Made minor modifications to the BaseMultiInstanceTest to reflect the above changes.
com.unity.netcode.gameobjects/Tests/Runtime/MultiInstanceHelpers.cs
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Tests/Runtime/BaseMultiInstanceTest.cs
Outdated
Show resolved
Hide resolved
SamuelBellomo
approved these changes
Sep 9, 2021
josiemessa
approved these changes
Sep 9, 2021
NoelStephensUnity
deleted the
test/default-multiInstance-testrunner-scene-validation
branch
SamuelBellomo
added a commit
that referenced
this pull request
Sep 13, 2021
…nsform * develop: fix: add `link.xml` to prevent IL2CPP stripping `Unity.PerformanceTesting` (#1172) chore: add boilerplate for `ClientNetworkTransform` sample (#1168) chore: remove `ClientNetworkVariable` (#1167) chore: Disable test while we reevaluate the assumption that INetworkM… (#1163) docs: rename Manual.md to Index.md Only track one metric for scene sync and do not report scene name (#1159) test: create job definitions for mobile build and test (#1152) test: make test runner scene ignored by default for BaseMultiInstanceTest (#1154) fix: remove left-over reference to SyncTransform (#1155) chore: remove unused SyncTransform.cs (#1153) chore!: remove NetworkNavMeshAgent (#1150) fix: NetworkObject parenting support in scene transitioning (#1148) chore!: rename Prototyping asmdef to Components (#1145) feat: add bootstrap sample to package (#1140) chore: remove `--yamato` param from `standards.py` (#1144) fix: MTT-504 connection approval messages and comparing networkconfig (#1138) refactor!: remove NetworkChannel and MultiplexTransportAdapter (#1133) # Conflicts: # com.unity.netcode.gameobjects/Components/Interpolator.meta # com.unity.netcode.gameobjects/Components/Interpolator/BufferedLinearInterpolator.cs # com.unity.netcode.gameobjects/Components/Interpolator/BufferedLinearInterpolator.cs.meta # testproject/Assets/Prefabs/PlayerCube.prefab
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…Test (Unity-Technologies#1154) * refactor Specific to testing, this adds the ability to ignore the warning message when scene validation fails so we don't spam log. * refactor If not already set, making the test runner scene a default scene for clients to not try to synchronize. This also will register the test runner scene so that other associated warning messages will not log-spam. * refactor This update allows one to add an additional start initialization action to be invoked when just after the server-host is started and after each client is started for scenarios where you need to access sub-systems that are only initialized when the NetworkManager is started (client, host, or server). Made minor modifications to the BaseMultiInstanceTest to reflect the above changes. * style included 1 whitespace * style updated comment and removed a LF * style updated comment. * refactor updated comment. using startInitializationCallback?.Invoke(server); as opposed to checking for null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just updates the BaseMultiInstanceTest class to automatically ignore the testrunner scene when clients are synchronizing as well as registers the testrunner scene automatically for NetworkObject synchronization. The primary purpose behind this PR is to just further simplify BaseMultiInstanceTest usage without having to re-write the same code repeatedly.