fix: NetworkObject parenting support in scene transitioning #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for parented NetworkObjects to properly transition between scenes as well as disables the NetworkObjects during a scene transition (i.e. loading a scene in single mode) until the scene has been loaded right before the NetworkObjects are moved back into the newly loaded currently active scene.
After consulting and verifying fix with Fatih, there was some refactoring to assure only non-parented GameObject transforms were migrated as all children would follow. Additionally changed the name from MoveObjectsToScene to MoveObjectsFromDontDestroyOnLoadToScene for better clarity of what the method did.
NoelStephensUnity
changed the title
NoelStephensUnity
changed the title
NoelStephensUnity
changed the title
0xFA11
changed the title
0xFA11
approved these changes
Sep 7, 2021
SamuelBellomo
added a commit
that referenced
this pull request
Sep 13, 2021
…nsform * develop: fix: add `link.xml` to prevent IL2CPP stripping `Unity.PerformanceTesting` (#1172) chore: add boilerplate for `ClientNetworkTransform` sample (#1168) chore: remove `ClientNetworkVariable` (#1167) chore: Disable test while we reevaluate the assumption that INetworkM… (#1163) docs: rename Manual.md to Index.md Only track one metric for scene sync and do not report scene name (#1159) test: create job definitions for mobile build and test (#1152) test: make test runner scene ignored by default for BaseMultiInstanceTest (#1154) fix: remove left-over reference to SyncTransform (#1155) chore: remove unused SyncTransform.cs (#1153) chore!: remove NetworkNavMeshAgent (#1150) fix: NetworkObject parenting support in scene transitioning (#1148) chore!: rename Prototyping asmdef to Components (#1145) feat: add bootstrap sample to package (#1140) chore: remove `--yamato` param from `standards.py` (#1144) fix: MTT-504 connection approval messages and comparing networkconfig (#1138) refactor!: remove NetworkChannel and MultiplexTransportAdapter (#1133) # Conflicts: # com.unity.netcode.gameobjects/Components/Interpolator.meta # com.unity.netcode.gameobjects/Components/Interpolator/BufferedLinearInterpolator.cs # com.unity.netcode.gameobjects/Components/Interpolator/BufferedLinearInterpolator.cs.meta # testproject/Assets/Prefabs/PlayerCube.prefab
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…chnologies#1148) * fix This allows for parented NetworkObjects to properly transition between scenes as well as disables the NetworkObjects during a scene transition (i.e. loading a scene in single mode) until the scene has been loaded right before the NetworkObjects are moved back into the newly loaded currently active scene. * refactor After consulting and verifying fix with Fatih, there was some refactoring to assure only non-parented GameObject transforms were migrated as all children would follow. Additionally changed the name from MoveObjectsToScene to MoveObjectsFromDontDestroyOnLoadToScene for better clarity of what the method did. * style fixing the clarity of one comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-621
This fixes the issue with parented NetworkObjects being removed from their parent during scene transitions (i.e. a Scene loaded in single mode).