fix: connection approval and networkconfig comparison #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just an update on the connection approval manual test to verify that users receive the appropriate messages when a client is approved or not approved. Server will know if the client is approved or not based on how it processed the NetworkConfig.ConnectionData sent to it and clients will just be notified they were disconnected.
added some additional comments as well as refactored a little bit of code and renamed some methods and parameters for clarity
When a client or server have mismatched connection approval NetworkManager settings this fix will make sure to disconnect the client as well as it will properly detect the mismatched NetworkConfigs and log a message to the console on the server/host so users know why the client was disconnected. Made an adjustment to the connection approval component so this scenario can be tested.
0xFA11
changed the title
NoelStephensUnity
deleted the
fix/connnectionapproval-messages-and-comparing
branch
SamuelBellomo
added a commit
that referenced
this pull request
Sep 13, 2021
…nsform * develop: fix: add `link.xml` to prevent IL2CPP stripping `Unity.PerformanceTesting` (#1172) chore: add boilerplate for `ClientNetworkTransform` sample (#1168) chore: remove `ClientNetworkVariable` (#1167) chore: Disable test while we reevaluate the assumption that INetworkM… (#1163) docs: rename Manual.md to Index.md Only track one metric for scene sync and do not report scene name (#1159) test: create job definitions for mobile build and test (#1152) test: make test runner scene ignored by default for BaseMultiInstanceTest (#1154) fix: remove left-over reference to SyncTransform (#1155) chore: remove unused SyncTransform.cs (#1153) chore!: remove NetworkNavMeshAgent (#1150) fix: NetworkObject parenting support in scene transitioning (#1148) chore!: rename Prototyping asmdef to Components (#1145) feat: add bootstrap sample to package (#1140) chore: remove `--yamato` param from `standards.py` (#1144) fix: MTT-504 connection approval messages and comparing networkconfig (#1138) refactor!: remove NetworkChannel and MultiplexTransportAdapter (#1133) # Conflicts: # com.unity.netcode.gameobjects/Components/Interpolator.meta # com.unity.netcode.gameobjects/Components/Interpolator/BufferedLinearInterpolator.cs # com.unity.netcode.gameobjects/Components/Interpolator/BufferedLinearInterpolator.cs.meta # testproject/Assets/Prefabs/PlayerCube.prefab
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…Unity-Technologies#1138) * refactor fix This is just an update on the connection approval manual test to verify that users receive the appropriate messages when a client is approved or not approved. Server will know if the client is approved or not based on how it processed the NetworkConfig.ConnectionData sent to it and clients will just be notified they were disconnected. * refactor and style added some additional comments as well as refactored a little bit of code and renamed some methods and parameters for clarity * fix When a client or server have mismatched connection approval NetworkManager settings this fix will make sure to disconnect the client as well as it will properly detect the mismatched NetworkConfigs and log a message to the console on the server/host so users know why the client was disconnected. Made an adjustment to the connection approval component so this scenario can be tested. * test Adding a unit test which verifies clients are disconnected when there is a connection approval setting mismatch between client and server when scene management is enabled and disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-504
This includes fixes to the network config comparison so mismatched connection approval settings will be detected and the client will receive a prompt disconnected message via the transport. Additional adjustments to the manual connection approval test we made so that this can be verified. Additional modifications were made to the manual connection approval test that verify users will receive the appropriate messages when a client is not approved.
This includes integration tests for connection approval being enabled/disabled both when scene management is enabled and disabled.