Skip to content

test: create job definitions for mobile build and test #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

zain-mecklai
Copy link
Contributor

Created a job definition that will allow playmode tests to run on mobile devices with a few exceptions to be identified and called out later. (for example multiprocess tests)

@zain-mecklai
Copy link
Contributor Author

I was able to remove all extraneous changes from my previous branch and with one file provide a way to run tests on mobile platforms. IF this works, next step is to add it to nightly.

Copy link
Contributor

@JesseOlmer JesseOlmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

- pip install unity-downloader-cli --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple
- curl -s https://artifactory.prd.it.unity3d.com/artifactory/unity-tools-local/utr-standalone/utr.bat --output utr.bat
- |
mkdir C:\TMP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't there a suggestion to use macos in order to avoid this tmp path issue? Did that not end up working out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrews-unity had pointed this weirdness out. The issue goes like this: Android is built on Windows, Windows has path length issues so the default Editor location results in unreadable paths. The suggestion was "don't use Windows" and when I explored Mac and Linux I got feedback from various folks to not use Mac as it was a scarce resource and not to use Linux as most configs for android are set up on Windows and Linux hasn't been set up so there will probably be the need for a custom bokken image for that. So I'm back to the TMP dir on Windows.
I'm not familiar with how to use macros to circumvent this, but it would be great if we could. I just ran around in circles for a while and gave up. @JesseOlmer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also mentioned to using the mobile image :P

https://github.cds.internal.unity3d.com/unity/com.unity.transport/blob/master/.yamato/mobile-playmode-tests.yml#L6

This is how we are doing it on UTP and we use a windows image to build for android. This is also the same setup that dots is using to build their android player and their folder depth is way longer than ours.

@zain-mecklai zain-mecklai enabled auto-merge (squash) September 9, 2021 14:45
@zain-mecklai zain-mecklai merged commit 97abc43 into develop Sep 9, 2021
@zain-mecklai zain-mecklai deleted the chore/enable-mobile-device-testing-take-2 branch September 9, 2021 15:06
SamuelBellomo added a commit that referenced this pull request Sep 13, 2021
…nsform

* develop:
  fix: add `link.xml` to prevent IL2CPP stripping `Unity.PerformanceTesting` (#1172)
  chore: add boilerplate for `ClientNetworkTransform` sample (#1168)
  chore: remove `ClientNetworkVariable` (#1167)
  chore: Disable test while we reevaluate the assumption that INetworkM… (#1163)
  docs: rename Manual.md to Index.md
  Only track one metric for scene sync and do not report scene name (#1159)
  test: create job definitions for mobile build and test (#1152)
  test: make test runner scene ignored by default for BaseMultiInstanceTest (#1154)
  fix: remove left-over reference to SyncTransform (#1155)
  chore: remove unused SyncTransform.cs (#1153)
  chore!: remove NetworkNavMeshAgent (#1150)
  fix: NetworkObject parenting support in scene transitioning (#1148)
  chore!: rename Prototyping asmdef to Components (#1145)
  feat: add bootstrap sample to package (#1140)
  chore: remove `--yamato` param from `standards.py` (#1144)
  fix: MTT-504 connection approval messages and comparing networkconfig (#1138)
  refactor!: remove NetworkChannel and MultiplexTransportAdapter (#1133)

# Conflicts:
#	com.unity.netcode.gameobjects/Components/Interpolator.meta
#	com.unity.netcode.gameobjects/Components/Interpolator/BufferedLinearInterpolator.cs
#	com.unity.netcode.gameobjects/Components/Interpolator/BufferedLinearInterpolator.cs.meta
#	testproject/Assets/Prefabs/PlayerCube.prefab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants