Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented May 8, 2023

No description provided.

plakrisenko and others added 23 commits November 22, 2022 15:38
* plotting at  t = inf, draft

* move plotting values at t_inf to a separate method

* add vertical dashed lines and horisontal lines to inf data points

* plot simulations w inf and calculate split axes parameters based on all data to plot

* plot with only t = inf

* plotting steady-state measurements with replicates

* add tests

* docstrings

Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Some basic validation of visualization files. Closes #8, closes  #1.
Fixes

```
SetuptoolsDeprecationWarning:     Installing 'petab.visualize.templates' as data is deprecated, please list it in `packages`.
````
Add `Problem.sample_parameter_startpoints_dict` for sampling startpoints as parameter_id=>parameter_value dicts.


Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
* minor fixes

* add residuals plot

* add ax argument

* Update petab/visualize/plot_residuals.py

Co-authored-by: Paul Jonas Jost <70631928+PaulJonasJost@users.noreply.github.com>

* documentation

* rename function

* move vis dependances to extras_require

* add __all__

---------

Co-authored-by: Paul Jonas Jost <70631928+PaulJonasJost@users.noreply.github.com>
* add histogram to residuals plot and center zero

* text location
* add goodness of fit plot
Handle parametric initial concentrations for cases where the initial concentration parameter does not occur in the model, but only in the parameter table.
* Add PySBModel for handling of PySB models

* adds newly introduced model IDs in yaml file to petab.Model, and handles change form `sbml_files` to `model_files` 

* adds support for the newly introduced model<->petab entity mapping file

* Use tentative multilanguage schema

* Add mapping table IO

* Condition table validation respects mapping table

* Add PySB ID parsing and checking


Co-authored-by: Fabian Fröhlich <fabian@schaluck.com>
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Fixes:

>  DEPRECATION: petab is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at pypa/pip#8559



Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
... and fix some related tox/flake issues
@dweindl dweindl requested review from dilpath and plakrisenko May 8, 2023 08:12
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dweindl and others added 2 commits May 8, 2023 16:47
Make sure symbols like `N`, `beta`, ... are used as scalar symbols, and not as sympy functions with the same name.

See also ICB-DCM/pyPESTO#1048
@codecov-commenter
Copy link

Codecov Report

Merging #201 (dc0be75) into main (2ba5c52) will decrease coverage by 1.79%.
The diff coverage is 68.05%.

❗ Current head dc0be75 differs from pull request most recent head 9fbf14c. Consider uploading reports for the commit 9fbf14c to get more accurate results

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   78.09%   76.31%   -1.79%     
==========================================
  Files          30       34       +4     
  Lines        2662     3162     +500     
  Branches      591      765     +174     
==========================================
+ Hits         2079     2413     +334     
- Misses        425      552     +127     
- Partials      158      197      +39     
Impacted Files Coverage Δ
petab/petablint.py 0.00% <0.00%> (ø)
petab/visualize/plot_data_and_simulation.py 76.66% <ø> (ø)
petab/problem.py 64.51% <33.33%> (-2.54%) ⬇️
petab/lint.py 72.28% <36.00%> (-3.09%) ⬇️
petab/visualize/plotting.py 86.86% <50.00%> (+1.05%) ⬆️
petab/visualize/lint.py 51.42% <51.42%> (ø)
petab/parameters.py 84.53% <57.14%> (-2.68%) ⬇️
petab/mapping.py 57.89% <57.89%> (ø)
petab/models/pysb_model.py 60.80% <60.80%> (ø)
petab/models/model.py 68.33% <64.28%> (-3.67%) ⬇️
... and 14 more

@dweindl dweindl merged commit 3c29fa1 into main May 8, 2023
@dweindl dweindl deleted the release_0.2.0 branch May 8, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants