Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sympy symbol name clashes #202

Merged
merged 2 commits into from
May 8, 2023
Merged

Fix sympy symbol name clashes #202

merged 2 commits into from
May 8, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented May 8, 2023

Make sure symbols like N, beta, ... are used as scalar symbols, and not as sympy functions with the same name.

See also ICB-DCM/pyPESTO#1048

Make sure symbols like `N`, `beta`, ... are used as scalar symbols, and not as sympy functions with the same name.

See also ICB-DCM/pyPESTO#1048
@codecov-commenter
Copy link

Codecov Report

Merging #202 (dda5034) into develop (bd0176f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #202      +/-   ##
===========================================
+ Coverage    76.28%   76.31%   +0.02%     
===========================================
  Files           34       34              
  Lines         3159     3162       +3     
  Branches       765      765              
===========================================
+ Hits          2410     2413       +3     
  Misses         552      552              
  Partials       197      197              
Impacted Files Coverage Δ
petab/calculate.py 89.92% <100.00%> (+0.07%) ⬆️
petab/lint.py 72.28% <100.00%> (+0.07%) ⬆️
petab/observables.py 97.29% <100.00%> (+0.03%) ⬆️

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit dc0be75 into develop May 8, 2023
@dweindl dweindl deleted the fix_sympy_clashes branch May 8, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants