Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for visualization files #184

Merged
merged 10 commits into from
Dec 8, 2022
Merged

Add validation for visualization files #184

merged 10 commits into from
Dec 8, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 6, 2022

Some basic validation of visualization files. Closes #8, closes #1.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #184 (a90d309) into develop (a0817db) will decrease coverage by 0.25%.
The diff coverage is 54.28%.

@@             Coverage Diff             @@
##           develop     #184      +/-   ##
===========================================
- Coverage    78.55%   78.29%   -0.26%     
===========================================
  Files           29       29              
  Lines         2742     2479     -263     
  Branches       659      575      -84     
===========================================
- Hits          2154     1941     -213     
+ Misses         427      395      -32     
+ Partials       161      143      -18     
Impacted Files Coverage Δ
petab/petablint.py 0.00% <0.00%> (ø)
petab/visualize/lint.py 55.38% <55.38%> (ø)
petab/C.py 100.00% <100.00%> (ø)
petab/lint.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dweindl dweindl marked this pull request as ready for review December 7, 2022 10:08
@dweindl dweindl requested a review from plakrisenko December 7, 2022 10:25
@dweindl dweindl merged commit 7231eba into develop Dec 8, 2022
@dweindl dweindl deleted the validate_vis branch December 8, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants