prevent strings being parsed as nan in get_visualization_df #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #193 +/- ##
========================================
Coverage 78.07% 78.07%
========================================
Files 32 32
Lines 2914 2915 +1
Branches 690 690
========================================
+ Hits 2275 2276 +1
Misses 461 461
Partials 178 178
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dweindl
reviewed
Feb 14, 2023
petab/core.py
Outdated
| @@ -65,7 +65,8 @@ def get_visualization_df(visualization_file: Union[str, Path]) -> pd.DataFrame: | |||
| """ | |||
| try: | |||
| vis_spec = pd.read_csv(visualization_file, sep="\t", index_col=None, | |||
| float_precision='round_trip') | |||
| float_precision='round_trip', | |||
| keep_default_na=False) | |||
There was a problem hiding this comment.
I think, I would prefer going via dtype to avoid potential issues elsewhere. That should also solve the issue, right?
There was a problem hiding this comment.
dtype didn't help, but converters did
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.