Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_model_for_condition #194

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Fix get_model_for_condition #194

merged 2 commits into from
Feb 26, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 20, 2023

Handle parametric initial concentrations for cases where the initial concentration parameter does not occur in the model, but only in the parameter table.

Handle parametric initial concentrations for cases where the initial concentration parameter does not occur in the model, but only in the parameter table.
@dweindl dweindl requested a review from a team as a code owner February 20, 2023 08:18
@codecov-commenter
Copy link

Codecov Report

Merging #194 (dcdfa0f) into develop (5868dd4) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #194      +/-   ##
===========================================
+ Coverage    78.04%   78.07%   +0.03%     
===========================================
  Files           32       32              
  Lines         2910     2914       +4     
  Branches       688      690       +2     
===========================================
+ Hits          2271     2275       +4     
  Misses         461      461              
  Partials       178      178              
Impacted Files Coverage Δ
petab/sbml.py 69.23% <100.00%> (+1.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 1445769 into develop Feb 26, 2023
@dweindl dweindl deleted the fix_get_model_for_condition branch February 26, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants