Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add histogram to residuals plot and center zero #191

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

plakrisenko
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #191 (272583a) into develop (05067d6) will increase coverage by 0.03%.
The diff coverage is 94.11%.

@@             Coverage Diff             @@
##           develop     #191      +/-   ##
===========================================
+ Coverage    77.87%   77.91%   +0.03%     
===========================================
  Files           32       32              
  Lines         2879     2884       +5     
  Branches       686      686              
===========================================
+ Hits          2242     2247       +5     
  Misses         461      461              
  Partials       176      176              
Impacted Files Coverage Δ
petab/visualize/plot_residuals.py 80.48% <94.11%> (+2.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -13,17 +13,16 @@
from ..calculate import calculate_residuals
from ..core import get_simulation_df
from ..problem import Problem
from ..C import NOISE_DISTRIBUTION, NORMAL, LIN, OBSERVABLE_TRANSFORMATION, \
OBSERVABLE_ID
from ..C import *
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this actually clean? would think it would be cleaner to still import only the ones used.

@plakrisenko plakrisenko merged commit 4d227bd into develop Feb 1, 2023
@dweindl dweindl deleted the residuals_plot_improvements branch February 28, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants