Plot measurements for t = 'inf' #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n into plot_inf_points
Codecov Report
@@ Coverage Diff @@
## develop #149 +/- ##
===========================================
+ Coverage 77.95% 78.55% +0.60%
===========================================
Files 29 29
Lines 2644 2742 +98
Branches 591 610 +19
===========================================
+ Hits 2061 2154 +93
- Misses 425 427 +2
- Partials 158 161 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PaulJonasJost
approved these changes
Nov 17, 2022
Comment on lines
+145
to
+152
| if np.inf in scond: | ||
| # remove inf point | ||
| scond = scond[:-1] | ||
| smean = smean[:-1] | ||
| snoise = snoise[:-1] | ||
|
|
||
| if len(scond) > 0 and len(smean) > 0 and len(snoise) > 0: | ||
| # if only t=inf there will be nothing to plot |
There was a problem hiding this comment.
Not sure how this ensures that if only t=inf this will not be called.
There was a problem hiding this comment.
If only measurements at t=inf are available, scond, smean, snoise will be empty because of the lines 145-149.
petab/visualize/plotter.py
Outdated
Comment on lines
486
to
497
| def _split_axes_line_plot( | ||
| ax: matplotlib.axes.Axes, | ||
| plotTypeData: str, | ||
| measurements_to_plot: DataSeries, | ||
| simulations_to_plot: DataSeries, | ||
| noise_col: str, | ||
| label_base: str, | ||
| split_axes_params: dict, | ||
| color=None | ||
| ) -> Tuple[matplotlib.axes.Axes, matplotlib.axes.Axes]: | ||
| """ | ||
| Plot data at t=inf. |
There was a problem hiding this comment.
Wouldn't plot_inf_states or something be a bit more clear name then split_axes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visualization of data at t=\infty with a break in x axis.