Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Residuals plot #187

Merged
merged 17 commits into from
Jan 31, 2023
Merged

Residuals plot #187

merged 17 commits into from
Jan 31, 2023

Conversation

plakrisenko
Copy link
Member

@plakrisenko plakrisenko commented Jan 13, 2023

Adds residuals plot for normal noise assumption.

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would be nice to have a histogram on the side of the residuals axis as discussed in the subgroup meeting, but imo this can be added in a later PR :)

petab/visualize/plot_residuals.py Outdated Show resolved Hide resolved
plakrisenko and others added 5 commits January 23, 2023 10:49
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2023

Codecov Report

Merging #187 (0da9267) into develop (a7220eb) will decrease coverage by 0.02%.
The diff coverage is 76.47%.

@@             Coverage Diff             @@
##           develop     #187      +/-   ##
===========================================
- Coverage    78.00%   77.98%   -0.02%     
===========================================
  Files           31       32       +1     
  Lines         2837     2871      +34     
  Branches       679      684       +5     
===========================================
+ Hits          2213     2239      +26     
- Misses         453      456       +3     
- Partials       171      176       +5     
Impacted Files Coverage Δ
petab/visualize/plot_data_and_simulation.py 76.66% <ø> (ø)
petab/visualize/plotter.py 83.58% <ø> (ø)
petab/visualize/plotting.py 86.86% <ø> (ø)
petab/visualize/plot_residuals.py 75.75% <75.75%> (ø)
petab/visualize/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@plakrisenko plakrisenko requested a review from a team as a code owner January 31, 2023 10:19
@plakrisenko plakrisenko merged commit 0c43199 into develop Jan 31, 2023
@dweindl dweindl deleted the residuals_plot branch February 28, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants