Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added NXP_LGA-8 for MPL3115A2 #1607

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Conversation

jneiva08
Copy link
Contributor

@jneiva08 jneiva08 commented May 20, 2019

Is the same footprint as "NXP_LGA-8_3x5mm_P1.25mm_H1.2mm" but with "_H1.1mm"

Datasheet: https://www.nxp.com/docs/en/data-sheet/MPL3115A2.pdf
Script: pointhi/kicad-footprint-generator#347
Symbol: KiCad/kicad-symbols#1796 (comment)

Footprint:
NXP_LGA-8_H1 1mm


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels May 20, 2019
@poeschlr
Copy link
Collaborator

poeschlr commented Jun 2, 2019

see comments on script PR

@poeschlr poeschlr self-assigned this Jun 2, 2019
@poeschlr poeschlr added Pending changes and removed Pending reviewer A pull request waiting for a reviewer labels Jun 2, 2019
@jneiva08
Copy link
Contributor Author

jneiva08 commented Jun 3, 2019

Have made the changes requested and updated the footprint.

@antoniovazquezblanco antoniovazquezblanco added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Pending changes labels Jun 3, 2019
@poeschlr
Copy link
Collaborator

poeschlr commented Jun 3, 2019

Parameters that influence the footprint are ok but the footprint height is still wrong. Merging the footprint, thanks

@poeschlr poeschlr merged commit 5a3cef5 into KiCad:master Jun 3, 2019
@poeschlr poeschlr removed the Ready for review Use this to mark pull requests that are updated but you could not review instantly label Jun 3, 2019
@jneiva08 jneiva08 deleted the lga_MPLA3115A2 branch June 3, 2019 16:51
@jneiva08
Copy link
Contributor Author

jneiva08 commented Jun 3, 2019

Thanks

@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone Jun 3, 2019
DaToBSn pushed a commit to DaToBSn/kicad-footprints that referenced this pull request Jul 2, 2019
* 'master' of github.com:KiCad/kicad-footprints: (41 commits)
  fixing partnumber of Slimstack 52991 connectors (KiCad#1642)
  Fix pad orientation of SW_Push_1P1T_NO_CK_KMR2 (KiCad#1593)
  added QFN-72 (KiCad#1632)
  Scripted TDK SLF series inductors (KiCad#1021)
  Add Linear Technology (Analog devices) MSOP-16 footprints (KiCad#1349)
  Add LQFP-64-1EP_10x10mm_P0.5mm_EP5x5mm (KiCad#1461)
  Fix courtyard clearances for scripted no lead footprints with pull back pins (KiCad#1630)
  Add VQFN-16-1EP_3x3mm_P0.5mm_EP1.6x1.6mm_ThermalVias (KiCad#1605)
  Add QFN-40 footprint for IS31FL3736/7 (KiCad#1625)
  added L_Bourns_SRN8040TA (KiCad#1628)
  Added Palconn UTC16-G connector (KiCad#789)
  Package_SO: Add SOIC 8 5.257x5.275 (KiCad#1601)
  Added NXP_LGA-8 for MPL3115A2 (KiCad#1607)
  add Mini-Circuits XX112 SO package (KiCad#1062)
  add SMA jack Amphenol 132203-12 (KiCad#1456)
  Converter_ACDC: Add TMG 15 series (KiCad#1603)
  Add molex EDGELOCK (KiCad#1054)
  Abracon ASPI-0630LR inductor (KiCad#1503)
  Mentor 4 way lightpipes 1276.1004 and 1276.2004 (KiCad#1429)
  add E-Switch 800U in M6 variant (KiCad#1454)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants