-
Notifications
You must be signed in to change notification settings - Fork 712
Conversation
Closed and reopened PR to get the CLA assistant to re-check. |
This could be scripted. @lorem-ipsum would you be willing to look into that? |
I tried building this footprint with the generator, but I am facing some difficulties. When building the footprint based on the mechanical dimensions of the housing the created pads do not match the ones specified by Mini-Circuits. As they already specify exact dimensions I would prefer sticking to those (+ rounded rects). Is there a way to specify the pad sizes instead of the dimensions of the mechanical parts? |
The mini circuits document is either from 2012 or 2013 (depending on which date format is used) This is before the introduction of the modern industry standards used by the generator script. As this is a manufacturer specific footprint i would accept it if it is build after the manufacturer specification. But like other mini circuits contributions it would then need a mention of the case number and of the land pattern drawing number in the footprint name. |
Ok, makes sense. Should I then add both? The standard compliant, script generated version using the name used so far and the manufacturer specific? |
Is this intended for a generic symbol or for a specialized one. |
This footprint is used for three RF switches from Mini-Circuits (overview here). It might be used for other Mini-Circuits components, but I haven't found any. |
I added some comments to your script PR. |
Added further comments to the script. (clarifications) |
@poeschlr @lorem-ipsum just seen this thread, but not read all coments, just a question, why not the same strategy of other Mini-Circuits footprint proposed by @aewallin ? Example: #1136 and many others. |
Because this one is a generic SO package wheras the others are specialized packages only produced for and by Mini Circuits. |
ok |
As this has been hanging around for some time: Whats the verdict now?
|
What was hanging. I thought i made it clear that this is a normal so part and will therefore be handled like a normal so part. |
In the current state it does not fit with the rest of the library. I can delete the ´Mini-Circuits_XX112´ copy or move it to the ´RF_Mini-Circuits.pretty´. |
I am confused. The screenshot looks like this is a completely normal SO footprint. The datasheet looks like this is a completely normal SO package. Meaning how does this not fit into the SO library? |
Fine by me. But this PR adds the footprint once with the generic name and once with the specialised |
I would remove the mini circuits version but add info about it to the description. (I am not sure if i have a clean way to do this. For now you can misuse the datasheet field or invest time into adding something nicer.) |
I've dropped the Mini-Circuits XX112 variant and added a tiny comment into the description by misusing the datasheet part in the generator. |
Looks good, thanks |
* 'master' of github.com:KiCad/kicad-footprints: (41 commits) fixing partnumber of Slimstack 52991 connectors (KiCad#1642) Fix pad orientation of SW_Push_1P1T_NO_CK_KMR2 (KiCad#1593) added QFN-72 (KiCad#1632) Scripted TDK SLF series inductors (KiCad#1021) Add Linear Technology (Analog devices) MSOP-16 footprints (KiCad#1349) Add LQFP-64-1EP_10x10mm_P0.5mm_EP5x5mm (KiCad#1461) Fix courtyard clearances for scripted no lead footprints with pull back pins (KiCad#1630) Add VQFN-16-1EP_3x3mm_P0.5mm_EP1.6x1.6mm_ThermalVias (KiCad#1605) Add QFN-40 footprint for IS31FL3736/7 (KiCad#1625) added L_Bourns_SRN8040TA (KiCad#1628) Added Palconn UTC16-G connector (KiCad#789) Package_SO: Add SOIC 8 5.257x5.275 (KiCad#1601) Added NXP_LGA-8 for MPL3115A2 (KiCad#1607) add Mini-Circuits XX112 SO package (KiCad#1062) add SMA jack Amphenol 132203-12 (KiCad#1456) Converter_ACDC: Add TMG 15 series (KiCad#1603) Add molex EDGELOCK (KiCad#1054) Abracon ASPI-0630LR inductor (KiCad#1503) Mentor 4 way lightpipes 1276.1004 and 1276.2004 (KiCad#1429) add E-Switch 800U in M6 variant (KiCad#1454) ...
This adds a SO variant used by Mini-Circuits and called XX112 in their naming system (datasheet). The vias are not fully specified in the datasheet, so I've chosen their locations. I extended the name to follow the regular naming scheme, however
Mini-Circuits_XX112
should already be unique.