Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

add Mini-Circuits XX112 SO package #1062

Merged
merged 6 commits into from
Jun 2, 2019
Merged

add Mini-Circuits XX112 SO package #1062

merged 6 commits into from
Jun 2, 2019

Conversation

hvraven
Copy link
Contributor

@hvraven hvraven commented Nov 1, 2018

This adds a SO variant used by Mini-Circuits and called XX112 in their naming system (datasheet). The vias are not fully specified in the datasheet, so I've chosen their locations. I extended the name to follow the regular naming scheme, however Mini-Circuits_XX112 should already be unique.
screenshot_20181101_173725

@DanSGiesbrecht DanSGiesbrecht added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Dec 2, 2018
@DanSGiesbrecht DanSGiesbrecht reopened this Dec 2, 2018
@DanSGiesbrecht
Copy link
Collaborator

Closed and reopened PR to get the CLA assistant to re-check.

@poeschlr
Copy link
Collaborator

poeschlr commented Dec 5, 2018

This could be scripted. @lorem-ipsum would you be willing to look into that?
The scripts can be found here: https://github.com/pointhi/kicad-footprint-generator/tree/master/scripts/Packages/Package_Gullwing__QFP_SOIC_SO

@poeschlr poeschlr self-assigned this Dec 5, 2018
@poeschlr poeschlr removed the Pending reviewer A pull request waiting for a reviewer label Dec 5, 2018
@hvraven
Copy link
Contributor Author

hvraven commented Dec 28, 2018

I tried building this footprint with the generator, but I am facing some difficulties. When building the footprint based on the mechanical dimensions of the housing the created pads do not match the ones specified by Mini-Circuits. As they already specify exact dimensions I would prefer sticking to those (+ rounded rects). Is there a way to specify the pad sizes instead of the dimensions of the mechanical parts?

@poeschlr
Copy link
Collaborator

The mini circuits document is either from 2012 or 2013 (depending on which date format is used)

This is before the introduction of the modern industry standards used by the generator script. As this is a manufacturer specific footprint i would accept it if it is build after the manufacturer specification. But like other mini circuits contributions it would then need a mention of the case number and of the land pattern drawing number in the footprint name.

@hvraven
Copy link
Contributor Author

hvraven commented Dec 28, 2018

Ok, makes sense. Should I then add both? The standard compliant, script generated version using the name used so far and the manufacturer specific?

@poeschlr
Copy link
Collaborator

Is this intended for a generic symbol or for a specialized one.
If it is for a specialized one then adding both options could make sense. (one is set as the default footprint the other reachable via the footprint filters as an alternative) For use with generic symbols it might be best to choose the manufacturer specific options named such that users understand for which part it is valid.

@hvraven
Copy link
Contributor Author

hvraven commented Jan 12, 2019

This footprint is used for three RF switches from Mini-Circuits (overview here). It might be used for other Mini-Circuits components, but I haven't found any.
I did now add the standard compliant variants based on the script (generator PR) and renamed the previous version to Mini-Circuits_XX112. I would set the later as default in the symbols.
screenshot_20190112_124920

@poeschlr
Copy link
Collaborator

I added some comments to your script PR.

@poeschlr poeschlr added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Pending changes labels Jan 18, 2019
@poeschlr
Copy link
Collaborator

Added further comments to the script. (clarifications)

@poeschlr poeschlr added Pending changes and removed Ready for review Use this to mark pull requests that are updated but you could not review instantly labels Jan 18, 2019
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Jan 21, 2019

@poeschlr @lorem-ipsum just seen this thread, but not read all coments, just a question, why not the same strategy of other Mini-Circuits footprint proposed by @aewallin ? Example: #1136 and many others.
Why several footprints and not only Package_SO.pretty/Mini-Circuits_XX112_LandPatternPL-217.kicad_mod + Package_SO.pretty/Mini-Circuits_XX112_LandPatternPL-218.kicad_mod ? Datasheet of devices using these footprints: https://ww2.minicircuits.com/pdfs/KSW-2-46+.pdf and https://ww2.minicircuits.com/pdfs/KSWHA-1-20+.pdf
Joel

@poeschlr
Copy link
Collaborator

Because this one is a generic SO package wheras the others are specialized packages only produced for and by Mini Circuits.

@myfreescalewebpage
Copy link
Collaborator

ok

@hvraven
Copy link
Contributor Author

hvraven commented May 20, 2019

As this has been hanging around for some time: Whats the verdict now?

Mini-Circuits_XX112 would be most consistent with other components. In theory this could be a generic SOP package, but most likely it will be unique for Mini-Circuits (taking all the tolerances into account). This then also should go into RF_Mini-Circuits.pretty and I would take a look at the land patterns.

@poeschlr
Copy link
Collaborator

What was hanging. I thought i made it clear that this is a normal so part and will therefore be handled like a normal so part.

@hvraven
Copy link
Contributor Author

hvraven commented May 28, 2019

In the current state it does not fit with the rest of the library. I can delete the ´Mini-Circuits_XX112´ copy or move it to the ´RF_Mini-Circuits.pretty´.

@poeschlr
Copy link
Collaborator

I am confused. The screenshot looks like this is a completely normal SO footprint. The datasheet looks like this is a completely normal SO package. Meaning how does this not fit into the SO library?

@hvraven
Copy link
Contributor Author

hvraven commented May 29, 2019

Fine by me. But this PR adds the footprint once with the generic name and once with the specialised Mini-Circuits_XX112 name. That one should either go away or be moved to the special Mini-Circuits library.

@poeschlr
Copy link
Collaborator

I would remove the mini circuits version but add info about it to the description. (I am not sure if i have a clean way to do this. For now you can misuse the datasheet field or invest time into adding something nicer.)

@hvraven
Copy link
Contributor Author

hvraven commented Jun 2, 2019

I've dropped the Mini-Circuits XX112 variant and added a tiny comment into the description by misusing the datasheet part in the generator.

@poeschlr poeschlr added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Pending changes labels Jun 2, 2019
@poeschlr
Copy link
Collaborator

poeschlr commented Jun 2, 2019

Looks good, thanks

@poeschlr poeschlr merged commit 5e297e4 into KiCad:master Jun 2, 2019
@poeschlr poeschlr removed the Ready for review Use this to mark pull requests that are updated but you could not review instantly label Jun 2, 2019
@hvraven hvraven deleted the xx112 branch June 3, 2019 06:40
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone Jun 3, 2019
DaToBSn pushed a commit to DaToBSn/kicad-footprints that referenced this pull request Jul 2, 2019
* 'master' of github.com:KiCad/kicad-footprints: (41 commits)
  fixing partnumber of Slimstack 52991 connectors (KiCad#1642)
  Fix pad orientation of SW_Push_1P1T_NO_CK_KMR2 (KiCad#1593)
  added QFN-72 (KiCad#1632)
  Scripted TDK SLF series inductors (KiCad#1021)
  Add Linear Technology (Analog devices) MSOP-16 footprints (KiCad#1349)
  Add LQFP-64-1EP_10x10mm_P0.5mm_EP5x5mm (KiCad#1461)
  Fix courtyard clearances for scripted no lead footprints with pull back pins (KiCad#1630)
  Add VQFN-16-1EP_3x3mm_P0.5mm_EP1.6x1.6mm_ThermalVias (KiCad#1605)
  Add QFN-40 footprint for IS31FL3736/7 (KiCad#1625)
  added L_Bourns_SRN8040TA (KiCad#1628)
  Added Palconn UTC16-G connector (KiCad#789)
  Package_SO: Add SOIC 8 5.257x5.275 (KiCad#1601)
  Added NXP_LGA-8 for MPL3115A2 (KiCad#1607)
  add Mini-Circuits XX112 SO package (KiCad#1062)
  add SMA jack Amphenol 132203-12 (KiCad#1456)
  Converter_ACDC: Add TMG 15 series (KiCad#1603)
  Add molex EDGELOCK (KiCad#1054)
  Abracon ASPI-0630LR inductor (KiCad#1503)
  Mentor 4 way lightpipes 1276.1004 and 1276.2004 (KiCad#1429)
  add E-Switch 800U in M6 variant (KiCad#1454)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants