Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fix pad orientation of SW_Push_1P1T_NO_CK_KMR2 #1593

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Fix pad orientation of SW_Push_1P1T_NO_CK_KMR2 #1593

merged 1 commit into from
Jun 10, 2019

Conversation

mibe
Copy link
Contributor

@mibe mibe commented May 11, 2019 •
edited
Loading

The pads of this footprint are wrongly rotated by 90°. This means the pad size is off by 0.1 mm in each axis. This probably doesn't matter in practice, but still...

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@mibe
Fix pad orientation of SW_Push_1P1T_NO_CK_KMR2
08f447c 
The pads of this footprint are wrongly rotated by 90°. This means the pad size is off by 0.1 mm in each axis. This probably doesn't matter in practice, but still...
@CLAassistant
Copy link

CLAassistant commented May 11, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@myfreescalewebpage myfreescalewebpage added Bug Fix footprint existing in the library Pending reviewer A pull request waiting for a reviewer labels May 12, 2019
@evanshultz evanshultz self-assigned this May 28, 2019
@evanshultz
Copy link
Collaborator

@mibe
First, you need to sign the CLA above before we can accept any submission.

Datasheet is at https://www.ckswitches.com/media/1479/kmr2.pdf, and it makes review easier if you put it here. Including the library name would also help. But, that's isn't too hard to find.

After a quick review, yes, you're right. And your commit looks good to fix the issue. Thanks for noticing this and taking the time to post a fix. If you sign the CLA I'll be happy to merge.

@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label May 30, 2019
@mibe
Copy link
Contributor Author

mibe commented Jun 9, 2019 •
edited
Loading

CLA
-- signed: mibe, 2019-06-09

The datasheet PDF is already linked in the mod file. That's why I didn't linked it here.
Understood, I'll include the library name the next time.

@evanshultz
Copy link
Collaborator

Thank you! We appreciate your efforts to fix the library and hope you will contribute again!

@evanshultz evanshultz merged commit 07096d0 into KiCad:master Jun 10, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone Jun 10, 2019
@mibe mibe deleted the patch-1 branch June 10, 2019 20:12
DaToBSn pushed a commit to DaToBSn/kicad-footprints that referenced this pull request Jul 2, 2019
Merge branch 'master' of github.com:KiCad/kicad-footprints
5f38da4 
* 'master' of github.com:KiCad/kicad-footprints: (41 commits)
  fixing partnumber of Slimstack 52991 connectors (KiCad#1642)
  Fix pad orientation of SW_Push_1P1T_NO_CK_KMR2 (KiCad#1593)
  added QFN-72 (KiCad#1632)
  Scripted TDK SLF series inductors (KiCad#1021)
  Add Linear Technology (Analog devices) MSOP-16 footprints (KiCad#1349)
  Add LQFP-64-1EP_10x10mm_P0.5mm_EP5x5mm (KiCad#1461)
  Fix courtyard clearances for scripted no lead footprints with pull back pins (KiCad#1630)
  Add VQFN-16-1EP_3x3mm_P0.5mm_EP1.6x1.6mm_ThermalVias (KiCad#1605)
  Add QFN-40 footprint for IS31FL3736/7 (KiCad#1625)
  added L_Bourns_SRN8040TA (KiCad#1628)
  Added Palconn UTC16-G connector (KiCad#789)
  Package_SO: Add SOIC 8 5.257x5.275 (KiCad#1601)
  Added NXP_LGA-8 for MPL3115A2 (KiCad#1607)
  add Mini-Circuits XX112 SO package (KiCad#1062)
  add SMA jack Amphenol 132203-12 (KiCad#1456)
  Converter_ACDC: Add TMG 15 series (KiCad#1603)
  Add molex EDGELOCK (KiCad#1054)
  Abracon ASPI-0630LR inductor (KiCad#1503)
  Mentor 4 way lightpipes 1276.1004 and 1276.2004 (KiCad#1429)
  add E-Switch 800U in M6 variant (KiCad#1454)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@evanshultz evanshultz

Labels
Bug Fix footprint existing in the library
Projects
None yet
Milestone
5.1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@mibe @CLAassistant @evanshultz @antoniovazquezblanco @myfreescalewebpage