This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Mentor 4 way lightpipes 1276.1004 and 1276.2004 #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myfreescalewebpage
added
the
Pending reviewer
|
note to self before this is merged: The silk screen needs to be adjusted as it collides with the pin 1 marker of PLCC-2 LEDs placed withitin. |
|
I reduced the silk screen to look like this: This is how it looks with PLCC-2 diodes placed inside (Fab and courtyard layers disabled): |
|
Looks good in general. I however found a small break in the fab outline. (Minor problem but would still be nice to be fixed. Marked with red arrow)
|
poeschlr
added
Pending changes
and removed
Pending reviewer
|
thanks for the review. Should be fixed now. |
|
thanks |
DaToBSn
pushed a commit
to DaToBSn/kicad-footprints
that referenced
this pull request
Jul 2, 2019
* 'master' of github.com:KiCad/kicad-footprints: (41 commits) fixing partnumber of Slimstack 52991 connectors (KiCad#1642) Fix pad orientation of SW_Push_1P1T_NO_CK_KMR2 (KiCad#1593) added QFN-72 (KiCad#1632) Scripted TDK SLF series inductors (KiCad#1021) Add Linear Technology (Analog devices) MSOP-16 footprints (KiCad#1349) Add LQFP-64-1EP_10x10mm_P0.5mm_EP5x5mm (KiCad#1461) Fix courtyard clearances for scripted no lead footprints with pull back pins (KiCad#1630) Add VQFN-16-1EP_3x3mm_P0.5mm_EP1.6x1.6mm_ThermalVias (KiCad#1605) Add QFN-40 footprint for IS31FL3736/7 (KiCad#1625) added L_Bourns_SRN8040TA (KiCad#1628) Added Palconn UTC16-G connector (KiCad#789) Package_SO: Add SOIC 8 5.257x5.275 (KiCad#1601) Added NXP_LGA-8 for MPL3115A2 (KiCad#1607) add Mini-Circuits XX112 SO package (KiCad#1062) add SMA jack Amphenol 132203-12 (KiCad#1456) Converter_ACDC: Add TMG 15 series (KiCad#1603) Add molex EDGELOCK (KiCad#1054) Abracon ASPI-0630LR inductor (KiCad#1503) Mentor 4 way lightpipes 1276.1004 and 1276.2004 (KiCad#1429) add E-Switch 800U in M6 variant (KiCad#1454) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two very similar lightpipes from Mentor. They can be found in their product overview at page 28. The two different variants have a spherical and a planar end, but otherwise they are identical.
I was first thinking of not extending the silk screen all the way to the front of the lightpipe, but then the silk screen is completely symmetric. Do you maybe have a suggestion on how to solve this? The front part of the lightpipe will most likely not be on the PCB anymore.