Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Tdk inductor #1021

Merged
merged 4 commits into from
Jun 7, 2019
Merged

Tdk inductor #1021

merged 4 commits into from
Jun 7, 2019

Conversation

Misca1234
Copy link
Collaborator

@Misca1234 Misca1234 commented Oct 16, 2018 •
edited by poeschlr
Loading

Example datasheet https://product.tdk.com/info/en/catalog/datasheets/inductor_automotive_power_slf10145-h_en.pdf

This push is replacing the push in
#352

It is script based, where data is in a .yml file

Foot print push
#1021

Foot print script push
pointhi/kicad-footprint-generator#201

bild

bild

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@Misca1234 Misca1234 mentioned this pull request Oct 16, 2018
Merged
@evanshultz
Copy link
Collaborator

Just a question here without a real review: Should these have a notch in fab and silk?
image

@Misca1234
Copy link
Collaborator Author

Jee, I need to modify that

@Misca1234
Copy link
Collaborator Author

Fixed the corners

This was referenced Oct 18, 2018
Merged
Merged
@poeschlr poeschlr added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Dec 22, 2018
@poeschlr
Copy link
Collaborator

The notch and rounded corners are not dimensioned in the linked datasheet. Where did you get their dimensions from?

@poeschlr poeschlr self-assigned this Dec 23, 2018
@poeschlr poeschlr added Question Issue: request for clarification or support, PR: There is an open question (by author or maintainer) and removed Pending reviewer A pull request waiting for a reviewer labels Dec 23, 2018
@Misca1234
Copy link
Collaborator Author

The notch I used 0.9 mm and the rounded corner was artistic freedom

@poeschlr
Copy link
Collaborator

In that case a simple rectangle might be a better choice. If we include notches and rounded corners in the outline then users will expect them to have the correct size. Especially as your courtyard follows the outline this closely.

@Misca1234
Copy link
Collaborator Author

Ok, I change them to be rectangle then

@Misca1234
Copy link
Collaborator Author

Misca1234 commented Dec 26, 2018 •
edited
Loading

The corners are now 90 degree

Updated script push is here
pointhi/kicad-footprint-generator#254

bild

bild

@Misca1234 Misca1234 mentioned this pull request Dec 27, 2018
Merged
@Misca1234 Misca1234 mentioned this pull request Feb 2, 2019
Closed
@poeschlr poeschlr added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Question Issue: request for clarification or support, PR: There is an open question (by author or maintainer) labels Jun 6, 2019
@poeschlr
Copy link
Collaborator

poeschlr commented Jun 7, 2019

Thanks and sorry about forgetting this for so long.

@poeschlr poeschlr merged commit f6e6f5b into KiCad:master Jun 7, 2019
@poeschlr poeschlr removed the Ready for review Use this to mark pull requests that are updated but you could not review instantly label Jun 7, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone Jun 10, 2019
DaToBSn pushed a commit to DaToBSn/kicad-footprints that referenced this pull request Jul 2, 2019
Merge branch 'master' of github.com:KiCad/kicad-footprints
5f38da4 
* 'master' of github.com:KiCad/kicad-footprints: (41 commits)
  fixing partnumber of Slimstack 52991 connectors (KiCad#1642)
  Fix pad orientation of SW_Push_1P1T_NO_CK_KMR2 (KiCad#1593)
  added QFN-72 (KiCad#1632)
  Scripted TDK SLF series inductors (KiCad#1021)
  Add Linear Technology (Analog devices) MSOP-16 footprints (KiCad#1349)
  Add LQFP-64-1EP_10x10mm_P0.5mm_EP5x5mm (KiCad#1461)
  Fix courtyard clearances for scripted no lead footprints with pull back pins (KiCad#1630)
  Add VQFN-16-1EP_3x3mm_P0.5mm_EP1.6x1.6mm_ThermalVias (KiCad#1605)
  Add QFN-40 footprint for IS31FL3736/7 (KiCad#1625)
  added L_Bourns_SRN8040TA (KiCad#1628)
  Added Palconn UTC16-G connector (KiCad#789)
  Package_SO: Add SOIC 8 5.257x5.275 (KiCad#1601)
  Added NXP_LGA-8 for MPL3115A2 (KiCad#1607)
  add Mini-Circuits XX112 SO package (KiCad#1062)
  add SMA jack Amphenol 132203-12 (KiCad#1456)
  Converter_ACDC: Add TMG 15 series (KiCad#1603)
  Add molex EDGELOCK (KiCad#1054)
  Abracon ASPI-0630LR inductor (KiCad#1503)
  Mentor 4 way lightpipes 1276.1004 and 1276.2004 (KiCad#1429)
  add E-Switch 800U in M6 variant (KiCad#1454)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@poeschlr poeschlr

Labels
Addition Adds new footprint to library
Projects
None yet
Milestone
5.1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Misca1234 @evanshultz @poeschlr @antoniovazquezblanco