Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add molex EDGELOCK #1054

Merged
merged 6 commits into from
Jun 2, 2019
Merged

Conversation

asukiaaa
Copy link
Contributor

@asukiaaa asukiaaa commented Oct 29, 2018

I add 6pins version EDGELOCK.
If 6pins version pass review, I will add 2, 4, 8 version with using footprint generator script.
Thank you.

Datasheet: https://www.molex.com/pdm_docs/sd/2008900106_sd.pdf

screenshot from 2018-10-29 22-52-30

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@asukiaaa asukiaaa force-pushed the feature/add-molex-EDGELOCK branch from 0d39023 to 0609d91 Compare October 29, 2018 14:15
@asukiaaa asukiaaa force-pushed the feature/add-molex-EDGELOCK branch from 0609d91 to df10d50 Compare October 29, 2018 14:51
@evanshultz
Copy link
Collaborator

So was this done with a script? If so, please submit the script as a PR and link it here so we can inspect the script. That's the most important thing.

And really, it's so easy to add more footprints via script that there's no harm in going ahead and adding all of them at once. Updating due to any feedback is just one click.

@asukiaaa
Copy link
Contributor Author

This is the script.
pointhi/kicad-footprint-generator#215
I willtI share a script and a footprint together next time.

@asukiaaa asukiaaa force-pushed the feature/add-molex-EDGELOCK branch from 9343587 to 7453438 Compare November 1, 2018 22:48
@asukiaaa
Copy link
Contributor Author

asukiaaa commented Nov 1, 2018

I add 2, 4 and 8.

screenshot from 2018-11-02 07-46-50
screenshot from 2018-11-02 07-47-39
screenshot from 2018-11-02 07-48-16

@DanSGiesbrecht DanSGiesbrecht added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Dec 2, 2018
@poeschlr
Copy link
Collaborator

poeschlr commented Jun 1, 2019

Sorry for the long delay. It seems you pull request got a bit forgotten.

Add a note on the comments layer and indicator on the dwgs layer for the chamfered leading edge.
Maybe also a note about the maximum internal radii.

I am not sure what note 6 means but it seems important.

Dimensions look good. For reference:
Screenshot from 2019-06-01 09-51-32

@poeschlr poeschlr self-assigned this Jun 1, 2019
@poeschlr poeschlr added Pending changes and removed Pending reviewer A pull request waiting for a reviewer labels Jun 1, 2019
@asukiaaa asukiaaa changed the title Add molex EDGELOCK 6-CKT Add molex EDGELOCK Jun 1, 2019
@asukiaaa
Copy link
Contributor Author

asukiaaa commented Jun 1, 2019

Thank you for the feedback but I'm not clear what you require.
Please let me to ask questions.

Add a note on the comments layer and indicator on the dwgs layer for the chamfered leading edge.
Maybe also a note about the maximum internal radii.

What note should I add to dwgs layer?
Do you require me to add guide of length like a picgure you showed?
Could you show some example?

I am not sure what note 6 means but it seems important.

The 6 means 6 on tile of this issue?
The reason of 6 is the first footprint that I show was EDGELOCK 6-CKT.
You reviewed EDGELOCK 8-CKT so I remove 6 from title.

Dimensions look good.

Thank you for checking.

@poeschlr
Copy link
Collaborator

poeschlr commented Jun 1, 2019

With note 6 i mean note 6 in the datasheet.


Regarding markings: A bit of text and a few lines should be enough. A quick draft as inspiration (made on your screenshot using inkscape)

47884377-d622a480-de73-11e8-9495-1b717f796096

But you can of course make a wonderful drawing for these if you are overly motivated. (These should just be notes for the designer such that they remember to ask the manufacturer for special treatment.)

@asukiaaa
Copy link
Contributor Author

asukiaaa commented Jun 2, 2019

Thank you for the feedback.

I updated the footprints.

  • Use rounded lines for Edge.Cuts.
  • Add comment and lines about chamfer for Cmts.User.

Screenshot from 2019-06-02 15-02-02

Do I need to put lies for chamfer on Margin layer because you use pink lines for example?

@poeschlr
Copy link
Collaborator

poeschlr commented Jun 2, 2019

I used pink because that is what inkscape was setup from the last time i used it. You have placed both the text and line on the cmts layer. We typically put drawings onto the dwgs.user layer.

@asukiaaa
Copy link
Contributor Author

asukiaaa commented Jun 2, 2019

Thank you for the feedback.
I change layer to put lines about chamfer as Dwgs.User.
Screenshot from 2019-06-02 15-54-12

@poeschlr
Copy link
Collaborator

poeschlr commented Jun 2, 2019

thanks

@poeschlr poeschlr merged commit 06b7930 into KiCad:master Jun 2, 2019
@asukiaaa
Copy link
Contributor Author

asukiaaa commented Jun 2, 2019

Thank you for checking and merging.

@asukiaaa asukiaaa deleted the feature/add-molex-EDGELOCK branch June 2, 2019 22:36
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone Jun 3, 2019
DaToBSn pushed a commit to DaToBSn/kicad-footprints that referenced this pull request Jul 2, 2019
* 'master' of github.com:KiCad/kicad-footprints: (41 commits)
  fixing partnumber of Slimstack 52991 connectors (KiCad#1642)
  Fix pad orientation of SW_Push_1P1T_NO_CK_KMR2 (KiCad#1593)
  added QFN-72 (KiCad#1632)
  Scripted TDK SLF series inductors (KiCad#1021)
  Add Linear Technology (Analog devices) MSOP-16 footprints (KiCad#1349)
  Add LQFP-64-1EP_10x10mm_P0.5mm_EP5x5mm (KiCad#1461)
  Fix courtyard clearances for scripted no lead footprints with pull back pins (KiCad#1630)
  Add VQFN-16-1EP_3x3mm_P0.5mm_EP1.6x1.6mm_ThermalVias (KiCad#1605)
  Add QFN-40 footprint for IS31FL3736/7 (KiCad#1625)
  added L_Bourns_SRN8040TA (KiCad#1628)
  Added Palconn UTC16-G connector (KiCad#789)
  Package_SO: Add SOIC 8 5.257x5.275 (KiCad#1601)
  Added NXP_LGA-8 for MPL3115A2 (KiCad#1607)
  add Mini-Circuits XX112 SO package (KiCad#1062)
  add SMA jack Amphenol 132203-12 (KiCad#1456)
  Converter_ACDC: Add TMG 15 series (KiCad#1603)
  Add molex EDGELOCK (KiCad#1054)
  Abracon ASPI-0630LR inductor (KiCad#1503)
  Mentor 4 way lightpipes 1276.1004 and 1276.2004 (KiCad#1429)
  add E-Switch 800U in M6 variant (KiCad#1454)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants