-
Notifications
You must be signed in to change notification settings - Fork 712
Conversation
0d39023
to
0609d91
Compare
0609d91
to
df10d50
Compare
So was this done with a script? If so, please submit the script as a PR and link it here so we can inspect the script. That's the most important thing. And really, it's so easy to add more footprints via script that there's no harm in going ahead and adding all of them at once. Updating due to any feedback is just one click. |
This is the script. |
9343587
to
7453438
Compare
Sorry for the long delay. It seems you pull request got a bit forgotten. Add a note on the comments layer and indicator on the dwgs layer for the chamfered leading edge. I am not sure what note 6 means but it seems important. |
Thank you for the feedback but I'm not clear what you require.
What note should I add to dwgs layer?
The
Thank you for checking. |
With note 6 i mean note 6 in the datasheet. Regarding markings: A bit of text and a few lines should be enough. A quick draft as inspiration (made on your screenshot using inkscape) But you can of course make a wonderful drawing for these if you are overly motivated. (These should just be notes for the designer such that they remember to ask the manufacturer for special treatment.) |
I used pink because that is what inkscape was setup from the last time i used it. You have placed both the text and line on the cmts layer. We typically put drawings onto the dwgs.user layer. |
thanks |
Thank you for checking and merging. |
* 'master' of github.com:KiCad/kicad-footprints: (41 commits) fixing partnumber of Slimstack 52991 connectors (KiCad#1642) Fix pad orientation of SW_Push_1P1T_NO_CK_KMR2 (KiCad#1593) added QFN-72 (KiCad#1632) Scripted TDK SLF series inductors (KiCad#1021) Add Linear Technology (Analog devices) MSOP-16 footprints (KiCad#1349) Add LQFP-64-1EP_10x10mm_P0.5mm_EP5x5mm (KiCad#1461) Fix courtyard clearances for scripted no lead footprints with pull back pins (KiCad#1630) Add VQFN-16-1EP_3x3mm_P0.5mm_EP1.6x1.6mm_ThermalVias (KiCad#1605) Add QFN-40 footprint for IS31FL3736/7 (KiCad#1625) added L_Bourns_SRN8040TA (KiCad#1628) Added Palconn UTC16-G connector (KiCad#789) Package_SO: Add SOIC 8 5.257x5.275 (KiCad#1601) Added NXP_LGA-8 for MPL3115A2 (KiCad#1607) add Mini-Circuits XX112 SO package (KiCad#1062) add SMA jack Amphenol 132203-12 (KiCad#1456) Converter_ACDC: Add TMG 15 series (KiCad#1603) Add molex EDGELOCK (KiCad#1054) Abracon ASPI-0630LR inductor (KiCad#1503) Mentor 4 way lightpipes 1276.1004 and 1276.2004 (KiCad#1429) add E-Switch 800U in M6 variant (KiCad#1454) ...
I add 6pins version EDGELOCK.
If 6pins version pass review, I will add 2, 4, 8 version with using footprint generator script.
Thank you.
Datasheet: https://www.molex.com/pdm_docs/sd/2008900106_sd.pdf
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: