This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Changed footpint name to be more generic #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 5b322bf and detected 0 issues on this pull request. View more on Code Climate. |
This was referenced May 1, 2019
|
OK to be merged |
|
Have added parameters to generate the same footprint but with suffix "_H1.1mm" earlier commit as changing the name to suffix "_H1.2mm" |
5 tasks
poeschlr
suggested changes
Jun 2, 2019
| use_name_format: 'LGA' | ||
| manufacturer: 'NXP' | ||
| #part_number: 'MPL115A1' | ||
| size_source: 'https://www.nxp.com/docs/en/data-sheet/MPL3115A2.pdf' |
There was a problem hiding this comment.
please add #page=42 to point directly to the correct page.
| nominal: 5 | ||
| tolerance: 0 | ||
| body_height: | ||
| maximum: 1.2 |
There was a problem hiding this comment.
given as 1.1 with 0.1 tolerance so please use the same here
poeschlr
suggested changes
Jun 3, 2019
scripts/Packages/Package_NoLead__DFN_QFN_LGA_SON/size_definitions/lga.yaml
Show resolved
Hide resolved
|
@pointhi this can be merged as soon as the height parameter is fixed. (the footprint has already been merged as it is not influenced by the parameter prepared for 3d modeling reuse.) |
|
hope get right this time |
poeschlr
approved these changes
Sep 27, 2019
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changed on the footprint name to be generic.