Skip to content

ServiceTalk Captured Context API Instrumentation for v0.42.56+ #8821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

ServiceTalk Captured Context API Instrumentation for v0.42.56+ #8821

wants to merge 27 commits into from
+859 −208

Conversation

ygree
Copy link
Contributor

@ygree ygree commented May 13, 2025 •
edited
Loading

What Does This Do

Implements new instrumentation for the captured context API available in ServiceTalk 0.42.56+
It also splits the instrumentation in two:

  • ServiceTalk prior (<) v0.42.56
    Uses the previous instrumentation approach.
  • ServiceTalk v0.42.56+
    Uses the new Captured Context API.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented May 14, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ygree/servicetalk-concurrent-instrumentation-0.42.56
git_commit_date 1746789389 1747991616
git_commit_sha ad6d5fe 5c2f307
release_version 1.50.0-SNAPSHOT~ad6d5fef42 1.50.0-SNAPSHOT~5c2f307d8a
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747993928 1747993928
ci_job_id 951739736 951739736
ci_pipeline_id 65956615 65956615
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-xffk-g1f-project-304-concurrent-0-0obose1z 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-xffk-g1f-project-304-concurrent-0-0obose1z 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 53 metrics, 15 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:profiling:GlobalTracer better
[-21.050ms; -18.038ms] or [-5.548%; -4.754%]		 359.859ms 379.403ms
scenario:startup:petclinic:profiling:AppSec worse
[+5.752ms; +8.793ms] or [+10.543%; +16.116%]		 61.833ms 54.560ms
scenario:startup:petclinic:profiling:Debugger worse
[+132.038µs; +288.071µs] or [+2.147%; +4.684%]		 6.361ms 6.151ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~5c2f307d8a, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1021682
Total [baseline] (8.651 s) : 0, 8651183
Agent [candidate] (1.023 s) : 0, 1023465
Total [candidate] (8.656 s) : 0, 8655606
section iast
Agent [baseline] (1.156 s) : 0, 1155763
Total [baseline] (9.284 s) : 0, 9284289
Agent [candidate] (1.15 s) : 0, 1150002
Total [candidate] (9.23 s) : 0, 9229572
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.15 s) : 0, 1150018
Total [baseline] (9.212 s) : 0, 9211794
Agent [candidate] (1.158 s) : 0, 1158313
Total [candidate] (9.21 s) : 0, 9209853
section iast_TELEMETRY_OFF
Agent [baseline] (1.145 s) : 0, 1145107
Total [baseline] (9.198 s) : 0, 9198267
Agent [candidate] (1.15 s) : 0, 1150076
Total [candidate] (9.248 s) : 0, 9248161
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.022 s -
Agent iast 1.156 s 134.081 ms (13.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.15 s 128.336 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.145 s 123.424 ms (12.1%)
Total tracing 8.651 s -
Total iast 9.284 s 633.106 ms (7.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.212 s 560.611 ms (6.5%)
Total iast_TELEMETRY_OFF 9.198 s 547.084 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.023 s -
Agent iast 1.15 s 126.537 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.158 s 134.848 ms (13.2%)
Agent iast_TELEMETRY_OFF 1.15 s 126.611 ms (12.4%)
Total tracing 8.656 s -
Total iast 9.23 s 573.966 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.21 s 554.247 ms (6.4%)
Total iast_TELEMETRY_OFF 9.248 s 592.556 ms (6.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~5c2f307d8a, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.822 ms) : 0, 682822
BytebuddyAgent [candidate] (683.216 ms) : 0, 683216
GlobalTracer [baseline] (240.076 ms) : 0, 240076
GlobalTracer [candidate] (240.54 ms) : 0, 240540
AppSec [baseline] (55.3 ms) : 0, 55300
AppSec [candidate] (55.815 ms) : 0, 55815
Debugger [baseline] (9.307 ms) : 0, 9307
Debugger [candidate] (8.44 ms) : 0, 8440
Remote Config [baseline] (755.942 µs) : 0, 756
Remote Config [candidate] (706.366 µs) : 0, 706
Telemetry [baseline] (9.857 ms) : 0, 9857
Telemetry [candidate] (11.145 ms) : 0, 11145
section iast
BytebuddyAgent [baseline] (807.126 ms) : 0, 807126
BytebuddyAgent [candidate] (802.862 ms) : 0, 802862
GlobalTracer [baseline] (231.688 ms) : 0, 231688
GlobalTracer [candidate] (230.931 ms) : 0, 230931
AppSec [baseline] (51.387 ms) : 0, 51387
AppSec [candidate] (50.861 ms) : 0, 50861
Debugger [baseline] (5.849 ms) : 0, 5849
Debugger [candidate] (5.93 ms) : 0, 5930
Remote Config [baseline] (595.681 µs) : 0, 596
Remote Config [candidate] (601.36 µs) : 0, 601
Telemetry [baseline] (7.873 ms) : 0, 7873
Telemetry [candidate] (7.856 ms) : 0, 7856
IAST [baseline] (27.631 ms) : 0, 27631
IAST [candidate] (27.399 ms) : 0, 27399
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.276 ms) : 0, 802276
BytebuddyAgent [candidate] (808.615 ms) : 0, 808615
GlobalTracer [baseline] (230.481 ms) : 0, 230481
GlobalTracer [candidate] (232.604 ms) : 0, 232604
AppSec [baseline] (52.343 ms) : 0, 52343
AppSec [candidate] (49.597 ms) : 0, 49597
Debugger [baseline] (5.924 ms) : 0, 5924
Debugger [candidate] (5.955 ms) : 0, 5955
Remote Config [baseline] (587.595 µs) : 0, 588
Remote Config [candidate] (610.319 µs) : 0, 610
Telemetry [baseline] (7.911 ms) : 0, 7911
Telemetry [candidate] (8.018 ms) : 0, 8018
IAST [baseline] (26.844 ms) : 0, 26844
IAST [candidate] (29.244 ms) : 0, 29244
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.598 ms) : 0, 798598
BytebuddyAgent [candidate] (802.144 ms) : 0, 802144
GlobalTracer [baseline] (230.29 ms) : 0, 230290
GlobalTracer [candidate] (231.602 ms) : 0, 231602
AppSec [baseline] (55.901 ms) : 0, 55901
AppSec [candidate] (52.094 ms) : 0, 52094
Debugger [baseline] (5.976 ms) : 0, 5976
Debugger [candidate] (5.952 ms) : 0, 5952
Remote Config [baseline] (594.091 µs) : 0, 594
Remote Config [candidate] (607.252 µs) : 0, 607
Telemetry [baseline] (7.783 ms) : 0, 7783
Telemetry [candidate] (7.888 ms) : 0, 7888
IAST [baseline] (22.369 ms) : 0, 22369
IAST [candidate] (23.955 ms) : 0, 23955
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~5c2f307d8a, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1020896
Total [baseline] (10.467 s) : 0, 10466773
Agent [candidate] (1.037 s) : 0, 1037429
Total [candidate] (10.52 s) : 0, 10520410
section appsec
Agent [baseline] (1.168 s) : 0, 1167824
Total [baseline] (10.671 s) : 0, 10670900
Agent [candidate] (1.162 s) : 0, 1162265
Total [candidate] (10.641 s) : 0, 10641437
section iast
Agent [baseline] (1.159 s) : 0, 1159383
Total [baseline] (10.897 s) : 0, 10896830
Agent [candidate] (1.167 s) : 0, 1166690
Total [candidate] (10.938 s) : 0, 10938424
section profiling
Agent [baseline] (1.282 s) : 0, 1282141
Total [baseline] (10.933 s) : 0, 10933251
Agent [candidate] (1.27 s) : 0, 1269781
Total [candidate] (10.844 s) : 0, 10843505
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.021 s -
Agent appsec 1.168 s 146.929 ms (14.4%)
Agent iast 1.159 s 138.487 ms (13.6%)
Agent profiling 1.282 s 261.245 ms (25.6%)
Total tracing 10.467 s -
Total appsec 10.671 s 204.127 ms (2.0%)
Total iast 10.897 s 430.056 ms (4.1%)
Total profiling 10.933 s 466.478 ms (4.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.037 s -
Agent appsec 1.162 s 124.836 ms (12.0%)
Agent iast 1.167 s 129.261 ms (12.5%)
Agent profiling 1.27 s 232.352 ms (22.4%)
Total tracing 10.52 s -
Total appsec 10.641 s 121.027 ms (1.2%)
Total iast 10.938 s 418.013 ms (4.0%)
Total profiling 10.844 s 323.095 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~5c2f307d8a, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.363 ms) : 0, 683363
BytebuddyAgent [candidate] (693.581 ms) : 0, 693581
GlobalTracer [baseline] (239.976 ms) : 0, 239976
GlobalTracer [candidate] (243.508 ms) : 0, 243508
AppSec [baseline] (54.361 ms) : 0, 54361
AppSec [candidate] (55.844 ms) : 0, 55844
Debugger [baseline] (10.645 ms) : 0, 10645
Debugger [candidate] (9.081 ms) : 0, 9081
Remote Config [baseline] (675.783 µs) : 0, 676
Remote Config [candidate] (709.222 µs) : 0, 709
Telemetry [baseline] (8.232 ms) : 0, 8232
Telemetry [candidate] (10.719 ms) : 0, 10719
section appsec
BytebuddyAgent [baseline] (705.016 ms) : 0, 705016
BytebuddyAgent [candidate] (700.922 ms) : 0, 700922
GlobalTracer [baseline] (237.825 ms) : 0, 237825
GlobalTracer [candidate] (236.78 ms) : 0, 236780
AppSec [baseline] (176.093 ms) : 0, 176093
AppSec [candidate] (175.922 ms) : 0, 175922
Debugger [baseline] (5.962 ms) : 0, 5962
Debugger [candidate] (5.926 ms) : 0, 5926
Remote Config [baseline] (624.553 µs) : 0, 625
Remote Config [candidate] (629.688 µs) : 0, 630
Telemetry [baseline] (7.779 ms) : 0, 7779
Telemetry [candidate] (7.691 ms) : 0, 7691
IAST [baseline] (21.733 ms) : 0, 21733
IAST [candidate] (21.756 ms) : 0, 21756
section iast
BytebuddyAgent [baseline] (809.773 ms) : 0, 809773
BytebuddyAgent [candidate] (814.331 ms) : 0, 814331
GlobalTracer [baseline] (232.032 ms) : 0, 232032
GlobalTracer [candidate] (234.526 ms) : 0, 234526
AppSec [baseline] (52.448 ms) : 0, 52448
AppSec [candidate] (48.247 ms) : 0, 48247
Debugger [baseline] (6.043 ms) : 0, 6043
Debugger [candidate] (6.0 ms) : 0, 6000
Remote Config [baseline] (612.385 µs) : 0, 612
Remote Config [candidate] (598.989 µs) : 0, 599
Telemetry [baseline] (7.964 ms) : 0, 7964
Telemetry [candidate] (8.07 ms) : 0, 8070
IAST [baseline] (26.848 ms) : 0, 26848
IAST [candidate] (31.248 ms) : 0, 31248
section profiling
ProfilingAgent [baseline] (109.852 ms) : 0, 109852
ProfilingAgent [candidate] (105.68 ms) : 0, 105680
BytebuddyAgent [baseline] (672.688 ms) : 0, 672688
BytebuddyAgent [candidate] (676.0 ms) : 0, 676000
GlobalTracer [baseline] (379.403 ms) : 0, 379403
GlobalTracer [candidate] (359.859 ms) : 0, 359859
AppSec [baseline] (54.56 ms) : 0, 54560
AppSec [candidate] (61.833 ms) : 0, 61833
Debugger [baseline] (6.151 ms) : 0, 6151
Debugger [candidate] (6.361 ms) : 0, 6361
Remote Config [baseline] (660.661 µs) : 0, 661
Remote Config [candidate] (676.354 µs) : 0, 676
Telemetry [baseline] (8.095 ms) : 0, 8095
Telemetry [candidate] (8.244 ms) : 0, 8244
Profiling [baseline] (109.878 ms) : 0, 109878
Profiling [candidate] (105.705 ms) : 0, 105705
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-05-23T09:24:23 2025-05-23T09:32:07
git_branch master ygree/servicetalk-concurrent-instrumentation-0.42.56
git_commit_date 1746789389 1747991616
git_commit_sha ad6d5fe 5c2f307
release_version 1.50.0-SNAPSHOT~ad6d5fef42 1.50.0-SNAPSHOT~5c2f307d8a
start_time 2025-05-23T09:24:08 2025-05-23T09:31:53
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747993127 1747993127
ci_job_id 951739737 951739737
ci_pipeline_id 65956615 65956615
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-m-a1n7tr-project-304-concurrent-0-vl8ld1wy 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-m-a1n7tr-project-304-concurrent-0-vl8ld1wy 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~5c2f307d8a, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (388.87 µs) : 369, 409
.   : milestone, 389,
iast (523.026 µs) : 500, 546
.   : milestone, 523,
iast_FULL (730.47 µs) : 709, 752
.   : milestone, 730,
iast_GLOBAL (564.271 µs) : 542, 586
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (516.095 µs) : 494, 538
.   : milestone, 516,
iast_INACTIVE (470.438 µs) : 448, 493
.   : milestone, 470,
iast_TELEMETRY_OFF (504.344 µs) : 481, 527
.   : milestone, 504,
tracing (462.418 µs) : 440, 484
.   : milestone, 462,
section candidate
no_agent (383.668 µs) : 363, 404
.   : milestone, 384,
iast (523.553 µs) : 502, 545
.   : milestone, 524,
iast_FULL (733.683 µs) : 712, 756
.   : milestone, 734,
iast_GLOBAL (570.721 µs) : 547, 594
.   : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (524.065 µs) : 502, 546
.   : milestone, 524,
iast_INACTIVE (465.05 µs) : 444, 487
.   : milestone, 465,
iast_TELEMETRY_OFF (521.13 µs) : 498, 544
.   : milestone, 521,
tracing (463.679 µs) : 442, 486
.   : milestone, 464,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 388.87 µs [369.093 µs, 408.646 µs] -
iast 523.026 µs [499.638 µs, 546.413 µs] 134.156 µs (34.5%)
iast_FULL 730.47 µs [708.65 µs, 752.29 µs] 341.601 µs (87.8%)
iast_GLOBAL 564.271 µs [542.147 µs, 586.395 µs] 175.401 µs (45.1%)
iast_HARDCODED_SECRET_DISABLED 516.095 µs [494.419 µs, 537.77 µs] 127.225 µs (32.7%)
iast_INACTIVE 470.438 µs [447.623 µs, 493.254 µs] 81.569 µs (21.0%)
iast_TELEMETRY_OFF 504.344 µs [481.213 µs, 527.475 µs] 115.474 µs (29.7%)
tracing 462.418 µs [440.401 µs, 484.434 µs] 73.548 µs (18.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.668 µs [362.845 µs, 404.492 µs] -
iast 523.553 µs [501.803 µs, 545.302 µs] 139.884 µs (36.5%)
iast_FULL 733.683 µs [711.742 µs, 755.625 µs] 350.015 µs (91.2%)
iast_GLOBAL 570.721 µs [547.421 µs, 594.022 µs] 187.053 µs (48.8%)
iast_HARDCODED_SECRET_DISABLED 524.065 µs [502.116 µs, 546.013 µs] 140.397 µs (36.6%)
iast_INACTIVE 465.05 µs [443.535 µs, 486.565 µs] 81.382 µs (21.2%)
iast_TELEMETRY_OFF 521.13 µs [498.075 µs, 544.186 µs] 137.462 µs (35.8%)
tracing 463.679 µs [441.764 µs, 485.593 µs] 80.011 µs (20.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~5c2f307d8a, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.352 ms) : 1333, 1372
.   : milestone, 1352,
appsec (1.738 ms) : 1715, 1761
.   : milestone, 1738,
appsec_no_iast (1.737 ms) : 1713, 1760
.   : milestone, 1737,
code_origins (1.662 ms) : 1636, 1689
.   : milestone, 1662,
iast (1.53 ms) : 1507, 1554
.   : milestone, 1530,
profiling (1.537 ms) : 1514, 1560
.   : milestone, 1537,
tracing (1.499 ms) : 1477, 1522
.   : milestone, 1499,
section candidate
no_agent (1.361 ms) : 1341, 1380
.   : milestone, 1361,
appsec (1.734 ms) : 1710, 1758
.   : milestone, 1734,
appsec_no_iast (1.743 ms) : 1720, 1766
.   : milestone, 1743,
code_origins (1.693 ms) : 1666, 1720
.   : milestone, 1693,
iast (1.534 ms) : 1510, 1559
.   : milestone, 1534,
profiling (1.509 ms) : 1485, 1533
.   : milestone, 1509,
tracing (1.486 ms) : 1462, 1511
.   : milestone, 1486,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.352 ms [1.333 ms, 1.372 ms] -
appsec 1.738 ms [1.715 ms, 1.761 ms] 385.84 µs (28.5%)
appsec_no_iast 1.737 ms [1.713 ms, 1.76 ms] 384.218 µs (28.4%)
code_origins 1.662 ms [1.636 ms, 1.689 ms] 309.74 µs (22.9%)
iast 1.53 ms [1.507 ms, 1.554 ms] 178.093 µs (13.2%)
profiling 1.537 ms [1.514 ms, 1.56 ms] 184.817 µs (13.7%)
tracing 1.499 ms [1.477 ms, 1.522 ms] 147.092 µs (10.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.361 ms [1.341 ms, 1.38 ms] -
appsec 1.734 ms [1.71 ms, 1.758 ms] 373.531 µs (27.5%)
appsec_no_iast 1.743 ms [1.72 ms, 1.766 ms] 382.923 µs (28.1%)
code_origins 1.693 ms [1.666 ms, 1.72 ms] 332.607 µs (24.4%)
iast 1.534 ms [1.51 ms, 1.559 ms] 173.981 µs (12.8%)
profiling 1.509 ms [1.485 ms, 1.533 ms] 148.783 µs (10.9%)
tracing 1.486 ms [1.462 ms, 1.511 ms] 125.762 µs (9.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ygree/servicetalk-concurrent-instrumentation-0.42.56
git_commit_date 1746789389 1747991616
git_commit_sha ad6d5fe 5c2f307
release_version 1.50.0-SNAPSHOT~ad6d5fef42 1.50.0-SNAPSHOT~5c2f307d8a
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1747993649 1747993649
ci_job_id 951739738 951739738
ci_pipeline_id 65956615 65956615
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-xffk-g1f-project-304-concurrent-1-omtlrlj8 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-xffk-g1f-project-304-concurrent-1-omtlrlj8 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~5c2f307d8a, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.655 s) : 15655000, 15655000
.   : milestone, 15655000,
appsec (15.225 s) : 15225000, 15225000
.   : milestone, 15225000,
iast (18.494 s) : 18494000, 18494000
.   : milestone, 18494000,
iast_GLOBAL (18.183 s) : 18183000, 18183000
.   : milestone, 18183000,
profiling (14.99 s) : 14990000, 14990000
.   : milestone, 14990000,
tracing (14.982 s) : 14982000, 14982000
.   : milestone, 14982000,
section candidate
no_agent (14.958 s) : 14958000, 14958000
.   : milestone, 14958000,
appsec (15.117 s) : 15117000, 15117000
.   : milestone, 15117000,
iast (18.333 s) : 18333000, 18333000
.   : milestone, 18333000,
iast_GLOBAL (18.054 s) : 18054000, 18054000
.   : milestone, 18054000,
profiling (15.554 s) : 15554000, 15554000
.   : milestone, 15554000,
tracing (15.084 s) : 15084000, 15084000
.   : milestone, 15084000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.655 s [15.655 s, 15.655 s] -
appsec 15.225 s [15.225 s, 15.225 s] -430.0 ms (-2.7%)
iast 18.494 s [18.494 s, 18.494 s] 2.839 s (18.1%)
iast_GLOBAL 18.183 s [18.183 s, 18.183 s] 2.528 s (16.1%)
profiling 14.99 s [14.99 s, 14.99 s] -665.0 ms (-4.2%)
tracing 14.982 s [14.982 s, 14.982 s] -673.0 ms (-4.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.958 s [14.958 s, 14.958 s] -
appsec 15.117 s [15.117 s, 15.117 s] 159.0 ms (1.1%)
iast 18.333 s [18.333 s, 18.333 s] 3.375 s (22.6%)
iast_GLOBAL 18.054 s [18.054 s, 18.054 s] 3.096 s (20.7%)
profiling 15.554 s [15.554 s, 15.554 s] 596.0 ms (4.0%)
tracing 15.084 s [15.084 s, 15.084 s] 126.0 ms (0.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~5c2f307d8a, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (2.39 ms) : 2342, 2438
.   : milestone, 2390,
iast (2.175 ms) : 2114, 2236
.   : milestone, 2175,
iast_GLOBAL (2.206 ms) : 2144, 2267
.   : milestone, 2206,
profiling (2.03 ms) : 1981, 2079
.   : milestone, 2030,
tracing (2.01 ms) : 1963, 2058
.   : milestone, 2010,
section candidate
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.394 ms) : 2345, 2442
.   : milestone, 2394,
iast (2.171 ms) : 2111, 2232
.   : milestone, 2171,
iast_GLOBAL (2.217 ms) : 2156, 2278
.   : milestone, 2217,
profiling (2.036 ms) : 1986, 2086
.   : milestone, 2036,
tracing (2.0 ms) : 1953, 2047
.   : milestone, 2000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.465 ms, 1.488 ms] -
appsec 2.39 ms [2.342 ms, 2.438 ms] 913.603 µs (61.9%)
iast 2.175 ms [2.114 ms, 2.236 ms] 698.561 µs (47.3%)
iast_GLOBAL 2.206 ms [2.144 ms, 2.267 ms] 729.074 µs (49.4%)
profiling 2.03 ms [1.981 ms, 2.079 ms] 553.81 µs (37.5%)
tracing 2.01 ms [1.963 ms, 2.058 ms] 533.661 µs (36.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 2.394 ms [2.345 ms, 2.442 ms] 920.117 µs (62.4%)
iast 2.171 ms [2.111 ms, 2.232 ms] 697.771 µs (47.3%)
iast_GLOBAL 2.217 ms [2.156 ms, 2.278 ms] 742.981 µs (50.4%)
profiling 2.036 ms [1.986 ms, 2.086 ms] 562.058 µs (38.1%)
tracing 2.0 ms [1.953 ms, 2.047 ms] 526.331 µs (35.7%)

@ygree ygree self-assigned this May 14, 2025
@ygree ygree added inst: others All other instrumentations tag: breaking change Breaking changes and removed inst: servicetalk labels May 14, 2025
@ygree ygree force-pushed the ygree/servicetalk-concurrent-instrumentation-0.42.56 branch from e1e7f85 to 23b0ecf Compare May 14, 2025 21:14
@ygree ygree force-pushed the ygree/servicetalk-concurrent-instrumentation-0.42.56 branch from 8d635f2 to 2ea0cec Compare May 15, 2025 00:00
@ygree ygree added this to the 1.50.0 milestone May 15, 2025
@ygree ygree added type: enhancement and removed tag: breaking change Breaking changes labels May 15, 2025
@ygree ygree changed the title ServiceTalk concurrent instrumentation 0.42.56+ ServiceTalk Captured Context API Instrumentation for v0.42.56+ May 15, 2025
@ygree ygree marked this pull request as ready for review May 15, 2025 00:09
@ygree ygree requested review from a team as code owners May 15, 2025 00:09
@ygree ygree requested a review from smola May 15, 2025 00:09
@ygree ygree force-pushed the ygree/servicetalk-concurrent-instrumentation-0.42.56 branch from e7a0fca to d8ad4d6 Compare May 15, 2025 18:28
@ygree ygree enabled auto-merge (squash) May 15, 2025 18:58
@smola smola requested review from a team and dougqh and removed request for a team and smola May 20, 2025 13:15
@ygree ygree requested a review from amarziali May 21, 2025 12:52
amarziali
amarziali approved these changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@ygree ygree force-pushed the ygree/servicetalk-concurrent-instrumentation-0.42.56 branch from 1b4a8c1 to 5c2f307 Compare May 23, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees

@ygree ygree

Labels
inst: others All other instrumentations type: enhancement
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ygree @amarziali