-
Notifications
You must be signed in to change notification settings - Fork 303
Add support for JUnit 5.13-RC1 #8865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
daniel-mohedano
merged 1 commit into
master
from
daniel.mohedano/junit5-execution-request-fix
May 22, 2025
Merged
Add support for JUnit 5.13-RC1 #8865
daniel-mohedano
merged 1 commit into
master
from
daniel.mohedano/junit5-execution-request-fix
May 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 54 metrics, 16 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~a08d1007c4, baseline=1.50.0-SNAPSHOT~8e7b515c37
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1020538
Total [baseline] (8.642 s) : 0, 8642340
Agent [candidate] (1.026 s) : 0, 1025779
Total [candidate] (8.646 s) : 0, 8646413
section iast
Agent [baseline] (1.151 s) : 0, 1150747
Total [baseline] (9.226 s) : 0, 9225719
Agent [candidate] (1.153 s) : 0, 1152672
Total [candidate] (9.211 s) : 0, 9210645
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.156 s) : 0, 1156213
Total [baseline] (9.187 s) : 0, 9186862
Agent [candidate] (1.15 s) : 0, 1149683
Total [candidate] (9.185 s) : 0, 9184776
section iast_TELEMETRY_OFF
Agent [baseline] (1.147 s) : 0, 1147354
Total [baseline] (9.224 s) : 0, 9223544
Agent [candidate] (1.144 s) : 0, 1143852
Total [candidate] (9.176 s) : 0, 9176192
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~a08d1007c4, baseline=1.50.0-SNAPSHOT~8e7b515c37
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.113 ms) : 0, 682113
BytebuddyAgent [candidate] (686.927 ms) : 0, 686927
GlobalTracer [baseline] (239.941 ms) : 0, 239941
GlobalTracer [candidate] (241.525 ms) : 0, 241525
AppSec [baseline] (54.257 ms) : 0, 54257
AppSec [candidate] (55.592 ms) : 0, 55592
Debugger [baseline] (9.604 ms) : 0, 9604
Debugger [candidate] (8.283 ms) : 0, 8283
Remote Config [baseline] (694.046 µs) : 0, 694
Remote Config [candidate] (703.269 µs) : 0, 703
Telemetry [baseline] (10.436 ms) : 0, 10436
Telemetry [candidate] (9.078 ms) : 0, 9078
section iast
BytebuddyAgent [baseline] (803.152 ms) : 0, 803152
BytebuddyAgent [candidate] (806.101 ms) : 0, 806101
GlobalTracer [baseline] (230.716 ms) : 0, 230716
GlobalTracer [candidate] (230.849 ms) : 0, 230849
IAST [baseline] (26.068 ms) : 0, 26068
IAST [candidate] (28.927 ms) : 0, 28927
AppSec [baseline] (50.624 ms) : 0, 50624
AppSec [candidate] (48.937 ms) : 0, 48937
Debugger [baseline] (5.907 ms) : 0, 5907
Debugger [candidate] (5.818 ms) : 0, 5818
Remote Config [baseline] (593.11 µs) : 0, 593
Remote Config [candidate] (578.545 µs) : 0, 579
Telemetry [baseline] (7.852 ms) : 0, 7852
Telemetry [candidate] (7.809 ms) : 0, 7809
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.355 ms) : 0, 807355
BytebuddyAgent [candidate] (801.657 ms) : 0, 801657
GlobalTracer [baseline] (232.14 ms) : 0, 232140
GlobalTracer [candidate] (231.017 ms) : 0, 231017
IAST [baseline] (29.885 ms) : 0, 29885
IAST [candidate] (27.764 ms) : 0, 27764
AppSec [baseline] (48.716 ms) : 0, 48716
AppSec [candidate] (51.275 ms) : 0, 51275
Debugger [baseline] (5.887 ms) : 0, 5887
Debugger [candidate] (5.887 ms) : 0, 5887
Remote Config [baseline] (602.205 µs) : 0, 602
Remote Config [candidate] (578.533 µs) : 0, 579
Telemetry [baseline] (7.965 ms) : 0, 7965
Telemetry [candidate] (7.909 ms) : 0, 7909
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.113 ms) : 0, 798113
BytebuddyAgent [candidate] (797.804 ms) : 0, 797804
GlobalTracer [baseline] (232.297 ms) : 0, 232297
GlobalTracer [candidate] (230.455 ms) : 0, 230455
IAST [baseline] (23.371 ms) : 0, 23371
IAST [candidate] (22.23 ms) : 0, 22230
AppSec [baseline] (55.507 ms) : 0, 55507
AppSec [candidate] (55.569 ms) : 0, 55569
Debugger [baseline] (6.008 ms) : 0, 6008
Debugger [candidate] (5.902 ms) : 0, 5902
Remote Config [baseline] (607.025 µs) : 0, 607
Remote Config [candidate] (596.621 µs) : 0, 597
Telemetry [baseline] (7.857 ms) : 0, 7857
Telemetry [candidate] (7.75 ms) : 0, 7750
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~a08d1007c4, baseline=1.50.0-SNAPSHOT~8e7b515c37
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1020848
Total [baseline] (10.429 s) : 0, 10428549
Agent [candidate] (1.031 s) : 0, 1031400
Total [candidate] (10.484 s) : 0, 10484230
section appsec
Agent [baseline] (1.168 s) : 0, 1167919
Total [baseline] (10.652 s) : 0, 10652238
Agent [candidate] (1.165 s) : 0, 1164762
Total [candidate] (10.657 s) : 0, 10657252
section iast
Agent [baseline] (1.153 s) : 0, 1152587
Total [baseline] (10.851 s) : 0, 10851071
Agent [candidate] (1.156 s) : 0, 1155568
Total [candidate] (10.828 s) : 0, 10828150
section profiling
Agent [baseline] (1.269 s) : 0, 1269323
Total [baseline] (10.821 s) : 0, 10821187
Agent [candidate] (1.279 s) : 0, 1279099
Total [candidate] (10.818 s) : 0, 10818208
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~a08d1007c4, baseline=1.50.0-SNAPSHOT~8e7b515c37
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.8 ms) : 0, 682800
BytebuddyAgent [candidate] (691.571 ms) : 0, 691571
GlobalTracer [baseline] (240.313 ms) : 0, 240313
GlobalTracer [candidate] (241.542 ms) : 0, 241542
AppSec [baseline] (55.205 ms) : 0, 55205
AppSec [candidate] (55.534 ms) : 0, 55534
Debugger [baseline] (7.615 ms) : 0, 7615
Debugger [candidate] (7.65 ms) : 0, 7650
Remote Config [baseline] (696.198 µs) : 0, 696
Remote Config [candidate] (720.388 µs) : 0, 720
Telemetry [baseline] (10.53 ms) : 0, 10530
Telemetry [candidate] (10.731 ms) : 0, 10731
section appsec
BytebuddyAgent [baseline] (704.606 ms) : 0, 704606
BytebuddyAgent [candidate] (702.281 ms) : 0, 702281
GlobalTracer [baseline] (238.246 ms) : 0, 238246
GlobalTracer [candidate] (237.718 ms) : 0, 237718
IAST [baseline] (21.946 ms) : 0, 21946
IAST [candidate] (21.937 ms) : 0, 21937
AppSec [baseline] (175.535 ms) : 0, 175535
AppSec [candidate] (176.285 ms) : 0, 176285
Debugger [baseline] (6.363 ms) : 0, 6363
Debugger [candidate] (5.936 ms) : 0, 5936
Remote Config [baseline] (621.473 µs) : 0, 621
Remote Config [candidate] (623.646 µs) : 0, 624
Telemetry [baseline] (7.786 ms) : 0, 7786
Telemetry [candidate] (7.38 ms) : 0, 7380
section iast
BytebuddyAgent [baseline] (804.109 ms) : 0, 804109
BytebuddyAgent [candidate] (807.656 ms) : 0, 807656
GlobalTracer [baseline] (231.23 ms) : 0, 231230
GlobalTracer [candidate] (231.143 ms) : 0, 231143
IAST [baseline] (28.578 ms) : 0, 28578
IAST [candidate] (27.541 ms) : 0, 27541
AppSec [baseline] (50.592 ms) : 0, 50592
AppSec [candidate] (51.224 ms) : 0, 51224
Debugger [baseline] (5.951 ms) : 0, 5951
Debugger [candidate] (5.921 ms) : 0, 5921
Remote Config [baseline] (583.641 µs) : 0, 584
Remote Config [candidate] (595.896 µs) : 0, 596
Telemetry [baseline] (7.905 ms) : 0, 7905
Telemetry [candidate] (7.862 ms) : 0, 7862
section profiling
BytebuddyAgent [baseline] (676.359 ms) : 0, 676359
BytebuddyAgent [candidate] (672.392 ms) : 0, 672392
GlobalTracer [baseline] (361.262 ms) : 0, 361262
GlobalTracer [candidate] (374.49 ms) : 0, 374490
AppSec [baseline] (62.277 ms) : 0, 62277
AppSec [candidate] (62.434 ms) : 0, 62434
Debugger [baseline] (6.337 ms) : 0, 6337
Debugger [candidate] (6.369 ms) : 0, 6369
Remote Config [baseline] (662.692 µs) : 0, 663
Remote Config [candidate] (683.124 µs) : 0, 683
Telemetry [baseline] (8.268 ms) : 0, 8268
Telemetry [candidate] (8.297 ms) : 0, 8297
ProfilingAgent [baseline] (103.345 ms) : 0, 103345
ProfilingAgent [candidate] (103.687 ms) : 0, 103687
Profiling [baseline] (103.37 ms) : 0, 103370
Profiling [candidate] (103.711 ms) : 0, 103711
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~a08d1007c4, baseline=1.50.0-SNAPSHOT~8e7b515c37
dateFormat X
axisFormat %s
section baseline
no_agent (385.543 µs) : 364, 408
. : milestone, 386,
iast (518.06 µs) : 496, 540
. : milestone, 518,
iast_FULL (735.202 µs) : 713, 757
. : milestone, 735,
iast_GLOBAL (580.782 µs) : 558, 604
. : milestone, 581,
iast_HARDCODED_SECRET_DISABLED (515.04 µs) : 492, 538
. : milestone, 515,
iast_INACTIVE (473.895 µs) : 449, 499
. : milestone, 474,
iast_TELEMETRY_OFF (507.04 µs) : 484, 530
. : milestone, 507,
tracing (459.08 µs) : 437, 481
. : milestone, 459,
section candidate
no_agent (376.322 µs) : 356, 396
. : milestone, 376,
iast (521.832 µs) : 500, 543
. : milestone, 522,
iast_FULL (732.4 µs) : 710, 754
. : milestone, 732,
iast_GLOBAL (569.757 µs) : 548, 592
. : milestone, 570,
iast_HARDCODED_SECRET_DISABLED (517.52 µs) : 495, 540
. : milestone, 518,
iast_INACTIVE (466.902 µs) : 444, 489
. : milestone, 467,
iast_TELEMETRY_OFF (512.128 µs) : 489, 535
. : milestone, 512,
tracing (457.373 µs) : 435, 479
. : milestone, 457,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~a08d1007c4, baseline=1.50.0-SNAPSHOT~8e7b515c37
dateFormat X
axisFormat %s
section baseline
no_agent (1.354 ms) : 1334, 1373
. : milestone, 1354,
appsec (1.731 ms) : 1708, 1755
. : milestone, 1731,
appsec_no_iast (1.719 ms) : 1695, 1743
. : milestone, 1719,
code_origins (1.657 ms) : 1630, 1684
. : milestone, 1657,
iast (1.51 ms) : 1485, 1534
. : milestone, 1510,
profiling (1.51 ms) : 1486, 1535
. : milestone, 1510,
tracing (1.497 ms) : 1474, 1520
. : milestone, 1497,
section candidate
no_agent (1.334 ms) : 1316, 1353
. : milestone, 1334,
appsec (1.737 ms) : 1713, 1760
. : milestone, 1737,
appsec_no_iast (1.734 ms) : 1711, 1758
. : milestone, 1734,
code_origins (1.669 ms) : 1641, 1696
. : milestone, 1669,
iast (1.51 ms) : 1484, 1535
. : milestone, 1510,
profiling (1.505 ms) : 1481, 1529
. : milestone, 1505,
tracing (1.494 ms) : 1470, 1519
. : milestone, 1494,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~a08d1007c4, baseline=1.50.0-SNAPSHOT~8e7b515c37
dateFormat X
axisFormat %s
section baseline
no_agent (15.561 s) : 15561000, 15561000
. : milestone, 15561000,
appsec (14.92 s) : 14920000, 14920000
. : milestone, 14920000,
iast (18.59 s) : 18590000, 18590000
. : milestone, 18590000,
iast_GLOBAL (18.11 s) : 18110000, 18110000
. : milestone, 18110000,
profiling (14.846 s) : 14846000, 14846000
. : milestone, 14846000,
tracing (15.069 s) : 15069000, 15069000
. : milestone, 15069000,
section candidate
no_agent (15.235 s) : 15235000, 15235000
. : milestone, 15235000,
appsec (14.993 s) : 14993000, 14993000
. : milestone, 14993000,
iast (18.808 s) : 18808000, 18808000
. : milestone, 18808000,
iast_GLOBAL (18.133 s) : 18133000, 18133000
. : milestone, 18133000,
profiling (15.668 s) : 15668000, 15668000
. : milestone, 15668000,
tracing (14.869 s) : 14869000, 14869000
. : milestone, 14869000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~a08d1007c4, baseline=1.50.0-SNAPSHOT~8e7b515c37
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.387 ms) : 2339, 2435
. : milestone, 2387,
iast (2.176 ms) : 2115, 2237
. : milestone, 2176,
iast_GLOBAL (2.214 ms) : 2152, 2275
. : milestone, 2214,
profiling (2.039 ms) : 1990, 2089
. : milestone, 2039,
tracing (1.999 ms) : 1952, 2046
. : milestone, 1999,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.398 ms) : 2349, 2447
. : milestone, 2398,
iast (2.174 ms) : 2113, 2235
. : milestone, 2174,
iast_GLOBAL (2.215 ms) : 2154, 2276
. : milestone, 2215,
profiling (2.032 ms) : 1983, 2082
. : milestone, 2032,
tracing (2.002 ms) : 1955, 2049
. : milestone, 2002,
|
nikita-tkachenko-datadog
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
org.junit.platform.engine.ExecutionRequest
, adding two new fields to the class, at least one of them required for the execution of tests. The instrumentation now chooses the available method to create objects of the class through reflection.Motivation
Unblocks #8842
Additional Notes
Tested locally by upgrading the gradle dependencies on
junit-5.3
andjunit-5.8
instrumentations and running bothtest
andlatestDepTest
.Passing results for
junit-5.3
:Passing results for
junit-5.8
:Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]