Fix printing format of span identifiers #8897

vandonr · 2025-05-28T15:23:45Z

What Does This Do

span IDs were printed as long in debug logs, but longs are signed by default, so values between 2^63 and 2^64 were printed with a - sign in front, and a value that isn't usable in the UI.
There is no ulong in Java, but using toUnsignedString prints the correct value.

Motivation

have spanIDs that we can compare with the IDs we see in the UI

Additional Notes

discovered this issue in https://datadoghq.atlassian.net/browse/OTELS-617

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-05-28T15:59:32Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/fix2
git_commit_date	1746789389	1748606649
git_commit_sha	`ad6d5fe`	`6336914`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~633691499a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1748609078	1748609078
ci_job_id	960809806	960809806
ci_pipeline_id	66520629	66520629
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-6qnhxxvc-project-304-concurrent-0-i8wbjr5j 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-6qnhxxvc-project-304-concurrent-0-i8wbjr5j 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 3 performance improvements and 1 performance regressions! Performance is the same for 54 metrics, 13 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:profiling:ProfilingAgent	better [-8.039ms; -3.540ms] or [-7.325%; -3.225%]	103.963ms	109.752ms
scenario:startup:petclinic:profiling:GlobalTracer	better [-20.828ms; -17.155ms] or [-5.492%; -4.523%]	360.279ms	379.271ms
scenario:startup:petclinic:profiling:AppSec	worse [+5.092ms; +8.422ms] or [+9.291%; +15.367%]	61.565ms	54.808ms
scenario:startup:petclinic:profiling:Profiling	better [-8.041ms; -3.541ms] or [-7.325%; -3.226%]	103.986ms	109.777ms

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~633691499a, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1030235
Total [baseline] (10.484 s) : 0, 10483529
Agent [candidate] (1.023 s) : 0, 1022781
Total [candidate] (10.545 s) : 0, 10544747
section appsec
Agent [baseline] (1.161 s) : 0, 1161470
Total [baseline] (10.743 s) : 0, 10743225
Agent [candidate] (1.169 s) : 0, 1168620
Total [candidate] (10.703 s) : 0, 10702922
section iast
Agent [baseline] (1.171 s) : 0, 1171099
Total [baseline] (11.013 s) : 0, 11012992
Agent [candidate] (1.16 s) : 0, 1159934
Total [candidate] (10.87 s) : 0, 10870404
section profiling
Agent [baseline] (1.283 s) : 0, 1283297
Total [baseline] (10.902 s) : 0, 10901576
Agent [candidate] (1.267 s) : 0, 1266715
Total [candidate] (10.85 s) : 0, 10850133

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.03 s	-
Agent	appsec	1.161 s	131.235 ms (12.7%)
Agent	iast	1.171 s	140.864 ms (13.7%)
Agent	profiling	1.283 s	253.062 ms (24.6%)
Total	tracing	10.484 s	-
Total	appsec	10.743 s	259.695 ms (2.5%)
Total	iast	11.013 s	529.463 ms (5.1%)
Total	profiling	10.902 s	418.046 ms (4.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.023 s	-
Agent	appsec	1.169 s	145.839 ms (14.3%)
Agent	iast	1.16 s	137.154 ms (13.4%)
Agent	profiling	1.267 s	243.934 ms (23.9%)
Total	tracing	10.545 s	-
Total	appsec	10.703 s	158.175 ms (1.5%)
Total	iast	10.87 s	325.657 ms (3.1%)
Total	profiling	10.85 s	305.386 ms (2.9%)

gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~633691499a, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.783 ms) : 0, 690783
BytebuddyAgent [candidate] (683.628 ms) : 0, 683628
GlobalTracer [baseline] (242.058 ms) : 0, 242058
GlobalTracer [candidate] (241.494 ms) : 0, 241494
AppSec [baseline] (54.692 ms) : 0, 54692
AppSec [candidate] (55.948 ms) : 0, 55948
Debugger [baseline] (9.112 ms) : 0, 9112
Debugger [candidate] (9.207 ms) : 0, 9207
Remote Config [baseline] (695.9 µs) : 0, 696
Remote Config [candidate] (735.437 µs) : 0, 735
Telemetry [baseline] (9.101 ms) : 0, 9101
Telemetry [candidate] (8.211 ms) : 0, 8211
section appsec
BytebuddyAgent [baseline] (700.486 ms) : 0, 700486
BytebuddyAgent [candidate] (704.738 ms) : 0, 704738
GlobalTracer [baseline] (236.82 ms) : 0, 236820
GlobalTracer [candidate] (238.743 ms) : 0, 238743
IAST [baseline] (21.669 ms) : 0, 21669
IAST [candidate] (21.794 ms) : 0, 21794
AppSec [baseline] (175.828 ms) : 0, 175828
AppSec [candidate] (176.525 ms) : 0, 176525
Debugger [baseline] (5.928 ms) : 0, 5928
Debugger [candidate] (6.005 ms) : 0, 6005
Remote Config [baseline] (625.033 µs) : 0, 625
Remote Config [candidate] (648.882 µs) : 0, 649
Telemetry [baseline] (7.402 ms) : 0, 7402
Telemetry [candidate] (7.399 ms) : 0, 7399
section iast
BytebuddyAgent [baseline] (819.883 ms) : 0, 819883
BytebuddyAgent [candidate] (810.645 ms) : 0, 810645
GlobalTracer [baseline] (233.279 ms) : 0, 233279
GlobalTracer [candidate] (232.94 ms) : 0, 232940
IAST [baseline] (28.59 ms) : 0, 28590
IAST [candidate] (30.878 ms) : 0, 30878
AppSec [baseline] (50.898 ms) : 0, 50898
AppSec [candidate] (47.528 ms) : 0, 47528
Debugger [baseline] (5.997 ms) : 0, 5997
Debugger [candidate] (5.823 ms) : 0, 5823
Remote Config [baseline] (629.062 µs) : 0, 629
Remote Config [candidate] (635.85 µs) : 0, 636
Telemetry [baseline] (8.041 ms) : 0, 8041
Telemetry [candidate] (7.851 ms) : 0, 7851
section profiling
BytebuddyAgent [baseline] (673.907 ms) : 0, 673907
BytebuddyAgent [candidate] (674.896 ms) : 0, 674896
GlobalTracer [baseline] (379.271 ms) : 0, 379271
GlobalTracer [candidate] (360.279 ms) : 0, 360279
AppSec [baseline] (54.808 ms) : 0, 54808
AppSec [candidate] (61.565 ms) : 0, 61565
Debugger [baseline] (6.116 ms) : 0, 6116
Debugger [candidate] (6.274 ms) : 0, 6274
Remote Config [baseline] (665.595 µs) : 0, 666
Remote Config [candidate] (647.99 µs) : 0, 648
Telemetry [baseline] (8.136 ms) : 0, 8136
Telemetry [candidate] (8.292 ms) : 0, 8292
ProfilingAgent [baseline] (109.752 ms) : 0, 109752
ProfilingAgent [candidate] (103.963 ms) : 0, 103963
Profiling [baseline] (109.777 ms) : 0, 109777
Profiling [candidate] (103.986 ms) : 0, 103986

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~633691499a, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1026063
Total [baseline] (8.673 s) : 0, 8673186
Agent [candidate] (1.024 s) : 0, 1024001
Total [candidate] (8.653 s) : 0, 8653499
section iast
Agent [baseline] (1.159 s) : 0, 1158636
Total [baseline] (9.264 s) : 0, 9264487
Agent [candidate] (1.151 s) : 0, 1150926
Total [candidate] (9.217 s) : 0, 9216862
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.157 s) : 0, 1156603
Total [baseline] (9.243 s) : 0, 9243419
Agent [candidate] (1.159 s) : 0, 1158542
Total [candidate] (9.193 s) : 0, 9193099
section iast_TELEMETRY_OFF
Agent [baseline] (1.146 s) : 0, 1146245
Total [baseline] (9.282 s) : 0, 9281784
Agent [candidate] (1.151 s) : 0, 1150607
Total [candidate] (9.242 s) : 0, 9241981

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.026 s	-
Agent	iast	1.159 s	132.573 ms (12.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.157 s	130.54 ms (12.7%)
Agent	iast_TELEMETRY_OFF	1.146 s	120.182 ms (11.7%)
Total	tracing	8.673 s	-
Total	iast	9.264 s	591.302 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.243 s	570.234 ms (6.6%)
Total	iast_TELEMETRY_OFF	9.282 s	608.598 ms (7.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.024 s	-
Agent	iast	1.151 s	126.925 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.159 s	134.541 ms (13.1%)
Agent	iast_TELEMETRY_OFF	1.151 s	126.606 ms (12.4%)
Total	tracing	8.653 s	-
Total	iast	9.217 s	563.362 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.193 s	539.6 ms (6.2%)
Total	iast_TELEMETRY_OFF	9.242 s	588.482 ms (6.8%)

gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~633691499a, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.967 ms) : 0, 687967
BytebuddyAgent [candidate] (683.931 ms) : 0, 683931
GlobalTracer [baseline] (240.893 ms) : 0, 240893
GlobalTracer [candidate] (241.059 ms) : 0, 241059
AppSec [baseline] (55.299 ms) : 0, 55299
AppSec [candidate] (56.016 ms) : 0, 56016
Debugger [baseline] (8.345 ms) : 0, 8345
Debugger [candidate] (9.806 ms) : 0, 9806
Remote Config [baseline] (696.767 µs) : 0, 697
Remote Config [candidate] (728.851 µs) : 0, 729
Telemetry [baseline] (9.065 ms) : 0, 9065
Telemetry [candidate] (8.85 ms) : 0, 8850
section iast
BytebuddyAgent [baseline] (809.013 ms) : 0, 809013
BytebuddyAgent [candidate] (803.409 ms) : 0, 803409
GlobalTracer [baseline] (232.072 ms) : 0, 232072
GlobalTracer [candidate] (231.003 ms) : 0, 231003
IAST [baseline] (28.515 ms) : 0, 28515
IAST [candidate] (28.885 ms) : 0, 28885
AppSec [baseline] (50.703 ms) : 0, 50703
AppSec [candidate] (49.667 ms) : 0, 49667
Debugger [baseline] (5.991 ms) : 0, 5991
Debugger [candidate] (5.836 ms) : 0, 5836
Remote Config [baseline] (613.922 µs) : 0, 614
Remote Config [candidate] (587.8 µs) : 0, 588
Telemetry [baseline] (8.002 ms) : 0, 8002
Telemetry [candidate] (7.973 ms) : 0, 7973
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (806.832 ms) : 0, 806832
BytebuddyAgent [candidate] (809.376 ms) : 0, 809376
GlobalTracer [baseline] (232.477 ms) : 0, 232477
GlobalTracer [candidate] (232.368 ms) : 0, 232368
IAST [baseline] (30.053 ms) : 0, 30053
IAST [candidate] (28.339 ms) : 0, 28339
AppSec [baseline] (49.076 ms) : 0, 49076
AppSec [candidate] (50.447 ms) : 0, 50447
Debugger [baseline] (5.923 ms) : 0, 5923
Debugger [candidate] (5.854 ms) : 0, 5854
Remote Config [baseline] (603.696 µs) : 0, 604
Remote Config [candidate] (579.809 µs) : 0, 580
Telemetry [baseline] (7.977 ms) : 0, 7977
Telemetry [candidate] (7.865 ms) : 0, 7865
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.156 ms) : 0, 799156
BytebuddyAgent [candidate] (801.693 ms) : 0, 801693
GlobalTracer [baseline] (230.687 ms) : 0, 230687
GlobalTracer [candidate] (231.584 ms) : 0, 231584
IAST [baseline] (22.492 ms) : 0, 22492
IAST [candidate] (23.35 ms) : 0, 23350
AppSec [baseline] (56.068 ms) : 0, 56068
AppSec [candidate] (55.821 ms) : 0, 55821
Debugger [baseline] (5.956 ms) : 0, 5956
Debugger [candidate] (5.997 ms) : 0, 5997
Remote Config [baseline] (601.231 µs) : 0, 601
Remote Config [candidate] (595.967 µs) : 0, 596
Telemetry [baseline] (7.779 ms) : 0, 7779
Telemetry [candidate] (7.887 ms) : 0, 7887

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-05-30T12:16:56	2025-05-30T12:24:40
git_branch	master	vandonr/fix2
git_commit_date	1746789389	1748606649
git_commit_sha	`ad6d5fe`	`6336914`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~633691499a
start_time	2025-05-30T12:16:42	2025-05-30T12:24:26

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1748608280	1748608280
ci_job_id	960809807	960809807
ci_pipeline_id	66520629	66520629
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-6qnhxxvc-project-304-concurrent-1-vivp68z4 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-6qnhxxvc-project-304-concurrent-1-vivp68z4 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~633691499a, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.353 ms) : 1334, 1372
.   : milestone, 1353,
appsec (1.725 ms) : 1701, 1749
.   : milestone, 1725,
appsec_no_iast (1.726 ms) : 1703, 1749
.   : milestone, 1726,
code_origins (1.66 ms) : 1634, 1687
.   : milestone, 1660,
iast (1.526 ms) : 1502, 1550
.   : milestone, 1526,
profiling (1.529 ms) : 1505, 1553
.   : milestone, 1529,
tracing (1.495 ms) : 1470, 1519
.   : milestone, 1495,
section candidate
no_agent (1.357 ms) : 1337, 1378
.   : milestone, 1357,
appsec (1.715 ms) : 1691, 1739
.   : milestone, 1715,
appsec_no_iast (1.722 ms) : 1699, 1744
.   : milestone, 1722,
code_origins (1.676 ms) : 1649, 1703
.   : milestone, 1676,
iast (1.515 ms) : 1491, 1540
.   : milestone, 1515,
profiling (1.582 ms) : 1556, 1608
.   : milestone, 1582,
tracing (1.487 ms) : 1462, 1512
.   : milestone, 1487,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.353 ms [1.334 ms, 1.372 ms]	-
appsec	1.725 ms [1.701 ms, 1.749 ms]	371.72 µs (27.5%)
appsec_no_iast	1.726 ms [1.703 ms, 1.749 ms]	373.105 µs (27.6%)
code_origins	1.66 ms [1.634 ms, 1.687 ms]	307.252 µs (22.7%)
iast	1.526 ms [1.502 ms, 1.55 ms]	172.659 µs (12.8%)
profiling	1.529 ms [1.505 ms, 1.553 ms]	175.988 µs (13.0%)
tracing	1.495 ms [1.47 ms, 1.519 ms]	141.654 µs (10.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.357 ms [1.337 ms, 1.378 ms]	-
appsec	1.715 ms [1.691 ms, 1.739 ms]	357.65 µs (26.3%)
appsec_no_iast	1.722 ms [1.699 ms, 1.744 ms]	364.221 µs (26.8%)
code_origins	1.676 ms [1.649 ms, 1.703 ms]	318.494 µs (23.5%)
iast	1.515 ms [1.491 ms, 1.54 ms]	157.993 µs (11.6%)
profiling	1.582 ms [1.556 ms, 1.608 ms]	224.434 µs (16.5%)
tracing	1.487 ms [1.462 ms, 1.512 ms]	129.836 µs (9.6%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~633691499a, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.371 µs) : 357, 396
.   : milestone, 376,
iast (513.601 µs) : 490, 537
.   : milestone, 514,
iast_FULL (728.334 µs) : 707, 750
.   : milestone, 728,
iast_GLOBAL (559.935 µs) : 538, 581
.   : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (515.013 µs) : 494, 536
.   : milestone, 515,
iast_INACTIVE (464.174 µs) : 442, 486
.   : milestone, 464,
iast_TELEMETRY_OFF (517.511 µs) : 494, 541
.   : milestone, 518,
tracing (459.35 µs) : 437, 482
.   : milestone, 459,
section candidate
no_agent (379.648 µs) : 359, 400
.   : milestone, 380,
iast (511.398 µs) : 489, 534
.   : milestone, 511,
iast_FULL (734.407 µs) : 712, 756
.   : milestone, 734,
iast_GLOBAL (561.276 µs) : 539, 584
.   : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (525.939 µs) : 504, 548
.   : milestone, 526,
iast_INACTIVE (463.191 µs) : 440, 486
.   : milestone, 463,
iast_TELEMETRY_OFF (520.155 µs) : 497, 544
.   : milestone, 520,
tracing (456.081 µs) : 434, 479
.   : milestone, 456,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	376.371 µs [356.608 µs, 396.135 µs]	-
iast	513.601 µs [490.395 µs, 536.807 µs]	137.229 µs (36.5%)
iast_FULL	728.334 µs [706.536 µs, 750.131 µs]	351.962 µs (93.5%)
iast_GLOBAL	559.935 µs [538.423 µs, 581.446 µs]	183.564 µs (48.8%)
iast_HARDCODED_SECRET_DISABLED	515.013 µs [493.556 µs, 536.47 µs]	138.642 µs (36.8%)
iast_INACTIVE	464.174 µs [441.918 µs, 486.43 µs]	87.803 µs (23.3%)
iast_TELEMETRY_OFF	517.511 µs [494.196 µs, 540.827 µs]	141.14 µs (37.5%)
tracing	459.35 µs [437.062 µs, 481.638 µs]	82.978 µs (22.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.648 µs [358.967 µs, 400.328 µs]	-
iast	511.398 µs [488.852 µs, 533.943 µs]	131.75 µs (34.7%)
iast_FULL	734.407 µs [712.355 µs, 756.459 µs]	354.759 µs (93.4%)
iast_GLOBAL	561.276 µs [539.024 µs, 583.527 µs]	181.628 µs (47.8%)
iast_HARDCODED_SECRET_DISABLED	525.939 µs [504.208 µs, 547.67 µs]	146.291 µs (38.5%)
iast_INACTIVE	463.191 µs [440.353 µs, 486.028 µs]	83.543 µs (22.0%)
iast_TELEMETRY_OFF	520.155 µs [496.628 µs, 543.681 µs]	140.507 µs (37.0%)
tracing	456.081 µs [433.649 µs, 478.512 µs]	76.433 µs (20.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/fix2
git_commit_date	1746789389	1748606649
git_commit_sha	`ad6d5fe`	`6336914`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~633691499a

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1748608747	1748608747
ci_job_id	960809808	960809808
ci_pipeline_id	66520629	66520629
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-6qnhxxvc-project-304-concurrent-2-bi65dxf5 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-6qnhxxvc-project-304-concurrent-2-bi65dxf5 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~633691499a, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.973 s) : 14973000, 14973000
.   : milestone, 14973000,
appsec (14.946 s) : 14946000, 14946000
.   : milestone, 14946000,
iast (18.447 s) : 18447000, 18447000
.   : milestone, 18447000,
iast_GLOBAL (18.375 s) : 18375000, 18375000
.   : milestone, 18375000,
profiling (15.623 s) : 15623000, 15623000
.   : milestone, 15623000,
tracing (14.87 s) : 14870000, 14870000
.   : milestone, 14870000,
section candidate
no_agent (15.397 s) : 15397000, 15397000
.   : milestone, 15397000,
appsec (15.151 s) : 15151000, 15151000
.   : milestone, 15151000,
iast (18.975 s) : 18975000, 18975000
.   : milestone, 18975000,
iast_GLOBAL (18.25 s) : 18250000, 18250000
.   : milestone, 18250000,
profiling (15.047 s) : 15047000, 15047000
.   : milestone, 15047000,
tracing (15.119 s) : 15119000, 15119000
.   : milestone, 15119000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.973 s [14.973 s, 14.973 s]	-
appsec	14.946 s [14.946 s, 14.946 s]	-27.0 ms (-0.2%)
iast	18.447 s [18.447 s, 18.447 s]	3.474 s (23.2%)
iast_GLOBAL	18.375 s [18.375 s, 18.375 s]	3.402 s (22.7%)
profiling	15.623 s [15.623 s, 15.623 s]	650.0 ms (4.3%)
tracing	14.87 s [14.87 s, 14.87 s]	-103.0 ms (-0.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.397 s [15.397 s, 15.397 s]	-
appsec	15.151 s [15.151 s, 15.151 s]	-246.0 ms (-1.6%)
iast	18.975 s [18.975 s, 18.975 s]	3.578 s (23.2%)
iast_GLOBAL	18.25 s [18.25 s, 18.25 s]	2.853 s (18.5%)
profiling	15.047 s [15.047 s, 15.047 s]	-350.0 ms (-2.3%)
tracing	15.119 s [15.119 s, 15.119 s]	-278.0 ms (-1.8%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~633691499a, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
.   : milestone, 1483,
appsec (2.411 ms) : 2363, 2460
.   : milestone, 2411,
iast (2.188 ms) : 2126, 2249
.   : milestone, 2188,
iast_GLOBAL (2.236 ms) : 2175, 2298
.   : milestone, 2236,
profiling (2.512 ms) : 2335, 2689
.   : milestone, 2512,
tracing (2.031 ms) : 1983, 2079
.   : milestone, 2031,
section candidate
no_agent (1.481 ms) : 1470, 1493
.   : milestone, 1481,
appsec (2.415 ms) : 2366, 2464
.   : milestone, 2415,
iast (2.209 ms) : 2147, 2271
.   : milestone, 2209,
iast_GLOBAL (2.24 ms) : 2178, 2302
.   : milestone, 2240,
profiling (2.478 ms) : 2308, 2648
.   : milestone, 2478,
tracing (2.013 ms) : 1965, 2060
.   : milestone, 2013,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.483 ms [1.471 ms, 1.494 ms]	-
appsec	2.411 ms [2.363 ms, 2.46 ms]	928.541 µs (62.6%)
iast	2.188 ms [2.126 ms, 2.249 ms]	705.108 µs (47.6%)
iast_GLOBAL	2.236 ms [2.175 ms, 2.298 ms]	753.643 µs (50.8%)
profiling	2.512 ms [2.335 ms, 2.689 ms]	1.029 ms (69.4%)
tracing	2.031 ms [1.983 ms, 2.079 ms]	548.162 µs (37.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.481 ms [1.47 ms, 1.493 ms]	-
appsec	2.415 ms [2.366 ms, 2.464 ms]	933.913 µs (63.1%)
iast	2.209 ms [2.147 ms, 2.271 ms]	728.06 µs (49.2%)
iast_GLOBAL	2.24 ms [2.178 ms, 2.302 ms]	758.476 µs (51.2%)
profiling	2.478 ms [2.308 ms, 2.648 ms]	997.098 µs (67.3%)
tracing	2.013 ms [1.965 ms, 2.06 ms]	531.829 µs (35.9%)

mcculls

Good catch ... this matches what the DDTraceId implementations do for trace ids

dd-trace-core/src/main/java/datadog/trace/core/DDSpanContext.java

PerfectSlayer

Please make sure to use the dedicated API 🙏
If we ever implement a cache, your change won't leverage it.

dd-trace-core/src/main/java/datadog/trace/core/DDSpanContext.java

Co-authored-by: Bruce Bujon <PerfectSlayer@users.noreply.github.com>

PerfectSlayer

Build fails due to missing import. Unblocking the PR 👍

dd-trace-core/src/test/groovy/datadog/trace/core/DDSpanContextTest.groovy

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.49.0` -> `1.50.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.50.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.0): 1.50.0 ### Deprecation Notice > \[!NOTE] > `DD_RUNTIME_ID_ENABLED` has been deprecated and will be removed in future releases. Please use `DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED` instead. ### Components #### Application Security Management (WAF) - 🐛 Add String length truncation limit to ObjectIntrospector and update truncation metrics ([#8825](DataDog/dd-trace-java#8825) - [@jandro996](https://github.com/jandro996)) - 🐛 Adapt standalone ASM to support API Security ([#8804](DataDog/dd-trace-java#8804) - [@jandro996](https://github.com/jandro996)) - ✨ Add appsec.waf.input\_truncated metric ([#8791](DataDog/dd-trace-java#8791) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request body collection ([#8748](DataDog/dd-trace-java#8748) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request/response headers collection ([#8724](DataDog/dd-trace-java#8724) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - ✨ Add artifacts to public s3 bucket ([#8947](DataDog/dd-trace-java#8947) - [@randomanderson](https://github.com/randomanderson)) #### Continuous Integration Visibility - ✨ Improve PR information building ([#8908](DataDog/dd-trace-java#8908) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Truncate span stack traces when Test Optimization is enabled ([#8903](DataDog/dd-trace-java#8903) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Ensure auto-detected service name is the same for every process in the same build ([#8902](DataDog/dd-trace-java#8902) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Use tag as fallback in api requests if no branch is available ([#8876](DataDog/dd-trace-java#8876) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add support for JUnit 5.13-RC1 ([#8865](DataDog/dd-trace-java#8865), [#8871](DataDog/dd-trace-java#8871) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement attempt to fix v3 and v4 and bump capability version ([#8824](DataDog/dd-trace-java#8824) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🧹 Align retry logic for all test framework instrumentations ([#8803](DataDog/dd-trace-java#8803) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Always build ci workspace without trailing separator ([#8788](DataDog/dd-trace-java#8788) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add commit discrepancies telemetry when building repository git information ([#8763](DataDog/dd-trace-java#8763) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 💡 Surface process tags in dsm payloads and use them for base hash calculation ([#8836](DataDog/dd-trace-java#8836) - [@amarziali](https://github.com/amarziali)) #### Dynamic Instrumentation - ✨ Optimized allocations for collection filter functions ([#8896](DataDog/dd-trace-java#8896) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix SymDB upload size check ([#8887](DataDog/dd-trace-java#8887) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for Set in filter function ([#8873](DataDog/dd-trace-java#8873) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for isDefined in log template ([#8859](DataDog/dd-trace-java#8859) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix Max captured frames for Exception Replay ([#8856](DataDog/dd-trace-java#8856) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Remove static inherited fields collection ([#8832](DataDog/dd-trace-java#8832) - [@jpbempel](https://github.com/jpbempel)) - 💡 Add process tags to dynamic instrumentation intake payload ([#8779](DataDog/dd-trace-java#8779) - [@amarziali](https://github.com/amarziali)) #### GraalVM native-image - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) - ✨ Add JMXFetch support for GraalVM Native ([#8569](DataDog/dd-trace-java#8569) - [@ygree](https://github.com/ygree)) #### JMX fetch - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) #### Library Injection - ✨ Deny oracle db jvm based tools ([#8909](DataDog/dd-trace-java#8909) - [@bric3](https://github.com/bric3)) #### OpenTracing - 🐛 Fix OT packaging for exception replay ([#8912](DataDog/dd-trace-java#8912) - [@jpbempel](https://github.com/jpbempel)) #### Profiling - ✨ Bump ddprof to 1.27.0 ([#8893](DataDog/dd-trace-java#8893) - [@jbachorik](https://github.com/jbachorik)) - Properly handle the adaptive sampling interval overflow by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#213 - Fix [#200](DataDog/dd-trace-java#200) Crash related to aligned\_alloc and free in context by [@yanglong1010](https://github.com/yanglong1010) in DataDog/java-profiler#208 - Explicitly initialize empty context page by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#210 - Re-connect crash recursion protection with VM stackwalker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#214 - ✨ Enable ZSTD compression for profiling ([#8862](DataDog/dd-trace-java#8862) - [@MattAlp](https://github.com/MattAlp)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - 💡 Collect process tags for profiling upload requests ([#8780](DataDog/dd-trace-java#8780) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 💡 Surface process tags on telemetry payloads ([#8837](DataDog/dd-trace-java#8837) - [@amarziali](https://github.com/amarziali)) #### Trace context propagation - ✨ Migrating all HttpClient Instrumentations to Inject Full Context ([#8826](DataDog/dd-trace-java#8826) - [@mhlidd](https://github.com/mhlidd)) - ✨ Migrating all HttpServer Instrumentations to Extract full Context ([#8820](DataDog/dd-trace-java#8820) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - ✨⚡ Skip JAXB generated classes classloader ([#9003](DataDog/dd-trace-java#9003) - [@bric3](https://github.com/bric3)) - ✨ Add DD\_RUNTIME\_METRICS\_RUNTIME\_ID\_ENABLED alias for runtime id generation ([#8981](DataDog/dd-trace-java#8981) - [@amarziali](https://github.com/amarziali)) - 🐛 Use resolved address for peer.hostname when available without hitting the cache ([#8915](DataDog/dd-trace-java#8915) - [@amarziali](https://github.com/amarziali)) - 💡 Surface server name process tag for tomcat ([#8894](DataDog/dd-trace-java#8894) - [@amarziali](https://github.com/amarziali)) - 💡 Surface websphere cell and server name on process tags ([#8880](DataDog/dd-trace-java#8880) - [@amarziali](https://github.com/amarziali)) - ✨ Added special lightweight pre-main class that skips installation on incompatible JVMs. ([#8855](DataDog/dd-trace-java#8855) - [@AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add entrypoint type to process tags ([#8839](DataDog/dd-trace-java#8839) - [@amarziali](https://github.com/amarziali)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - ✨ Notify listeners when the scope top changes after switching scope stacks ([#8797](DataDog/dd-trace-java#8797) - [@mcculls](https://github.com/mcculls)) - ✨ Read hsperfdata for Java PIDs if jvmstat is unavailable ([#8792](DataDog/dd-trace-java#8792) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Turn JDK socket support on by default ([#8752](DataDog/dd-trace-java#8752) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Simplify context propagation ([#8719](DataDog/dd-trace-java#8719) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Add JSON parsing support ([#8579](DataDog/dd-trace-java#8579) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer internal logging - ✨ Fix printing format of span identifiers ([#8897](DataDog/dd-trace-java#8897) - [@vandonr](https://github.com/vandonr)) #### Tracer public API - 💡 Track the source of installation ([#8956](DataDog/dd-trace-java#8956) - [@mabdinur](https://github.com/mabdinur)) - ✨ Enforce size limit on application\_monitoring.yaml files ([#8789](DataDog/dd-trace-java#8789) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Enabling baggage cache to support limits and non-ascii characters ([#8713](DataDog/dd-trace-java#8713) - [@mhlidd](https://github.com/mhlidd)) ### Instrumentations #### AWS Lambda instrumentation - ✨ Pass Lambda Request ID to Extension ([#8814](DataDog/dd-trace-java#8814) - [@nhulston](https://github.com/nhulston)) #### Core Java language instrumentation - ✨ Ensure ClassloadingInstrumentation is always applied even with `DD_TRACE_ENABLED=false` ([#8863](DataDog/dd-trace-java#8863) - [@mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - 🐛 Do not override route with / in vertx instrumentation ([#8881](DataDog/dd-trace-java#8881) - [@vandonr](https://github.com/vandonr)) #### IBM Liberty - 🐛 Fix error mark on http status for IBM liberty ([#8822](DataDog/dd-trace-java#8822) - [@amarziali](https://github.com/amarziali)) #### JDBC instrumentation - 🐛 Do not prepend DBM <> APM trace comment in SQLCommenter if there is a pg plan hint ([#8864](DataDog/dd-trace-java#8864) - [@edengorevoy](https://github.com/edengorevoy)) #### JMS instrumentation - ✨ Add jms as an extra integration name where there is JMS involved ([#8933](DataDog/dd-trace-java#8933) - [@vandonr](https://github.com/vandonr)) #### Kotlin instrumentation - ✨ Enable kotlin\_coroutine integration by default ([#8848](DataDog/dd-trace-java#8848) - [@mcculls](https://github.com/mcculls)) - 🧹 Rework Kotlin coroutines instrumentation around coroutine context ([#8774](DataDog/dd-trace-java#8774) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Support WithSpan inheritContext attribute ([#8858](DataDog/dd-trace-java#8858) - [@amarziali](https://github.com/amarziali)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Play Framework instrumentation - 🐛 Fix the Play Framework's span resource name priority so that the client JAX-RS 404 cannot override it ([#8591](DataDog/dd-trace-java#8591) - [@ygree](https://github.com/ygree)) #### Quarkus Instrumentation - 🐛 Ignore quarkus jaxrs stubs and cdi wrapper proxies ([#8891](DataDog/dd-trace-java#8891) - [@amarziali](https://github.com/amarziali)) #### ServiceTalk - ✨ Improve ServiceTalk Captured Context API Instrumentation for v0.42.56+ ([#8821](DataDog/dd-trace-java#8821) - [@ygree](https://github.com/ygree)) #### Spring instrumentation - ✨ Supporting Baggage for Instrumentations used in Weblog Tests ([#8773](DataDog/dd-trace-java#8773) - [@mhlidd](https://github.com/mhlidd)) #### WebSocket Instrumentation - 💡 Trace websocket for spring webflux reactive handlers ([#8831](DataDog/dd-trace-java#8831) - [@amarziali](https://github.com/amarziali)) - 💡:test\_tube: WebSocket support for Netty ([#8632](DataDog/dd-trace-java#8632) - [@ValentinZakharov](https://github.com/ValentinZakharov)) #### Zio Instrumentation - 🧹 Cleanup Zio fiber instrumentation to avoid repeated activation of continuation ([#8798](DataDog/dd-trace-java#8798) - [@mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9207366cdb6a1bd098082305d354a0a3c4622d7a

fix printing format of span IDs

31f6544

vandonr requested a review from a team as a code owner May 28, 2025 15:23

vandonr requested a review from smola May 28, 2025 15:23

vandonr added type: enhancement comp: logging Tracer internal logging labels May 28, 2025

mcculls approved these changes May 28, 2025

View reviewed changes

AlexeyKuznetsov-DD reviewed May 29, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/DDSpanContext.java Outdated Show resolved Hide resolved

PerfectSlayer requested changes May 30, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/DDSpanContext.java Outdated Show resolved Hide resolved

dd-trace-core/src/main/java/datadog/trace/core/DDSpanContext.java Outdated Show resolved Hide resolved

vandonr and others added 2 commits May 30, 2025 10:33

use DDSpanID.toString

b687fe8

Co-authored-by: Bruce Bujon <PerfectSlayer@users.noreply.github.com>

use DDSpanID.toString

d6f19c4

Co-authored-by: Bruce Bujon <PerfectSlayer@users.noreply.github.com>

PerfectSlayer approved these changes May 30, 2025

View reviewed changes

PerfectSlayer changed the title ~~fix printing format of span IDs~~ Fix printing format of span identifiers May 30, 2025

vandonr added 2 commits May 30, 2025 11:18

add test

c652cc0

fix build

7e14f7b

AlexeyKuznetsov-DD requested changes May 30, 2025

View reviewed changes

dd-trace-core/src/test/groovy/datadog/trace/core/DDSpanContextTest.groovy Outdated Show resolved Hide resolved

fix test name

6336914

AlexeyKuznetsov-DD self-requested a review May 30, 2025 12:29

AlexeyKuznetsov-DD approved these changes May 30, 2025

View reviewed changes

vandonr merged commit 3070e2e into master May 30, 2025
506 of 507 checks passed

vandonr deleted the vandonr/fix2 branch May 30, 2025 14:36

github-actions bot added this to the 1.50.0 milestone May 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix printing format of span identifiers #8897

Fix printing format of span identifiers #8897

Uh oh!

vandonr commented May 28, 2025

Uh oh!

pr-commenter bot commented May 28, 2025 •

edited

Loading

Uh oh!

mcculls left a comment

Uh oh!

Uh oh!

PerfectSlayer left a comment

Uh oh!

Uh oh!

Uh oh!

PerfectSlayer left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fix printing format of span identifiers #8897

Fix printing format of span identifiers #8897

Uh oh!

Conversation

vandonr commented May 28, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

mcculls left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pr-commenter bot commented May 28, 2025 •

edited

Loading