Skip to content

Use tag as fallback in api requests if no branch is available #8876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025

Conversation

daniel-mohedano
Copy link
Contributor

@daniel-mohedano daniel-mohedano commented May 23, 2025

What Does This Do

When building the tracer environment used in the API requests to the backend, git.tag will be used as branch when this value is not available.

Motivation

When a GitHub action is triggered on a tag push (not a branch), we end up sending requests with branch: null, causing a 400 to be returned from the backend.

Additional Notes

Contributor Checklist

Jira ticket: SDTEST-2035

@daniel-mohedano daniel-mohedano added type: bug comp: ci visibility Continuous Integration Visibility labels May 23, 2025
@pr-commenter
Copy link

pr-commenter bot commented May 23, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master daniel.mohedano/settings-api-branch-tag
git_commit_date 1746789389 1748019768
git_commit_sha ad6d5fe 7e8ef95
release_version 1.50.0-SNAPSHOT~ad6d5fef42 1.50.0-SNAPSHOT~7e8ef9510e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1748022182 1748022182
ci_job_id 952649840 952649840
ci_pipeline_id 66007793 66007793
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-pycpjsjc-project-304-concurrent-0-ree2usc1 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-pycpjsjc-project-304-concurrent-0-ree2usc1 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 3 performance improvements and 2 performance regressions! Performance is the same for 55 metrics, 11 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:profiling:ProfilingAgent better
[-7.613ms; -3.653ms] or [-6.955%; -3.337%]
103.825ms 109.458ms
scenario:startup:petclinic:profiling:GlobalTracer better
[-19.464ms; -14.855ms] or [-5.156%; -3.935%]
360.315ms 377.474ms
scenario:startup:petclinic:profiling:AppSec worse
[+6.047ms; +8.908ms] or [+11.081%; +16.324%]
62.048ms 54.571ms
scenario:startup:petclinic:profiling:Debugger worse
[+146.546µs; +324.266µs] or [+2.410%; +5.332%]
6.317ms 6.082ms
scenario:startup:petclinic:profiling:Profiling better
[-7.615ms; -3.654ms] or [-6.956%; -3.337%]
103.849ms 109.483ms
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~7e8ef9510e, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022463
Total [baseline] (10.464 s) : 0, 10464132
Agent [candidate] (1.028 s) : 0, 1027931
Total [candidate] (10.559 s) : 0, 10558659
section appsec
Agent [baseline] (1.164 s) : 0, 1164479
Total [baseline] (10.697 s) : 0, 10696986
Agent [candidate] (1.161 s) : 0, 1161121
Total [candidate] (10.667 s) : 0, 10666616
section iast
Agent [baseline] (1.152 s) : 0, 1152438
Total [baseline] (10.938 s) : 0, 10937924
Agent [candidate] (1.152 s) : 0, 1152029
Total [candidate] (10.898 s) : 0, 10898055
section profiling
Agent [baseline] (1.284 s) : 0, 1284053
Total [baseline] (10.958 s) : 0, 10957798
Agent [candidate] (1.267 s) : 0, 1267446
Total [candidate] (10.919 s) : 0, 10918543
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.022 s -
Agent appsec 1.164 s 142.016 ms (13.9%)
Agent iast 1.152 s 129.975 ms (12.7%)
Agent profiling 1.284 s 261.591 ms (25.6%)
Total tracing 10.464 s -
Total appsec 10.697 s 232.854 ms (2.2%)
Total iast 10.938 s 473.792 ms (4.5%)
Total profiling 10.958 s 493.665 ms (4.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.028 s -
Agent appsec 1.161 s 133.19 ms (13.0%)
Agent iast 1.152 s 124.098 ms (12.1%)
Agent profiling 1.267 s 239.515 ms (23.3%)
Total tracing 10.559 s -
Total appsec 10.667 s 107.957 ms (1.0%)
Total iast 10.898 s 339.396 ms (3.2%)
Total profiling 10.919 s 359.884 ms (3.4%)
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~7e8ef9510e, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.656 ms) : 0, 683656
BytebuddyAgent [candidate] (688.176 ms) : 0, 688176
GlobalTracer [baseline] (240.553 ms) : 0, 240553
GlobalTracer [candidate] (242.007 ms) : 0, 242007
AppSec [baseline] (54.533 ms) : 0, 54533
AppSec [candidate] (54.792 ms) : 0, 54792
Debugger [baseline] (10.47 ms) : 0, 10470
Debugger [candidate] (10.275 ms) : 0, 10275
Remote Config [baseline] (691.79 µs) : 0, 692
Remote Config [candidate] (702.022 µs) : 0, 702
Telemetry [baseline] (8.986 ms) : 0, 8986
Telemetry [candidate] (8.316 ms) : 0, 8316
section appsec
BytebuddyAgent [baseline] (702.217 ms) : 0, 702217
BytebuddyAgent [candidate] (699.798 ms) : 0, 699798
GlobalTracer [baseline] (237.606 ms) : 0, 237606
GlobalTracer [candidate] (236.748 ms) : 0, 236748
IAST [baseline] (21.783 ms) : 0, 21783
IAST [candidate] (21.685 ms) : 0, 21685
AppSec [baseline] (175.799 ms) : 0, 175799
AppSec [candidate] (176.273 ms) : 0, 176273
Debugger [baseline] (5.971 ms) : 0, 5971
Debugger [candidate] (5.922 ms) : 0, 5922
Remote Config [baseline] (631.475 µs) : 0, 631
Remote Config [candidate] (624.553 µs) : 0, 625
Telemetry [baseline] (7.796 ms) : 0, 7796
Telemetry [candidate] (7.336 ms) : 0, 7336
section iast
BytebuddyAgent [baseline] (805.955 ms) : 0, 805955
BytebuddyAgent [candidate] (803.837 ms) : 0, 803837
GlobalTracer [baseline] (230.302 ms) : 0, 230302
GlobalTracer [candidate] (231.462 ms) : 0, 231462
IAST [baseline] (26.612 ms) : 0, 26612
IAST [candidate] (28.264 ms) : 0, 28264
AppSec [baseline] (50.042 ms) : 0, 50042
AppSec [candidate] (50.508 ms) : 0, 50508
Debugger [baseline] (5.871 ms) : 0, 5871
Debugger [candidate] (5.907 ms) : 0, 5907
Remote Config [baseline] (585.784 µs) : 0, 586
Remote Config [candidate] (600.544 µs) : 0, 601
Telemetry [baseline] (7.862 ms) : 0, 7862
Telemetry [candidate] (7.919 ms) : 0, 7919
section profiling
BytebuddyAgent [baseline] (676.849 ms) : 0, 676849
BytebuddyAgent [candidate] (675.046 ms) : 0, 675046
GlobalTracer [baseline] (377.474 ms) : 0, 377474
GlobalTracer [candidate] (360.315 ms) : 0, 360315
AppSec [baseline] (54.571 ms) : 0, 54571
AppSec [candidate] (62.048 ms) : 0, 62048
Debugger [baseline] (6.082 ms) : 0, 6082
Debugger [candidate] (6.317 ms) : 0, 6317
Remote Config [baseline] (670.1 µs) : 0, 670
Remote Config [candidate] (647.672 µs) : 0, 648
Telemetry [baseline] (8.048 ms) : 0, 8048
Telemetry [candidate] (8.257 ms) : 0, 8257
ProfilingAgent [baseline] (109.458 ms) : 0, 109458
ProfilingAgent [candidate] (103.825 ms) : 0, 103825
Profiling [baseline] (109.483 ms) : 0, 109483
Profiling [candidate] (103.849 ms) : 0, 103849
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~7e8ef9510e, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017938
Total [baseline] (8.642 s) : 0, 8641625
Agent [candidate] (1.026 s) : 0, 1025595
Total [candidate] (8.664 s) : 0, 8663708
section iast
Agent [baseline] (1.15 s) : 0, 1149960
Total [baseline] (9.199 s) : 0, 9198872
Agent [candidate] (1.148 s) : 0, 1148026
Total [candidate] (9.218 s) : 0, 9217696
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.156 s) : 0, 1156312
Total [baseline] (9.217 s) : 0, 9216978
Agent [candidate] (1.149 s) : 0, 1148932
Total [candidate] (9.178 s) : 0, 9178010
section iast_TELEMETRY_OFF
Agent [baseline] (1.145 s) : 0, 1144765
Total [baseline] (9.211 s) : 0, 9211329
Agent [candidate] (1.15 s) : 0, 1150347
Total [candidate] (9.205 s) : 0, 9204619
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.018 s -
Agent iast 1.15 s 132.022 ms (13.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.156 s 138.374 ms (13.6%)
Agent iast_TELEMETRY_OFF 1.145 s 126.827 ms (12.5%)
Total tracing 8.642 s -
Total iast 9.199 s 557.247 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.217 s 575.352 ms (6.7%)
Total iast_TELEMETRY_OFF 9.211 s 569.704 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.026 s -
Agent iast 1.148 s 122.431 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.149 s 123.338 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.15 s 124.752 ms (12.2%)
Total tracing 8.664 s -
Total iast 9.218 s 553.988 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.178 s 514.302 ms (5.9%)
Total iast_TELEMETRY_OFF 9.205 s 540.911 ms (6.2%)
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~7e8ef9510e, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.206 ms) : 0, 681206
BytebuddyAgent [candidate] (685.451 ms) : 0, 685451
GlobalTracer [baseline] (239.825 ms) : 0, 239825
GlobalTracer [candidate] (241.587 ms) : 0, 241587
AppSec [baseline] (54.625 ms) : 0, 54625
AppSec [candidate] (54.635 ms) : 0, 54635
Debugger [baseline] (8.295 ms) : 0, 8295
Debugger [candidate] (11.291 ms) : 0, 11291
Remote Config [baseline] (705.049 µs) : 0, 705
Remote Config [candidate] (700.79 µs) : 0, 701
Telemetry [baseline] (9.753 ms) : 0, 9753
Telemetry [candidate] (8.351 ms) : 0, 8351
section iast
BytebuddyAgent [baseline] (802.693 ms) : 0, 802693
BytebuddyAgent [candidate] (801.568 ms) : 0, 801568
GlobalTracer [baseline] (230.687 ms) : 0, 230687
GlobalTracer [candidate] (230.816 ms) : 0, 230816
IAST [baseline] (28.238 ms) : 0, 28238
IAST [candidate] (28.801 ms) : 0, 28801
AppSec [baseline] (50.429 ms) : 0, 50429
AppSec [candidate] (48.179 ms) : 0, 48179
Debugger [baseline] (5.856 ms) : 0, 5856
Debugger [candidate] (5.889 ms) : 0, 5889
Remote Config [baseline] (579.413 µs) : 0, 579
Remote Config [candidate] (580.445 µs) : 0, 580
Telemetry [baseline] (7.804 ms) : 0, 7804
Telemetry [candidate] (7.859 ms) : 0, 7859
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.402 ms) : 0, 807402
BytebuddyAgent [candidate] (801.629 ms) : 0, 801629
GlobalTracer [baseline] (231.809 ms) : 0, 231809
GlobalTracer [candidate] (231.173 ms) : 0, 231173
IAST [baseline] (28.538 ms) : 0, 28538
IAST [candidate] (28.98 ms) : 0, 28980
AppSec [baseline] (50.481 ms) : 0, 50481
AppSec [candidate] (49.337 ms) : 0, 49337
Debugger [baseline] (5.942 ms) : 0, 5942
Debugger [candidate] (5.917 ms) : 0, 5917
Remote Config [baseline] (589.853 µs) : 0, 590
Remote Config [candidate] (596.262 µs) : 0, 596
Telemetry [baseline] (7.911 ms) : 0, 7911
Telemetry [candidate] (7.883 ms) : 0, 7883
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.816 ms) : 0, 797816
BytebuddyAgent [candidate] (802.344 ms) : 0, 802344
GlobalTracer [baseline] (230.832 ms) : 0, 230832
GlobalTracer [candidate] (231.971 ms) : 0, 231971
IAST [baseline] (22.308 ms) : 0, 22308
IAST [candidate] (22.338 ms) : 0, 22338
AppSec [baseline] (56.02 ms) : 0, 56020
AppSec [candidate] (55.737 ms) : 0, 55737
Debugger [baseline] (5.934 ms) : 0, 5934
Debugger [candidate] (5.938 ms) : 0, 5938
Remote Config [baseline] (599.91 µs) : 0, 600
Remote Config [candidate] (598.088 µs) : 0, 598
Telemetry [baseline] (7.726 ms) : 0, 7726
Telemetry [candidate] (7.793 ms) : 0, 7793
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-05-23T17:13:19 2025-05-23T17:21:08
git_branch master daniel.mohedano/settings-api-branch-tag
git_commit_date 1746789389 1748019768
git_commit_sha ad6d5fe 7e8ef95
release_version 1.50.0-SNAPSHOT~ad6d5fef42 1.50.0-SNAPSHOT~7e8ef9510e
start_time 2025-05-23T17:13:04 2025-05-23T17:20:54
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1748021270 1748021270
ci_job_id 952649841 952649841
ci_pipeline_id 66007793 66007793
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-pycpjsjc-project-304-concurrent-1-18ag2jal 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-pycpjsjc-project-304-concurrent-1-18ag2jal 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~7e8ef9510e, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (386.642 µs) : 365, 408
.   : milestone, 387,
iast (531.759 µs) : 510, 554
.   : milestone, 532,
iast_FULL (741.157 µs) : 719, 763
.   : milestone, 741,
iast_GLOBAL (578.465 µs) : 555, 602
.   : milestone, 578,
iast_HARDCODED_SECRET_DISABLED (535.317 µs) : 513, 558
.   : milestone, 535,
iast_INACTIVE (473.325 µs) : 451, 496
.   : milestone, 473,
iast_TELEMETRY_OFF (509.361 µs) : 486, 532
.   : milestone, 509,
tracing (473.8 µs) : 451, 497
.   : milestone, 474,
section candidate
no_agent (391.712 µs) : 371, 412
.   : milestone, 392,
iast (539.543 µs) : 518, 561
.   : milestone, 540,
iast_FULL (750.673 µs) : 728, 773
.   : milestone, 751,
iast_GLOBAL (575.272 µs) : 552, 599
.   : milestone, 575,
iast_HARDCODED_SECRET_DISABLED (540.378 µs) : 517, 564
.   : milestone, 540,
iast_INACTIVE (478.451 µs) : 456, 501
.   : milestone, 478,
iast_TELEMETRY_OFF (517.506 µs) : 495, 540
.   : milestone, 518,
tracing (475.98 µs) : 453, 499
.   : milestone, 476,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 386.642 µs [365.218 µs, 408.066 µs] -
iast 531.759 µs [509.916 µs, 553.602 µs] 145.117 µs (37.5%)
iast_FULL 741.157 µs [719.32 µs, 762.995 µs] 354.516 µs (91.7%)
iast_GLOBAL 578.465 µs [555.401 µs, 601.53 µs] 191.823 µs (49.6%)
iast_HARDCODED_SECRET_DISABLED 535.317 µs [512.781 µs, 557.853 µs] 148.675 µs (38.5%)
iast_INACTIVE 473.325 µs [450.997 µs, 495.653 µs] 86.683 µs (22.4%)
iast_TELEMETRY_OFF 509.361 µs [486.276 µs, 532.446 µs] 122.719 µs (31.7%)
tracing 473.8 µs [450.888 µs, 496.711 µs] 87.158 µs (22.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 391.712 µs [371.383 µs, 412.042 µs] -
iast 539.543 µs [517.744 µs, 561.343 µs] 147.831 µs (37.7%)
iast_FULL 750.673 µs [728.207 µs, 773.138 µs] 358.96 µs (91.6%)
iast_GLOBAL 575.272 µs [551.933 µs, 598.611 µs] 183.56 µs (46.9%)
iast_HARDCODED_SECRET_DISABLED 540.378 µs [516.636 µs, 564.12 µs] 148.665 µs (38.0%)
iast_INACTIVE 478.451 µs [455.505 µs, 501.397 µs] 86.739 µs (22.1%)
iast_TELEMETRY_OFF 517.506 µs [494.538 µs, 540.473 µs] 125.793 µs (32.1%)
tracing 475.98 µs [453.291 µs, 498.669 µs] 84.268 µs (21.5%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~7e8ef9510e, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.374 ms) : 1354, 1394
.   : milestone, 1374,
appsec (1.75 ms) : 1726, 1775
.   : milestone, 1750,
appsec_no_iast (1.736 ms) : 1712, 1760
.   : milestone, 1736,
code_origins (1.693 ms) : 1667, 1720
.   : milestone, 1693,
iast (1.522 ms) : 1498, 1547
.   : milestone, 1522,
profiling (1.514 ms) : 1491, 1537
.   : milestone, 1514,
tracing (1.507 ms) : 1481, 1532
.   : milestone, 1507,
section candidate
no_agent (1.375 ms) : 1355, 1394
.   : milestone, 1375,
appsec (1.753 ms) : 1730, 1777
.   : milestone, 1753,
appsec_no_iast (1.745 ms) : 1721, 1768
.   : milestone, 1745,
code_origins (1.677 ms) : 1649, 1704
.   : milestone, 1677,
iast (1.513 ms) : 1489, 1537
.   : milestone, 1513,
profiling (1.541 ms) : 1517, 1564
.   : milestone, 1541,
tracing (1.516 ms) : 1490, 1543
.   : milestone, 1516,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.374 ms [1.354 ms, 1.394 ms] -
appsec 1.75 ms [1.726 ms, 1.775 ms] 376.28 µs (27.4%)
appsec_no_iast 1.736 ms [1.712 ms, 1.76 ms] 361.646 µs (26.3%)
code_origins 1.693 ms [1.667 ms, 1.72 ms] 319.31 µs (23.2%)
iast 1.522 ms [1.498 ms, 1.547 ms] 148.35 µs (10.8%)
profiling 1.514 ms [1.491 ms, 1.537 ms] 139.943 µs (10.2%)
tracing 1.507 ms [1.481 ms, 1.532 ms] 132.459 µs (9.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.375 ms [1.355 ms, 1.394 ms] -
appsec 1.753 ms [1.73 ms, 1.777 ms] 378.953 µs (27.6%)
appsec_no_iast 1.745 ms [1.721 ms, 1.768 ms] 369.999 µs (26.9%)
code_origins 1.677 ms [1.649 ms, 1.704 ms] 301.973 µs (22.0%)
iast 1.513 ms [1.489 ms, 1.537 ms] 138.485 µs (10.1%)
profiling 1.541 ms [1.517 ms, 1.564 ms] 166.066 µs (12.1%)
tracing 1.516 ms [1.49 ms, 1.543 ms] 141.934 µs (10.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master daniel.mohedano/settings-api-branch-tag
git_commit_date 1746789389 1748019768
git_commit_sha ad6d5fe 7e8ef95
release_version 1.50.0-SNAPSHOT~ad6d5fef42 1.50.0-SNAPSHOT~7e8ef9510e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1748021762 1748021762
ci_job_id 952649842 952649842
ci_pipeline_id 66007793 66007793
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-pq7vvevp-project-304-concurrent-1-8u10hze5 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-pq7vvevp-project-304-concurrent-1-8u10hze5 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~7e8ef9510e, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
.   : milestone, 1481,
appsec (2.422 ms) : 2373, 2471
.   : milestone, 2422,
iast (2.194 ms) : 2133, 2256
.   : milestone, 2194,
iast_GLOBAL (2.233 ms) : 2172, 2295
.   : milestone, 2233,
profiling (2.035 ms) : 1987, 2084
.   : milestone, 2035,
tracing (2.018 ms) : 1971, 2066
.   : milestone, 2018,
section candidate
no_agent (1.484 ms) : 1473, 1496
.   : milestone, 1484,
appsec (2.418 ms) : 2369, 2467
.   : milestone, 2418,
iast (2.205 ms) : 2143, 2266
.   : milestone, 2205,
iast_GLOBAL (2.235 ms) : 2174, 2297
.   : milestone, 2235,
profiling (2.059 ms) : 2008, 2110
.   : milestone, 2059,
tracing (2.026 ms) : 1979, 2074
.   : milestone, 2026,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.481 ms [1.47 ms, 1.493 ms] -
appsec 2.422 ms [2.373 ms, 2.471 ms] 940.634 µs (63.5%)
iast 2.194 ms [2.133 ms, 2.256 ms] 713.092 µs (48.1%)
iast_GLOBAL 2.233 ms [2.172 ms, 2.295 ms] 751.823 µs (50.8%)
profiling 2.035 ms [1.987 ms, 2.084 ms] 554.019 µs (37.4%)
tracing 2.018 ms [1.971 ms, 2.066 ms] 537.037 µs (36.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.484 ms [1.473 ms, 1.496 ms] -
appsec 2.418 ms [2.369 ms, 2.467 ms] 933.848 µs (62.9%)
iast 2.205 ms [2.143 ms, 2.266 ms] 720.542 µs (48.5%)
iast_GLOBAL 2.235 ms [2.174 ms, 2.297 ms] 751.304 µs (50.6%)
profiling 2.059 ms [2.008 ms, 2.11 ms] 574.658 µs (38.7%)
tracing 2.026 ms [1.979 ms, 2.074 ms] 542.243 µs (36.5%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~7e8ef9510e, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.538 s) : 15538000, 15538000
.   : milestone, 15538000,
appsec (15.232 s) : 15232000, 15232000
.   : milestone, 15232000,
iast (18.76 s) : 18760000, 18760000
.   : milestone, 18760000,
iast_GLOBAL (18.218 s) : 18218000, 18218000
.   : milestone, 18218000,
profiling (15.076 s) : 15076000, 15076000
.   : milestone, 15076000,
tracing (15.035 s) : 15035000, 15035000
.   : milestone, 15035000,
section candidate
no_agent (15.15 s) : 15150000, 15150000
.   : milestone, 15150000,
appsec (15.253 s) : 15253000, 15253000
.   : milestone, 15253000,
iast (18.393 s) : 18393000, 18393000
.   : milestone, 18393000,
iast_GLOBAL (18.323 s) : 18323000, 18323000
.   : milestone, 18323000,
profiling (15.052 s) : 15052000, 15052000
.   : milestone, 15052000,
tracing (14.919 s) : 14919000, 14919000
.   : milestone, 14919000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.538 s [15.538 s, 15.538 s] -
appsec 15.232 s [15.232 s, 15.232 s] -306.0 ms (-2.0%)
iast 18.76 s [18.76 s, 18.76 s] 3.222 s (20.7%)
iast_GLOBAL 18.218 s [18.218 s, 18.218 s] 2.68 s (17.2%)
profiling 15.076 s [15.076 s, 15.076 s] -462.0 ms (-3.0%)
tracing 15.035 s [15.035 s, 15.035 s] -503.0 ms (-3.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.15 s [15.15 s, 15.15 s] -
appsec 15.253 s [15.253 s, 15.253 s] 103.0 ms (0.7%)
iast 18.393 s [18.393 s, 18.393 s] 3.243 s (21.4%)
iast_GLOBAL 18.323 s [18.323 s, 18.323 s] 3.173 s (20.9%)
profiling 15.052 s [15.052 s, 15.052 s] -98.0 ms (-0.6%)
tracing 14.919 s [14.919 s, 14.919 s] -231.0 ms (-1.5%)

@daniel-mohedano daniel-mohedano marked this pull request as ready for review May 26, 2025 12:41
@daniel-mohedano daniel-mohedano requested a review from a team as a code owner May 26, 2025 12:41
@daniel-mohedano daniel-mohedano requested a review from Mariovido May 26, 2025 12:41
@daniel-mohedano daniel-mohedano merged commit 3c2ecd5 into master May 26, 2025
525 of 526 checks passed
@daniel-mohedano daniel-mohedano deleted the daniel.mohedano/settings-api-branch-tag branch May 26, 2025 12:42
@github-actions github-actions bot added this to the 1.50.0 milestone May 26, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Jun 20, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.49.0` -> `1.50.0` |

---

### Release Notes

<details>
<summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary>

###
[`v1.50.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.0):
1.50.0

### Deprecation Notice

> \[!NOTE]
> `DD_RUNTIME_ID_ENABLED` has been deprecated and will be removed in
future releases. Please use `DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED`
instead.

### Components

#### Application Security Management (WAF)

- 🐛 Add String length truncation limit to ObjectIntrospector and
update truncation metrics
([#&#8203;8825](DataDog/dd-trace-java#8825) -
[@&#8203;jandro996](https://github.com/jandro996))
- 🐛 Adapt standalone ASM to support API Security
([#&#8203;8804](DataDog/dd-trace-java#8804) -
[@&#8203;jandro996](https://github.com/jandro996))
- ✨ Add appsec.waf.input\_truncated metric
([#&#8203;8791](DataDog/dd-trace-java#8791) -
[@&#8203;jandro996](https://github.com/jandro996))
- ✨ Extended appsec request body collection
([#&#8203;8748](DataDog/dd-trace-java#8748) -
[@&#8203;jandro996](https://github.com/jandro996))
- ✨ Extended appsec request/response headers collection
([#&#8203;8724](DataDog/dd-trace-java#8724) -
[@&#8203;jandro996](https://github.com/jandro996))

#### Build & Tooling

- ✨ Add artifacts to public s3 bucket
([#&#8203;8947](DataDog/dd-trace-java#8947) -
[@&#8203;randomanderson](https://github.com/randomanderson))

#### Continuous Integration Visibility

- ✨ Improve PR information building
([#&#8203;8908](DataDog/dd-trace-java#8908) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Truncate span stack traces when Test Optimization is
enabled
([#&#8203;8903](DataDog/dd-trace-java#8903) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- 🐛 Ensure auto-detected service name is the same for every process
in the same build
([#&#8203;8902](DataDog/dd-trace-java#8902) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- 🐛 Use tag as fallback in api requests if no branch is available
([#&#8203;8876](DataDog/dd-trace-java#8876) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Add support for JUnit 5.13-RC1
([#&#8203;8865](DataDog/dd-trace-java#8865),
[#&#8203;8871](DataDog/dd-trace-java#8871) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Implement attempt to fix v3 and v4 and bump capability
version
([#&#8203;8824](DataDog/dd-trace-java#8824) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- 🧹 Align retry logic for all test framework instrumentations
([#&#8203;8803](DataDog/dd-trace-java#8803) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- 🐛 Always build ci workspace without trailing separator
([#&#8203;8788](DataDog/dd-trace-java#8788) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Add commit discrepancies telemetry when building repository
git information
([#&#8203;8763](DataDog/dd-trace-java#8763) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))

#### Data Streams Monitoring

- 💡 Surface process tags in dsm payloads and use them for base hash
calculation
([#&#8203;8836](DataDog/dd-trace-java#8836) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Dynamic Instrumentation

- ✨ Optimized allocations for collection filter functions
([#&#8203;8896](DataDog/dd-trace-java#8896) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 🐛 Fix SymDB upload size check
([#&#8203;8887](DataDog/dd-trace-java#8887) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 🐛 Add support for Set in filter function
([#&#8203;8873](DataDog/dd-trace-java#8873) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 🐛 Add support for isDefined in log template
([#&#8203;8859](DataDog/dd-trace-java#8859) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 🐛 Fix Max captured frames for Exception Replay
([#&#8203;8856](DataDog/dd-trace-java#8856) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 🐛 Remove static inherited fields collection
([#&#8203;8832](DataDog/dd-trace-java#8832) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 💡 Add process tags to dynamic instrumentation intake payload
([#&#8203;8779](DataDog/dd-trace-java#8779) -
[@&#8203;amarziali](https://github.com/amarziali))

#### GraalVM native-image

- ✨ Add support for GraalVM Native GC metrics
([#&#8203;8913](DataDog/dd-trace-java#8913) -
[@&#8203;ygree](https://github.com/ygree))
- ✨ Add JMXFetch support for GraalVM Native
([#&#8203;8569](DataDog/dd-trace-java#8569) -
[@&#8203;ygree](https://github.com/ygree))

#### JMX fetch

- ✨ Add support for GraalVM Native GC metrics
([#&#8203;8913](DataDog/dd-trace-java#8913) -
[@&#8203;ygree](https://github.com/ygree))

#### Library Injection

- ✨ Deny oracle db jvm based tools
([#&#8203;8909](DataDog/dd-trace-java#8909) -
[@&#8203;bric3](https://github.com/bric3))

#### OpenTracing

- 🐛 Fix OT packaging for exception replay
([#&#8203;8912](DataDog/dd-trace-java#8912) -
[@&#8203;jpbempel](https://github.com/jpbempel))

#### Profiling

- ✨ Bump ddprof to 1.27.0
([#&#8203;8893](DataDog/dd-trace-java#8893) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- Properly handle the adaptive sampling interval overflow by
[@&#8203;jbachorik](https://github.com/jbachorik) in
DataDog/java-profiler#213
- Fix [#&#8203;200](DataDog/dd-trace-java#200)
Crash related to aligned\_alloc and free in context by
[@&#8203;yanglong1010](https://github.com/yanglong1010) in
DataDog/java-profiler#208
- Explicitly initialize empty context page by
[@&#8203;jbachorik](https://github.com/jbachorik) in
DataDog/java-profiler#210
- Re-connect crash recursion protection with VM stackwalker by
[@&#8203;jbachorik](https://github.com/jbachorik) in
DataDog/java-profiler#214
- ✨ Enable ZSTD compression for profiling
([#&#8203;8862](DataDog/dd-trace-java#8862) -
[@&#8203;MattAlp](https://github.com/MattAlp))
- ✨ Extend JPS re-implementation to J9 family
([#&#8203;8813](DataDog/dd-trace-java#8813) -
[@&#8203;MattAlp](https://github.com/MattAlp))
- 💡 Collect process tags for profiling upload requests
([#&#8203;8780](DataDog/dd-trace-java#8780) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Telemetry

- 💡 Surface process tags on telemetry payloads
([#&#8203;8837](DataDog/dd-trace-java#8837) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Trace context propagation

- ✨ Migrating all HttpClient Instrumentations to Inject Full
Context
([#&#8203;8826](DataDog/dd-trace-java#8826) -
[@&#8203;mhlidd](https://github.com/mhlidd))
- ✨ Migrating all HttpServer Instrumentations to Extract full
Context
([#&#8203;8820](DataDog/dd-trace-java#8820) -
[@&#8203;mhlidd](https://github.com/mhlidd))
- ✨ Add context API support OTel propagators
([#&#8203;8770](DataDog/dd-trace-java#8770) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))

#### Tracer core

- ✨⚡ Skip JAXB generated classes classloader
([#&#8203;9003](DataDog/dd-trace-java#9003) -
[@&#8203;bric3](https://github.com/bric3))
- ✨ Add DD\_RUNTIME\_METRICS\_RUNTIME\_ID\_ENABLED alias for
runtime id generation
([#&#8203;8981](DataDog/dd-trace-java#8981) -
[@&#8203;amarziali](https://github.com/amarziali))
- 🐛 Use resolved address for peer.hostname when available without
hitting the cache
([#&#8203;8915](DataDog/dd-trace-java#8915) -
[@&#8203;amarziali](https://github.com/amarziali))
- 💡 Surface server name process tag for tomcat
([#&#8203;8894](DataDog/dd-trace-java#8894) -
[@&#8203;amarziali](https://github.com/amarziali))
- 💡 Surface websphere cell and server name on process tags
([#&#8203;8880](DataDog/dd-trace-java#8880) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Added special lightweight pre-main class that skips
installation on incompatible JVMs.
([#&#8203;8855](DataDog/dd-trace-java#8855) -
[@&#8203;AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD))
- 💡 Add entrypoint type to process tags
([#&#8203;8839](DataDog/dd-trace-java#8839) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Extend JPS re-implementation to J9 family
([#&#8203;8813](DataDog/dd-trace-java#8813) -
[@&#8203;MattAlp](https://github.com/MattAlp))
- ✨ Notify listeners when the scope top changes after switching
scope stacks
([#&#8203;8797](DataDog/dd-trace-java#8797) -
[@&#8203;mcculls](https://github.com/mcculls))
- ✨ Read hsperfdata for Java PIDs if jvmstat is unavailable
([#&#8203;8792](DataDog/dd-trace-java#8792) -
[@&#8203;MattAlp](https://github.com/MattAlp))
- 🐛 Turn JDK socket support on by default
([#&#8203;8752](DataDog/dd-trace-java#8752) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))
- ✨ Simplify context propagation
([#&#8203;8719](DataDog/dd-trace-java#8719) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))
- ✨ Add JSON parsing support
([#&#8203;8579](DataDog/dd-trace-java#8579) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))

#### Tracer internal logging

- ✨ Fix printing format of span identifiers
([#&#8203;8897](DataDog/dd-trace-java#8897) -
[@&#8203;vandonr](https://github.com/vandonr))

#### Tracer public API

- 💡 Track the source of installation
([#&#8203;8956](DataDog/dd-trace-java#8956) -
[@&#8203;mabdinur](https://github.com/mabdinur))
- ✨ Enforce size limit on application\_monitoring.yaml files
([#&#8203;8789](DataDog/dd-trace-java#8789) -
[@&#8203;mtoffl01](https://github.com/mtoffl01))
- ✨ Enabling baggage cache to support limits and non-ascii
characters
([#&#8203;8713](DataDog/dd-trace-java#8713) -
[@&#8203;mhlidd](https://github.com/mhlidd))

### Instrumentations

#### AWS Lambda instrumentation

- ✨ Pass Lambda Request ID to Extension
([#&#8203;8814](DataDog/dd-trace-java#8814) -
[@&#8203;nhulston](https://github.com/nhulston))

#### Core Java language instrumentation

- ✨ Ensure ClassloadingInstrumentation is always applied even
with `DD_TRACE_ENABLED=false`
([#&#8203;8863](DataDog/dd-trace-java#8863) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Eclipse Vert.x instrumentation

- 🐛 Do not override route with / in vertx instrumentation
([#&#8203;8881](DataDog/dd-trace-java#8881) -
[@&#8203;vandonr](https://github.com/vandonr))

#### IBM Liberty

- 🐛 Fix error mark on http status for IBM liberty
([#&#8203;8822](DataDog/dd-trace-java#8822) -
[@&#8203;amarziali](https://github.com/amarziali))

#### JDBC instrumentation

- 🐛 Do not prepend DBM <> APM trace comment in SQLCommenter if there
is a pg plan hint
([#&#8203;8864](DataDog/dd-trace-java#8864) -
[@&#8203;edengorevoy](https://github.com/edengorevoy))

#### JMS instrumentation

- ✨ Add jms as an extra integration name where there is JMS
involved
([#&#8203;8933](DataDog/dd-trace-java#8933) -
[@&#8203;vandonr](https://github.com/vandonr))

#### Kotlin instrumentation

- ✨ Enable kotlin\_coroutine integration by default
([#&#8203;8848](DataDog/dd-trace-java#8848) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🧹 Rework Kotlin coroutines instrumentation around coroutine
context
([#&#8203;8774](DataDog/dd-trace-java#8774) -
[@&#8203;mcculls](https://github.com/mcculls))

#### OpenTelemetry instrumentation

- 🐛 Support WithSpan inheritContext attribute
([#&#8203;8858](DataDog/dd-trace-java#8858) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Add context API support OTel propagators
([#&#8203;8770](DataDog/dd-trace-java#8770) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))

#### Play Framework instrumentation

- 🐛 Fix the Play Framework's span resource name priority so that the
client JAX-RS 404 cannot override it
([#&#8203;8591](DataDog/dd-trace-java#8591) -
[@&#8203;ygree](https://github.com/ygree))

#### Quarkus Instrumentation

- 🐛 Ignore quarkus jaxrs stubs and cdi wrapper proxies
([#&#8203;8891](DataDog/dd-trace-java#8891) -
[@&#8203;amarziali](https://github.com/amarziali))

#### ServiceTalk

- ✨ Improve ServiceTalk Captured Context API Instrumentation
for v0.42.56+
([#&#8203;8821](DataDog/dd-trace-java#8821) -
[@&#8203;ygree](https://github.com/ygree))

#### Spring instrumentation

- ✨ Supporting Baggage for Instrumentations used in Weblog
Tests
([#&#8203;8773](DataDog/dd-trace-java#8773) -
[@&#8203;mhlidd](https://github.com/mhlidd))

#### WebSocket Instrumentation

- 💡 Trace websocket for spring webflux reactive handlers
([#&#8203;8831](DataDog/dd-trace-java#8831) -
[@&#8203;amarziali](https://github.com/amarziali))
- 💡:test\_tube: WebSocket support for Netty
([#&#8203;8632](DataDog/dd-trace-java#8632) -
[@&#8203;ValentinZakharov](https://github.com/ValentinZakharov))

#### Zio Instrumentation

- 🧹 Cleanup Zio fiber instrumentation to avoid repeated activation
of continuation
([#&#8203;8798](DataDog/dd-trace-java#8798) -
[@&#8203;mcculls](https://github.com/mcculls))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 9207366cdb6a1bd098082305d354a0a3c4622d7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: ci visibility Continuous Integration Visibility type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants