Add support for Set in filter function #8873

jpbempel · 2025-05-23T12:57:04Z

What Does This Do

also refactor the check for supported collection and maps
add unit tests

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3936

pr-commenter · 2025-05-23T13:17:41Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1748005524	1748005893
end_time	2025-05-23T13:06:43	2025-05-23T13:12:53
git_branch	master	jpbempel/fix-filter-set-support
git_commit_sha	`ad6d5fe`	`058f41c`
start_time	2025-05-23T13:05:25	2025-05-23T13:11:33

See matching parameters

	Baseline	Candidate
ci_job_id	952060611	952060611
ci_pipeline_id	65974398	65974398
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1748004899	1748004899

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 3 metrics, 7 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:loop	worse [+224.775µs; +322.455µs] or [+2.253%; +3.233%]	worse [+235.554µs; +348.871µs] or [+2.329%; +3.449%]	worse [+236.008µs; +389.447µs] or [+2.311%; +3.814%]	worse [+190.858µs; +555.083µs] or [+1.821%; +5.296%]	worse [-4.000op/s; -1.548op/s] or [-4.100%; -1.587%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-21.400µs; +72.436µs] or [-7.910%; +26.775%]	unstable [-29.625µs; +92.646µs] or [-9.537%; +29.824%]	unstable [-37.022µs; +103.490µs] or [-11.398%; +31.861%]	unstable [-324.017µs; +1062.762µs] or [-35.217%; +115.509%]	same
scenario:basic	same	same	unstable [-13.255µs; +28.663µs] or [-4.065%; +8.790%]	unstable [-192.005µs; +526.874µs] or [-22.571%; +61.937%]	unstable [-233.433op/s; +117.289op/s] or [-9.571%; +4.809%]

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (310.638 µs) : 282, 340
.   : milestone, 311,
basic (315.531 µs) : 307, 324
.   : milestone, 316,
loop (10.114 ms) : 10087, 10142
.   : milestone, 10114,
section candidate
noprobe (342.148 µs) : 265, 419
.   : milestone, 342,
basic (319.454 µs) : 301, 338
.   : milestone, 319,
loop (10.407 ms) : 10337, 10476
.   : milestone, 10407,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	310.638 µs [281.56 µs, 339.716 µs]
basic	315.531 µs [307.168 µs, 323.895 µs]
loop	10.114 ms [10.087 ms, 10.142 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	342.148 µs [265.143 µs, 419.154 µs]
basic	319.454 µs [301.145 µs, 337.762 µs]
loop	10.407 ms [10.337 ms, 10.476 ms]

pr-commenter · 2025-05-23T13:21:55Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-filter-set-support
git_commit_date	1746789389	1748242483
git_commit_sha	`ad6d5fe`	`b905edc`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~b905edc725

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1748244866	1748244866
ci_job_id	953572278	953572278
ci_pipeline_id	66078604	66078604
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-dtsgutkg-project-304-concurrent-0-bdi6k6zh 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-dtsgutkg-project-304-concurrent-0-bdi6k6zh 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 3 performance improvements and 2 performance regressions! Performance is the same for 51 metrics, 15 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:profiling:ProfilingAgent	better [-9.953ms; -4.771ms] or [-8.976%; -4.303%]	103.514ms	110.876ms
scenario:startup:petclinic:profiling:GlobalTracer	better [-23.992ms; -15.501ms] or [-6.319%; -4.083%]	359.932ms	379.678ms
scenario:startup:petclinic:profiling:AppSec	worse [+5.630ms; +9.089ms] or [+10.284%; +16.600%]	62.109ms	54.750ms
scenario:startup:petclinic:profiling:Profiling	better [-9.954ms; -4.773ms] or [-8.976%; -4.303%]	103.538ms	110.901ms
scenario:startup:petclinic:tracing:Remote Config	worse [+26.015µs; +76.632µs] or [+3.842%; +11.317%]	728.457µs	677.134µs

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~b905edc725, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018127
Total [baseline] (10.467 s) : 0, 10467224
Agent [candidate] (1.029 s) : 0, 1028893
Total [candidate] (10.551 s) : 0, 10550816
section appsec
Agent [baseline] (1.172 s) : 0, 1171771
Total [baseline] (10.744 s) : 0, 10743590
Agent [candidate] (1.163 s) : 0, 1163256
Total [candidate] (10.774 s) : 0, 10774258
section iast
Agent [baseline] (1.147 s) : 0, 1147103
Total [baseline] (10.838 s) : 0, 10838273
Agent [candidate] (1.16 s) : 0, 1160445
Total [candidate] (10.899 s) : 0, 10899061
section profiling
Agent [baseline] (1.288 s) : 0, 1288422
Total [baseline] (10.91 s) : 0, 10909907
Agent [candidate] (1.266 s) : 0, 1266063
Total [candidate] (10.82 s) : 0, 10819734

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.018 s	-
Agent	appsec	1.172 s	153.644 ms (15.1%)
Agent	iast	1.147 s	128.976 ms (12.7%)
Agent	profiling	1.288 s	270.295 ms (26.5%)
Total	tracing	10.467 s	-
Total	appsec	10.744 s	276.366 ms (2.6%)
Total	iast	10.838 s	371.049 ms (3.5%)
Total	profiling	10.91 s	442.683 ms (4.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.029 s	-
Agent	appsec	1.163 s	134.363 ms (13.1%)
Agent	iast	1.16 s	131.552 ms (12.8%)
Agent	profiling	1.266 s	237.17 ms (23.1%)
Total	tracing	10.551 s	-
Total	appsec	10.774 s	223.441 ms (2.1%)
Total	iast	10.899 s	348.245 ms (3.3%)
Total	profiling	10.82 s	268.918 ms (2.5%)

gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~b905edc725, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.331 ms) : 0, 681331
BytebuddyAgent [candidate] (688.557 ms) : 0, 688557
GlobalTracer [baseline] (240.185 ms) : 0, 240185
GlobalTracer [candidate] (242.341 ms) : 0, 242341
AppSec [baseline] (55.122 ms) : 0, 55122
AppSec [candidate] (55.835 ms) : 0, 55835
Debugger [baseline] (8.32 ms) : 0, 8320
Debugger [candidate] (8.54 ms) : 0, 8540
Remote Config [baseline] (677.134 µs) : 0, 677
Remote Config [candidate] (728.457 µs) : 0, 728
Telemetry [baseline] (9.01 ms) : 0, 9010
Telemetry [candidate] (9.176 ms) : 0, 9176
section appsec
BytebuddyAgent [baseline] (706.658 ms) : 0, 706658
BytebuddyAgent [candidate] (701.521 ms) : 0, 701521
GlobalTracer [baseline] (239.192 ms) : 0, 239192
GlobalTracer [candidate] (237.043 ms) : 0, 237043
AppSec [baseline] (176.445 ms) : 0, 176445
AppSec [candidate] (175.498 ms) : 0, 175498
Debugger [baseline] (6.002 ms) : 0, 6002
Debugger [candidate] (6.351 ms) : 0, 6351
Remote Config [baseline] (633.249 µs) : 0, 633
Remote Config [candidate] (624.875 µs) : 0, 625
Telemetry [baseline] (8.265 ms) : 0, 8265
Telemetry [candidate] (7.773 ms) : 0, 7773
IAST [baseline] (21.672 ms) : 0, 21672
IAST [candidate] (21.678 ms) : 0, 21678
section iast
BytebuddyAgent [baseline] (800.87 ms) : 0, 800870
BytebuddyAgent [candidate] (810.573 ms) : 0, 810573
GlobalTracer [baseline] (229.7 ms) : 0, 229700
GlobalTracer [candidate] (232.65 ms) : 0, 232650
AppSec [baseline] (54.385 ms) : 0, 54385
AppSec [candidate] (51.306 ms) : 0, 51306
Debugger [baseline] (5.881 ms) : 0, 5881
Debugger [candidate] (5.891 ms) : 0, 5891
Remote Config [baseline] (600.296 µs) : 0, 600
Remote Config [candidate] (579.863 µs) : 0, 580
Telemetry [baseline] (7.839 ms) : 0, 7839
Telemetry [candidate] (7.909 ms) : 0, 7909
IAST [baseline] (23.524 ms) : 0, 23524
IAST [candidate] (27.828 ms) : 0, 27828
section profiling
BytebuddyAgent [baseline] (677.336 ms) : 0, 677336
BytebuddyAgent [candidate] (674.347 ms) : 0, 674347
GlobalTracer [baseline] (379.678 ms) : 0, 379678
GlobalTracer [candidate] (359.932 ms) : 0, 359932
AppSec [baseline] (54.75 ms) : 0, 54750
AppSec [candidate] (62.109 ms) : 0, 62109
Debugger [baseline] (6.139 ms) : 0, 6139
Debugger [candidate] (6.299 ms) : 0, 6299
Remote Config [baseline] (670.886 µs) : 0, 671
Remote Config [candidate] (663.183 µs) : 0, 663
Telemetry [baseline] (8.164 ms) : 0, 8164
Telemetry [candidate] (8.263 ms) : 0, 8263
ProfilingAgent [baseline] (110.876 ms) : 0, 110876
ProfilingAgent [candidate] (103.514 ms) : 0, 103514
Profiling [baseline] (110.901 ms) : 0, 110901
Profiling [candidate] (103.538 ms) : 0, 103538

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~b905edc725, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1022978
Total [baseline] (8.655 s) : 0, 8654586
Agent [candidate] (1.029 s) : 0, 1029389
Total [candidate] (8.739 s) : 0, 8738678
section iast
Agent [baseline] (1.154 s) : 0, 1154024
Total [baseline] (9.261 s) : 0, 9261376
Agent [candidate] (1.154 s) : 0, 1153788
Total [candidate] (9.247 s) : 0, 9246720
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.155 s) : 0, 1155486
Total [baseline] (9.219 s) : 0, 9218889
Agent [candidate] (1.157 s) : 0, 1156540
Total [candidate] (9.224 s) : 0, 9224282
section iast_TELEMETRY_OFF
Agent [baseline] (1.15 s) : 0, 1150059
Total [baseline] (9.237 s) : 0, 9237445
Agent [candidate] (1.163 s) : 0, 1163138
Total [candidate] (9.332 s) : 0, 9331875

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.023 s	-
Agent	iast	1.154 s	131.046 ms (12.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.155 s	132.508 ms (13.0%)
Agent	iast_TELEMETRY_OFF	1.15 s	127.081 ms (12.4%)
Total	tracing	8.655 s	-
Total	iast	9.261 s	606.79 ms (7.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.219 s	564.303 ms (6.5%)
Total	iast_TELEMETRY_OFF	9.237 s	582.859 ms (6.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.029 s	-
Agent	iast	1.154 s	124.399 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.157 s	127.151 ms (12.4%)
Agent	iast_TELEMETRY_OFF	1.163 s	133.749 ms (13.0%)
Total	tracing	8.739 s	-
Total	iast	9.247 s	508.042 ms (5.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.224 s	485.603 ms (5.6%)
Total	iast_TELEMETRY_OFF	9.332 s	593.197 ms (6.8%)

gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~b905edc725, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.724 ms) : 0, 684724
BytebuddyAgent [candidate] (688.694 ms) : 0, 688694
GlobalTracer [baseline] (240.576 ms) : 0, 240576
GlobalTracer [candidate] (242.457 ms) : 0, 242457
AppSec [baseline] (54.433 ms) : 0, 54433
AppSec [candidate] (56.925 ms) : 0, 56925
Debugger [baseline] (8.375 ms) : 0, 8375
Debugger [candidate] (8.37 ms) : 0, 8370
Remote Config [baseline] (706.958 µs) : 0, 707
Remote Config [candidate] (714.328 µs) : 0, 714
Telemetry [baseline] (10.603 ms) : 0, 10603
Telemetry [candidate] (8.463 ms) : 0, 8463
section iast
BytebuddyAgent [baseline] (806.019 ms) : 0, 806019
BytebuddyAgent [candidate] (806.532 ms) : 0, 806532
GlobalTracer [baseline] (231.158 ms) : 0, 231158
GlobalTracer [candidate] (230.793 ms) : 0, 230793
AppSec [baseline] (49.554 ms) : 0, 49554
AppSec [candidate] (52.683 ms) : 0, 52683
Debugger [baseline] (5.903 ms) : 0, 5903
Debugger [candidate] (5.912 ms) : 0, 5912
Remote Config [baseline] (603.368 µs) : 0, 603
Remote Config [candidate] (597.257 µs) : 0, 597
Telemetry [baseline] (7.924 ms) : 0, 7924
Telemetry [candidate] (7.82 ms) : 0, 7820
IAST [baseline] (29.306 ms) : 0, 29306
IAST [candidate] (25.85 ms) : 0, 25850
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.041 ms) : 0, 807041
BytebuddyAgent [candidate] (806.807 ms) : 0, 806807
GlobalTracer [baseline] (231.354 ms) : 0, 231354
GlobalTracer [candidate] (232.451 ms) : 0, 232451
AppSec [baseline] (50.494 ms) : 0, 50494
AppSec [candidate] (51.327 ms) : 0, 51327
Debugger [baseline] (5.954 ms) : 0, 5954
Debugger [candidate] (5.954 ms) : 0, 5954
Remote Config [baseline] (596.573 µs) : 0, 597
Remote Config [candidate] (599.117 µs) : 0, 599
Telemetry [baseline] (7.944 ms) : 0, 7944
Telemetry [candidate] (8.001 ms) : 0, 8001
IAST [baseline] (28.481 ms) : 0, 28481
IAST [candidate] (27.728 ms) : 0, 27728
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (802.738 ms) : 0, 802738
BytebuddyAgent [candidate] (812.557 ms) : 0, 812557
GlobalTracer [baseline] (231.5 ms) : 0, 231500
GlobalTracer [candidate] (232.824 ms) : 0, 232824
AppSec [baseline] (55.532 ms) : 0, 55532
AppSec [candidate] (54.859 ms) : 0, 54859
Debugger [baseline] (5.93 ms) : 0, 5930
Debugger [candidate] (6.071 ms) : 0, 6071
Remote Config [baseline] (598.655 µs) : 0, 599
Remote Config [candidate] (628.546 µs) : 0, 629
Telemetry [baseline] (7.752 ms) : 0, 7752
Telemetry [candidate] (7.967 ms) : 0, 7967
IAST [baseline] (22.435 ms) : 0, 22435
IAST [candidate] (24.252 ms) : 0, 24252

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-05-26T07:04:44	2025-05-26T07:12:28
git_branch	master	jpbempel/fix-filter-set-support
git_commit_date	1746789389	1748242483
git_commit_sha	`ad6d5fe`	`b905edc`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~b905edc725
start_time	2025-05-26T07:04:29	2025-05-26T07:12:13

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1748243947	1748243947
ci_job_id	953572279	953572279
ci_pipeline_id	66078604	66078604
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-qshkhgbg-project-304-concurrent-0-69i6d2y1 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-qshkhgbg-project-304-concurrent-0-69i6d2y1 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~b905edc725, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.743 µs) : 362, 405
.   : milestone, 384,
iast (531.36 µs) : 508, 555
.   : milestone, 531,
iast_FULL (735.445 µs) : 713, 757
.   : milestone, 735,
iast_GLOBAL (574.134 µs) : 552, 596
.   : milestone, 574,
iast_HARDCODED_SECRET_DISABLED (514.4 µs) : 491, 538
.   : milestone, 514,
iast_INACTIVE (467.23 µs) : 445, 489
.   : milestone, 467,
iast_TELEMETRY_OFF (513.527 µs) : 491, 536
.   : milestone, 514,
tracing (463.431 µs) : 442, 485
.   : milestone, 463,
section candidate
no_agent (388.924 µs) : 369, 409
.   : milestone, 389,
iast (526.388 µs) : 504, 549
.   : milestone, 526,
iast_FULL (734.307 µs) : 712, 756
.   : milestone, 734,
iast_GLOBAL (567.23 µs) : 545, 589
.   : milestone, 567,
iast_HARDCODED_SECRET_DISABLED (523.472 µs) : 501, 546
.   : milestone, 523,
iast_INACTIVE (465.963 µs) : 445, 487
.   : milestone, 466,
iast_TELEMETRY_OFF (514.968 µs) : 491, 539
.   : milestone, 515,
tracing (458.704 µs) : 437, 481
.   : milestone, 459,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	383.743 µs [362.194 µs, 405.291 µs]	-
iast	531.36 µs [507.947 µs, 554.774 µs]	147.618 µs (38.5%)
iast_FULL	735.445 µs [713.487 µs, 757.402 µs]	351.702 µs (91.7%)
iast_GLOBAL	574.134 µs [552.311 µs, 595.958 µs]	190.392 µs (49.6%)
iast_HARDCODED_SECRET_DISABLED	514.4 µs [491.277 µs, 537.523 µs]	130.657 µs (34.0%)
iast_INACTIVE	467.23 µs [445.484 µs, 488.975 µs]	83.487 µs (21.8%)
iast_TELEMETRY_OFF	513.527 µs [490.705 µs, 536.349 µs]	129.785 µs (33.8%)
tracing	463.431 µs [441.759 µs, 485.103 µs]	79.689 µs (20.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	388.924 µs [369.228 µs, 408.621 µs]	-
iast	526.388 µs [504.099 µs, 548.678 µs]	137.464 µs (35.3%)
iast_FULL	734.307 µs [712.231 µs, 756.383 µs]	345.383 µs (88.8%)
iast_GLOBAL	567.23 µs [545.052 µs, 589.409 µs]	178.306 µs (45.8%)
iast_HARDCODED_SECRET_DISABLED	523.472 µs [500.586 µs, 546.359 µs]	134.548 µs (34.6%)
iast_INACTIVE	465.963 µs [444.568 µs, 487.359 µs]	77.039 µs (19.8%)
iast_TELEMETRY_OFF	514.968 µs [491.162 µs, 538.774 µs]	126.044 µs (32.4%)
tracing	458.704 µs [436.724 µs, 480.683 µs]	69.78 µs (17.9%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~b905edc725, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.365 ms) : 1345, 1385
.   : milestone, 1365,
appsec (1.746 ms) : 1723, 1769
.   : milestone, 1746,
appsec_no_iast (1.727 ms) : 1704, 1750
.   : milestone, 1727,
code_origins (1.662 ms) : 1636, 1688
.   : milestone, 1662,
iast (1.531 ms) : 1507, 1554
.   : milestone, 1531,
profiling (1.502 ms) : 1479, 1525
.   : milestone, 1502,
tracing (1.477 ms) : 1454, 1500
.   : milestone, 1477,
section candidate
no_agent (1.355 ms) : 1336, 1375
.   : milestone, 1355,
appsec (1.741 ms) : 1717, 1766
.   : milestone, 1741,
appsec_no_iast (1.738 ms) : 1715, 1761
.   : milestone, 1738,
code_origins (1.664 ms) : 1637, 1691
.   : milestone, 1664,
iast (1.512 ms) : 1488, 1536
.   : milestone, 1512,
profiling (1.529 ms) : 1506, 1552
.   : milestone, 1529,
tracing (1.489 ms) : 1464, 1513
.   : milestone, 1489,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.365 ms [1.345 ms, 1.385 ms]	-
appsec	1.746 ms [1.723 ms, 1.769 ms]	381.437 µs (27.9%)
appsec_no_iast	1.727 ms [1.704 ms, 1.75 ms]	362.079 µs (26.5%)
code_origins	1.662 ms [1.636 ms, 1.688 ms]	297.252 µs (21.8%)
iast	1.531 ms [1.507 ms, 1.554 ms]	165.761 µs (12.1%)
profiling	1.502 ms [1.479 ms, 1.525 ms]	136.878 µs (10.0%)
tracing	1.477 ms [1.454 ms, 1.5 ms]	111.931 µs (8.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.336 ms, 1.375 ms]	-
appsec	1.741 ms [1.717 ms, 1.766 ms]	386.401 µs (28.5%)
appsec_no_iast	1.738 ms [1.715 ms, 1.761 ms]	383.212 µs (28.3%)
code_origins	1.664 ms [1.637 ms, 1.691 ms]	308.718 µs (22.8%)
iast	1.512 ms [1.488 ms, 1.536 ms]	157.103 µs (11.6%)
profiling	1.529 ms [1.506 ms, 1.552 ms]	174.32 µs (12.9%)
tracing	1.489 ms [1.464 ms, 1.513 ms]	133.782 µs (9.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-filter-set-support
git_commit_date	1746789389	1748242483
git_commit_sha	`ad6d5fe`	`b905edc`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~b905edc725

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1748244457	1748244457
ci_job_id	953572280	953572280
ci_pipeline_id	66078604	66078604
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-snyqapa8-project-304-concurrent-0-fatjxxxn 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-snyqapa8-project-304-concurrent-0-fatjxxxn 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~b905edc725, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.467 s) : 15467000, 15467000
.   : milestone, 15467000,
appsec (15.131 s) : 15131000, 15131000
.   : milestone, 15131000,
iast (18.714 s) : 18714000, 18714000
.   : milestone, 18714000,
iast_GLOBAL (18.033 s) : 18033000, 18033000
.   : milestone, 18033000,
profiling (15.757 s) : 15757000, 15757000
.   : milestone, 15757000,
tracing (15.059 s) : 15059000, 15059000
.   : milestone, 15059000,
section candidate
no_agent (15.277 s) : 15277000, 15277000
.   : milestone, 15277000,
appsec (14.848 s) : 14848000, 14848000
.   : milestone, 14848000,
iast (18.622 s) : 18622000, 18622000
.   : milestone, 18622000,
iast_GLOBAL (18.38 s) : 18380000, 18380000
.   : milestone, 18380000,
profiling (15.128 s) : 15128000, 15128000
.   : milestone, 15128000,
tracing (14.896 s) : 14896000, 14896000
.   : milestone, 14896000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.467 s [15.467 s, 15.467 s]	-
appsec	15.131 s [15.131 s, 15.131 s]	-336.0 ms (-2.2%)
iast	18.714 s [18.714 s, 18.714 s]	3.247 s (21.0%)
iast_GLOBAL	18.033 s [18.033 s, 18.033 s]	2.566 s (16.6%)
profiling	15.757 s [15.757 s, 15.757 s]	290.0 ms (1.9%)
tracing	15.059 s [15.059 s, 15.059 s]	-408.0 ms (-2.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.277 s [15.277 s, 15.277 s]	-
appsec	14.848 s [14.848 s, 14.848 s]	-429.0 ms (-2.8%)
iast	18.622 s [18.622 s, 18.622 s]	3.345 s (21.9%)
iast_GLOBAL	18.38 s [18.38 s, 18.38 s]	3.103 s (20.3%)
profiling	15.128 s [15.128 s, 15.128 s]	-149.0 ms (-1.0%)
tracing	14.896 s [14.896 s, 14.896 s]	-381.0 ms (-2.5%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~b905edc725, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (2.409 ms) : 2360, 2457
.   : milestone, 2409,
iast (2.187 ms) : 2126, 2249
.   : milestone, 2187,
iast_GLOBAL (2.235 ms) : 2173, 2296
.   : milestone, 2235,
profiling (2.494 ms) : 2254, 2734
.   : milestone, 2494,
tracing (2.017 ms) : 1969, 2064
.   : milestone, 2017,
section candidate
no_agent (1.482 ms) : 1471, 1494
.   : milestone, 1482,
appsec (2.408 ms) : 2360, 2457
.   : milestone, 2408,
iast (2.193 ms) : 2132, 2254
.   : milestone, 2193,
iast_GLOBAL (2.238 ms) : 2177, 2300
.   : milestone, 2238,
profiling (2.034 ms) : 1985, 2083
.   : milestone, 2034,
tracing (2.034 ms) : 1986, 2082
.   : milestone, 2034,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.467 ms, 1.49 ms]	-
appsec	2.409 ms [2.36 ms, 2.457 ms]	930.268 µs (62.9%)
iast	2.187 ms [2.126 ms, 2.249 ms]	708.721 µs (47.9%)
iast_GLOBAL	2.235 ms [2.173 ms, 2.296 ms]	756.104 µs (51.1%)
profiling	2.494 ms [2.254 ms, 2.734 ms]	1.016 ms (68.7%)
tracing	2.017 ms [1.969 ms, 2.064 ms]	538.315 µs (36.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.482 ms [1.471 ms, 1.494 ms]	-
appsec	2.408 ms [2.36 ms, 2.457 ms]	925.723 µs (62.4%)
iast	2.193 ms [2.132 ms, 2.254 ms]	710.697 µs (47.9%)
iast_GLOBAL	2.238 ms [2.177 ms, 2.3 ms]	755.689 µs (51.0%)
profiling	2.034 ms [1.985 ms, 2.083 ms]	551.705 µs (37.2%)
tracing	2.034 ms [1.986 ms, 2.082 ms]	551.297 µs (37.2%)

evanchooly

lgtm. my only real thought is that we could reduce some code by working with interfaces like CollectionValue and Collection so that List and Set are handled with the same code with the exception of the index-centered bits since sets don't have a positional concept.

also refactor the check for supported collection and maps add unit tests

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.49.0` -> `1.50.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.50.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.0): 1.50.0 ### Deprecation Notice > \[!NOTE] > `DD_RUNTIME_ID_ENABLED` has been deprecated and will be removed in future releases. Please use `DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED` instead. ### Components #### Application Security Management (WAF) - 🐛 Add String length truncation limit to ObjectIntrospector and update truncation metrics ([#8825](DataDog/dd-trace-java#8825) - [@jandro996](https://github.com/jandro996)) - 🐛 Adapt standalone ASM to support API Security ([#8804](DataDog/dd-trace-java#8804) - [@jandro996](https://github.com/jandro996)) - ✨ Add appsec.waf.input\_truncated metric ([#8791](DataDog/dd-trace-java#8791) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request body collection ([#8748](DataDog/dd-trace-java#8748) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request/response headers collection ([#8724](DataDog/dd-trace-java#8724) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - ✨ Add artifacts to public s3 bucket ([#8947](DataDog/dd-trace-java#8947) - [@randomanderson](https://github.com/randomanderson)) #### Continuous Integration Visibility - ✨ Improve PR information building ([#8908](DataDog/dd-trace-java#8908) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Truncate span stack traces when Test Optimization is enabled ([#8903](DataDog/dd-trace-java#8903) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Ensure auto-detected service name is the same for every process in the same build ([#8902](DataDog/dd-trace-java#8902) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Use tag as fallback in api requests if no branch is available ([#8876](DataDog/dd-trace-java#8876) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add support for JUnit 5.13-RC1 ([#8865](DataDog/dd-trace-java#8865), [#8871](DataDog/dd-trace-java#8871) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement attempt to fix v3 and v4 and bump capability version ([#8824](DataDog/dd-trace-java#8824) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🧹 Align retry logic for all test framework instrumentations ([#8803](DataDog/dd-trace-java#8803) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Always build ci workspace without trailing separator ([#8788](DataDog/dd-trace-java#8788) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add commit discrepancies telemetry when building repository git information ([#8763](DataDog/dd-trace-java#8763) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 💡 Surface process tags in dsm payloads and use them for base hash calculation ([#8836](DataDog/dd-trace-java#8836) - [@amarziali](https://github.com/amarziali)) #### Dynamic Instrumentation - ✨ Optimized allocations for collection filter functions ([#8896](DataDog/dd-trace-java#8896) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix SymDB upload size check ([#8887](DataDog/dd-trace-java#8887) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for Set in filter function ([#8873](DataDog/dd-trace-java#8873) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for isDefined in log template ([#8859](DataDog/dd-trace-java#8859) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix Max captured frames for Exception Replay ([#8856](DataDog/dd-trace-java#8856) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Remove static inherited fields collection ([#8832](DataDog/dd-trace-java#8832) - [@jpbempel](https://github.com/jpbempel)) - 💡 Add process tags to dynamic instrumentation intake payload ([#8779](DataDog/dd-trace-java#8779) - [@amarziali](https://github.com/amarziali)) #### GraalVM native-image - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) - ✨ Add JMXFetch support for GraalVM Native ([#8569](DataDog/dd-trace-java#8569) - [@ygree](https://github.com/ygree)) #### JMX fetch - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) #### Library Injection - ✨ Deny oracle db jvm based tools ([#8909](DataDog/dd-trace-java#8909) - [@bric3](https://github.com/bric3)) #### OpenTracing - 🐛 Fix OT packaging for exception replay ([#8912](DataDog/dd-trace-java#8912) - [@jpbempel](https://github.com/jpbempel)) #### Profiling - ✨ Bump ddprof to 1.27.0 ([#8893](DataDog/dd-trace-java#8893) - [@jbachorik](https://github.com/jbachorik)) - Properly handle the adaptive sampling interval overflow by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#213 - Fix [#200](DataDog/dd-trace-java#200) Crash related to aligned\_alloc and free in context by [@yanglong1010](https://github.com/yanglong1010) in DataDog/java-profiler#208 - Explicitly initialize empty context page by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#210 - Re-connect crash recursion protection with VM stackwalker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#214 - ✨ Enable ZSTD compression for profiling ([#8862](DataDog/dd-trace-java#8862) - [@MattAlp](https://github.com/MattAlp)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - 💡 Collect process tags for profiling upload requests ([#8780](DataDog/dd-trace-java#8780) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 💡 Surface process tags on telemetry payloads ([#8837](DataDog/dd-trace-java#8837) - [@amarziali](https://github.com/amarziali)) #### Trace context propagation - ✨ Migrating all HttpClient Instrumentations to Inject Full Context ([#8826](DataDog/dd-trace-java#8826) - [@mhlidd](https://github.com/mhlidd)) - ✨ Migrating all HttpServer Instrumentations to Extract full Context ([#8820](DataDog/dd-trace-java#8820) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - ✨⚡ Skip JAXB generated classes classloader ([#9003](DataDog/dd-trace-java#9003) - [@bric3](https://github.com/bric3)) - ✨ Add DD\_RUNTIME\_METRICS\_RUNTIME\_ID\_ENABLED alias for runtime id generation ([#8981](DataDog/dd-trace-java#8981) - [@amarziali](https://github.com/amarziali)) - 🐛 Use resolved address for peer.hostname when available without hitting the cache ([#8915](DataDog/dd-trace-java#8915) - [@amarziali](https://github.com/amarziali)) - 💡 Surface server name process tag for tomcat ([#8894](DataDog/dd-trace-java#8894) - [@amarziali](https://github.com/amarziali)) - 💡 Surface websphere cell and server name on process tags ([#8880](DataDog/dd-trace-java#8880) - [@amarziali](https://github.com/amarziali)) - ✨ Added special lightweight pre-main class that skips installation on incompatible JVMs. ([#8855](DataDog/dd-trace-java#8855) - [@AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add entrypoint type to process tags ([#8839](DataDog/dd-trace-java#8839) - [@amarziali](https://github.com/amarziali)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - ✨ Notify listeners when the scope top changes after switching scope stacks ([#8797](DataDog/dd-trace-java#8797) - [@mcculls](https://github.com/mcculls)) - ✨ Read hsperfdata for Java PIDs if jvmstat is unavailable ([#8792](DataDog/dd-trace-java#8792) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Turn JDK socket support on by default ([#8752](DataDog/dd-trace-java#8752) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Simplify context propagation ([#8719](DataDog/dd-trace-java#8719) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Add JSON parsing support ([#8579](DataDog/dd-trace-java#8579) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer internal logging - ✨ Fix printing format of span identifiers ([#8897](DataDog/dd-trace-java#8897) - [@vandonr](https://github.com/vandonr)) #### Tracer public API - 💡 Track the source of installation ([#8956](DataDog/dd-trace-java#8956) - [@mabdinur](https://github.com/mabdinur)) - ✨ Enforce size limit on application\_monitoring.yaml files ([#8789](DataDog/dd-trace-java#8789) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Enabling baggage cache to support limits and non-ascii characters ([#8713](DataDog/dd-trace-java#8713) - [@mhlidd](https://github.com/mhlidd)) ### Instrumentations #### AWS Lambda instrumentation - ✨ Pass Lambda Request ID to Extension ([#8814](DataDog/dd-trace-java#8814) - [@nhulston](https://github.com/nhulston)) #### Core Java language instrumentation - ✨ Ensure ClassloadingInstrumentation is always applied even with `DD_TRACE_ENABLED=false` ([#8863](DataDog/dd-trace-java#8863) - [@mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - 🐛 Do not override route with / in vertx instrumentation ([#8881](DataDog/dd-trace-java#8881) - [@vandonr](https://github.com/vandonr)) #### IBM Liberty - 🐛 Fix error mark on http status for IBM liberty ([#8822](DataDog/dd-trace-java#8822) - [@amarziali](https://github.com/amarziali)) #### JDBC instrumentation - 🐛 Do not prepend DBM <> APM trace comment in SQLCommenter if there is a pg plan hint ([#8864](DataDog/dd-trace-java#8864) - [@edengorevoy](https://github.com/edengorevoy)) #### JMS instrumentation - ✨ Add jms as an extra integration name where there is JMS involved ([#8933](DataDog/dd-trace-java#8933) - [@vandonr](https://github.com/vandonr)) #### Kotlin instrumentation - ✨ Enable kotlin\_coroutine integration by default ([#8848](DataDog/dd-trace-java#8848) - [@mcculls](https://github.com/mcculls)) - 🧹 Rework Kotlin coroutines instrumentation around coroutine context ([#8774](DataDog/dd-trace-java#8774) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Support WithSpan inheritContext attribute ([#8858](DataDog/dd-trace-java#8858) - [@amarziali](https://github.com/amarziali)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Play Framework instrumentation - 🐛 Fix the Play Framework's span resource name priority so that the client JAX-RS 404 cannot override it ([#8591](DataDog/dd-trace-java#8591) - [@ygree](https://github.com/ygree)) #### Quarkus Instrumentation - 🐛 Ignore quarkus jaxrs stubs and cdi wrapper proxies ([#8891](DataDog/dd-trace-java#8891) - [@amarziali](https://github.com/amarziali)) #### ServiceTalk - ✨ Improve ServiceTalk Captured Context API Instrumentation for v0.42.56+ ([#8821](DataDog/dd-trace-java#8821) - [@ygree](https://github.com/ygree)) #### Spring instrumentation - ✨ Supporting Baggage for Instrumentations used in Weblog Tests ([#8773](DataDog/dd-trace-java#8773) - [@mhlidd](https://github.com/mhlidd)) #### WebSocket Instrumentation - 💡 Trace websocket for spring webflux reactive handlers ([#8831](DataDog/dd-trace-java#8831) - [@amarziali](https://github.com/amarziali)) - 💡:test\_tube: WebSocket support for Netty ([#8632](DataDog/dd-trace-java#8632) - [@ValentinZakharov](https://github.com/ValentinZakharov)) #### Zio Instrumentation - 🧹 Cleanup Zio fiber instrumentation to avoid repeated activation of continuation ([#8798](DataDog/dd-trace-java#8798) - [@mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9207366cdb6a1bd098082305d354a0a3c4622d7a

jpbempel requested a review from a team as a code owner May 23, 2025 12:57

jpbempel added type: bug comp: debugger Dynamic Instrumentation labels May 23, 2025

jpbempel requested review from shatzi and removed request for a team May 23, 2025 12:57

evanchooly approved these changes May 23, 2025

View reviewed changes

Add support for Set in filter function

b905edc

also refactor the check for supported collection and maps add unit tests

jpbempel force-pushed the jpbempel/fix-filter-set-support branch from 058f41c to b905edc Compare May 26, 2025 06:54

jpbempel merged commit 7d25eca into master May 26, 2025
348 of 353 checks passed

jpbempel deleted the jpbempel/fix-filter-set-support branch May 26, 2025 09:32

github-actions bot added this to the 1.50.0 milestone May 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for Set in filter function #8873

Add support for Set in filter function #8873

Uh oh!

jpbempel commented May 23, 2025 •

edited by jira bot

Loading

Uh oh!

pr-commenter bot commented May 23, 2025

Uh oh!

pr-commenter bot commented May 23, 2025 •

edited

Loading

Uh oh!

evanchooly left a comment

Uh oh!

Uh oh!

Uh oh!

Add support for Set in filter function #8873

Add support for Set in filter function #8873

Uh oh!

Conversation

jpbempel commented May 23, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented May 23, 2025

Debugger benchmarks

Parameters

Summary

Uh oh!

pr-commenter bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

evanchooly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jpbempel commented May 23, 2025 •

edited by jira bot

Loading

pr-commenter bot commented May 23, 2025 •

edited

Loading