Fix SymDB upload size check #8887

jpbempel · 2025-05-26T14:46:41Z

What Does This Do

First compress the upload and then check the compressed size against the maximum upload size. If above the limit, split by jar or scope and try again compressed
Add it.unimi.dsi.fastutil as third-party libraries

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3942

First compress the upload and then check the compressed size against the maximum upload size. If above the limit, split by jar or scope and try again compressed Add it.unimi.dsi.fastutil as third-party libraries

pr-commenter · 2025-05-26T15:09:37Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1748271419	1748271801
end_time	2025-05-26T14:58:20	2025-05-26T15:04:41
git_branch	master	jpbempel/fix-symdb-compress-check
git_commit_sha	`ad6d5fe`	`12d7353`
start_time	2025-05-26T14:57:00	2025-05-26T15:03:22

See matching parameters

	Baseline	Candidate
ci_job_id	954333837	954333837
ci_pipeline_id	66122599	66122599
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1748270695	1748270695

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-16.328µs; +23.945µs] or [-5.989%; +8.782%]	unstable [-28.295µs; +32.766µs] or [-9.008%; +10.431%]	unstable [-37.757µs; +47.888µs] or [-11.529%; +14.623%]	unstable [-187.028µs; +59.988µs] or [-18.121%; +5.812%]	same
scenario:basic	same	same	same	unstable [-163.805µs; +98.414µs] or [-18.824%; +11.309%]	unstable [-227.467op/s; +111.323op/s] or [-9.326%; +4.564%]
scenario:loop	same	same	same	same	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (314.113 µs) : 291, 337
.   : milestone, 314,
basic (313.476 µs) : 303, 324
.   : milestone, 313,
loop (10.812 ms) : 10788, 10836
.   : milestone, 10812,
section candidate
noprobe (316.349 µs) : 282, 350
.   : milestone, 316,
basic (317.011 µs) : 309, 325
.   : milestone, 317,
loop (10.81 ms) : 10775, 10846
.   : milestone, 10810,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	314.113 µs [291.028 µs, 337.198 µs]
basic	313.476 µs [303.429 µs, 323.523 µs]
loop	10.812 ms [10.788 ms, 10.836 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	316.349 µs [282.331 µs, 350.367 µs]
basic	317.011 µs [309.029 µs, 324.994 µs]
loop	10.81 ms [10.775 ms, 10.846 ms]

pr-commenter · 2025-05-26T15:26:09Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-symdb-compress-check
git_commit_date	1746789389	1748270695
git_commit_sha	`ad6d5fe`	`12d7353`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~12d73538a0

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1748273119	1748273119
ci_job_id	954333819	954333819
ci_pipeline_id	66122599	66122599
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-8t2n4jps-project-304-concurrent-1-ndvs11y9 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-8t2n4jps-project-304-concurrent-1-ndvs11y9 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 3 performance improvements and 1 performance regressions! Performance is the same for 54 metrics, 13 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:profiling:ProfilingAgent	better [-8.313ms; -4.976ms] or [-7.611%; -4.556%]	102.573ms	109.217ms
scenario:startup:petclinic:profiling:GlobalTracer	better [-20.102ms; -16.519ms] or [-5.319%; -4.371%]	359.631ms	377.941ms
scenario:startup:petclinic:profiling:AppSec	worse [+5.572ms; +8.799ms] or [+10.225%; +16.145%]	61.683ms	54.498ms
scenario:startup:petclinic:profiling:Profiling	better [-8.316ms; -4.979ms] or [-7.612%; -4.558%]	102.596ms	109.244ms

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~12d73538a0, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1023044
Total [baseline] (8.666 s) : 0, 8666037
Agent [candidate] (1.02 s) : 0, 1020077
Total [candidate] (8.643 s) : 0, 8642707
section iast
Agent [baseline] (1.15 s) : 0, 1149788
Total [baseline] (9.233 s) : 0, 9232752
Agent [candidate] (1.159 s) : 0, 1159235
Total [candidate] (9.237 s) : 0, 9236590
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.148 s) : 0, 1147826
Total [baseline] (9.249 s) : 0, 9249450
Agent [candidate] (1.149 s) : 0, 1148797
Total [candidate] (9.232 s) : 0, 9232098
section iast_TELEMETRY_OFF
Agent [baseline] (1.15 s) : 0, 1150494
Total [baseline] (9.24 s) : 0, 9239877
Agent [candidate] (1.153 s) : 0, 1152962
Total [candidate] (9.286 s) : 0, 9286214

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.023 s	-
Agent	iast	1.15 s	126.744 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.148 s	124.782 ms (12.2%)
Agent	iast_TELEMETRY_OFF	1.15 s	127.45 ms (12.5%)
Total	tracing	8.666 s	-
Total	iast	9.233 s	566.714 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.249 s	583.412 ms (6.7%)
Total	iast_TELEMETRY_OFF	9.24 s	573.84 ms (6.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.02 s	-
Agent	iast	1.159 s	139.158 ms (13.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.149 s	128.72 ms (12.6%)
Agent	iast_TELEMETRY_OFF	1.153 s	132.885 ms (13.0%)
Total	tracing	8.643 s	-
Total	iast	9.237 s	593.883 ms (6.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.232 s	589.391 ms (6.8%)
Total	iast_TELEMETRY_OFF	9.286 s	643.507 ms (7.4%)

gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~12d73538a0, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.819 ms) : 0, 683819
BytebuddyAgent [candidate] (682.21 ms) : 0, 682210
GlobalTracer [baseline] (240.653 ms) : 0, 240653
GlobalTracer [candidate] (240.416 ms) : 0, 240416
AppSec [baseline] (55.536 ms) : 0, 55536
AppSec [candidate] (54.44 ms) : 0, 54440
Debugger [baseline] (9.1 ms) : 0, 9100
Debugger [candidate] (9.812 ms) : 0, 9812
Remote Config [baseline] (701.748 µs) : 0, 702
Remote Config [candidate] (700.55 µs) : 0, 701
Telemetry [baseline] (9.712 ms) : 0, 9712
Telemetry [candidate] (8.983 ms) : 0, 8983
section iast
BytebuddyAgent [baseline] (802.434 ms) : 0, 802434
BytebuddyAgent [candidate] (809.389 ms) : 0, 809389
GlobalTracer [baseline] (230.661 ms) : 0, 230661
GlobalTracer [candidate] (232.65 ms) : 0, 232650
IAST [baseline] (28.351 ms) : 0, 28351
IAST [candidate] (28.335 ms) : 0, 28335
AppSec [baseline] (50.469 ms) : 0, 50469
AppSec [candidate] (50.672 ms) : 0, 50672
Debugger [baseline] (5.947 ms) : 0, 5947
Debugger [candidate] (5.974 ms) : 0, 5974
Remote Config [baseline] (596.879 µs) : 0, 597
Remote Config [candidate] (596.38 µs) : 0, 596
Telemetry [baseline] (7.93 ms) : 0, 7930
Telemetry [candidate] (7.917 ms) : 0, 7917
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.781 ms) : 0, 800781
BytebuddyAgent [candidate] (801.553 ms) : 0, 801553
GlobalTracer [baseline] (230.436 ms) : 0, 230436
GlobalTracer [candidate] (230.537 ms) : 0, 230537
IAST [baseline] (26.079 ms) : 0, 26079
IAST [candidate] (29.203 ms) : 0, 29203
AppSec [baseline] (52.653 ms) : 0, 52653
AppSec [candidate] (49.489 ms) : 0, 49489
Debugger [baseline] (5.887 ms) : 0, 5887
Debugger [candidate] (5.95 ms) : 0, 5950
Remote Config [baseline] (593.49 µs) : 0, 593
Remote Config [candidate] (592.373 µs) : 0, 592
Telemetry [baseline] (7.849 ms) : 0, 7849
Telemetry [candidate] (7.952 ms) : 0, 7952
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (802.949 ms) : 0, 802949
BytebuddyAgent [candidate] (804.423 ms) : 0, 804423
GlobalTracer [baseline] (231.186 ms) : 0, 231186
GlobalTracer [candidate] (231.719 ms) : 0, 231719
IAST [baseline] (24.134 ms) : 0, 24134
IAST [candidate] (23.184 ms) : 0, 23184
AppSec [baseline] (54.298 ms) : 0, 54298
AppSec [candidate] (55.512 ms) : 0, 55512
Debugger [baseline] (5.948 ms) : 0, 5948
Debugger [candidate] (6.019 ms) : 0, 6019
Remote Config [baseline] (599.021 µs) : 0, 599
Remote Config [candidate] (608.42 µs) : 0, 608
Telemetry [baseline] (7.842 ms) : 0, 7842
Telemetry [candidate] (7.849 ms) : 0, 7849

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~12d73538a0, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018611
Total [baseline] (10.512 s) : 0, 10512330
Agent [candidate] (1.021 s) : 0, 1020838
Total [candidate] (10.484 s) : 0, 10484022
section appsec
Agent [baseline] (1.164 s) : 0, 1164386
Total [baseline] (10.732 s) : 0, 10731877
Agent [candidate] (1.166 s) : 0, 1165707
Total [candidate] (10.703 s) : 0, 10702694
section iast
Agent [baseline] (1.157 s) : 0, 1157370
Total [baseline] (10.876 s) : 0, 10875889
Agent [candidate] (1.153 s) : 0, 1153330
Total [candidate] (10.897 s) : 0, 10896709
section profiling
Agent [baseline] (1.281 s) : 0, 1280633
Total [baseline] (10.884 s) : 0, 10884424
Agent [candidate] (1.263 s) : 0, 1263067
Total [candidate] (10.844 s) : 0, 10843553

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.019 s	-
Agent	appsec	1.164 s	145.775 ms (14.3%)
Agent	iast	1.157 s	138.76 ms (13.6%)
Agent	profiling	1.281 s	262.023 ms (25.7%)
Total	tracing	10.512 s	-
Total	appsec	10.732 s	219.547 ms (2.1%)
Total	iast	10.876 s	363.559 ms (3.5%)
Total	profiling	10.884 s	372.094 ms (3.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.021 s	-
Agent	appsec	1.166 s	144.869 ms (14.2%)
Agent	iast	1.153 s	132.493 ms (13.0%)
Agent	profiling	1.263 s	242.229 ms (23.7%)
Total	tracing	10.484 s	-
Total	appsec	10.703 s	218.672 ms (2.1%)
Total	iast	10.897 s	412.687 ms (3.9%)
Total	profiling	10.844 s	359.531 ms (3.4%)

gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~12d73538a0, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.227 ms) : 0, 684227
BytebuddyAgent [candidate] (683.306 ms) : 0, 683306
GlobalTracer [baseline] (240.26 ms) : 0, 240260
GlobalTracer [candidate] (240.576 ms) : 0, 240576
AppSec [baseline] (54.424 ms) : 0, 54424
AppSec [candidate] (54.569 ms) : 0, 54569
Debugger [baseline] (6.995 ms) : 0, 6995
Debugger [candidate] (8.928 ms) : 0, 8928
Remote Config [baseline] (707.22 µs) : 0, 707
Remote Config [candidate] (700.451 µs) : 0, 700
Telemetry [baseline] (8.359 ms) : 0, 8359
Telemetry [candidate] (9.081 ms) : 0, 9081
section appsec
BytebuddyAgent [baseline] (702.384 ms) : 0, 702384
BytebuddyAgent [candidate] (702.367 ms) : 0, 702367
GlobalTracer [baseline] (237.237 ms) : 0, 237237
GlobalTracer [candidate] (238.132 ms) : 0, 238132
AppSec [baseline] (176.215 ms) : 0, 176215
AppSec [candidate] (176.802 ms) : 0, 176802
Debugger [baseline] (5.984 ms) : 0, 5984
Debugger [candidate] (5.978 ms) : 0, 5978
Remote Config [baseline] (625.739 µs) : 0, 626
Remote Config [candidate] (633.08 µs) : 0, 633
Telemetry [baseline] (7.436 ms) : 0, 7436
Telemetry [candidate] (7.414 ms) : 0, 7414
IAST [baseline] (21.824 ms) : 0, 21824
IAST [candidate] (21.521 ms) : 0, 21521
section iast
BytebuddyAgent [baseline] (808.749 ms) : 0, 808749
BytebuddyAgent [candidate] (804.617 ms) : 0, 804617
GlobalTracer [baseline] (231.743 ms) : 0, 231743
GlobalTracer [candidate] (231.842 ms) : 0, 231842
AppSec [baseline] (48.774 ms) : 0, 48774
AppSec [candidate] (50.503 ms) : 0, 50503
Debugger [baseline] (5.956 ms) : 0, 5956
Debugger [candidate] (5.932 ms) : 0, 5932
Remote Config [baseline] (595.643 µs) : 0, 596
Remote Config [candidate] (600.321 µs) : 0, 600
Telemetry [baseline] (7.971 ms) : 0, 7971
Telemetry [candidate] (7.904 ms) : 0, 7904
IAST [baseline] (27.579 ms) : 0, 27579
IAST [candidate] (28.362 ms) : 0, 28362
section profiling
ProfilingAgent [baseline] (109.217 ms) : 0, 109217
ProfilingAgent [candidate] (102.573 ms) : 0, 102573
BytebuddyAgent [baseline] (673.557 ms) : 0, 673557
BytebuddyAgent [candidate] (673.245 ms) : 0, 673245
GlobalTracer [baseline] (377.941 ms) : 0, 377941
GlobalTracer [candidate] (359.631 ms) : 0, 359631
AppSec [baseline] (54.498 ms) : 0, 54498
AppSec [candidate] (61.683 ms) : 0, 61683
Debugger [baseline] (6.173 ms) : 0, 6173
Debugger [candidate] (6.27 ms) : 0, 6270
Remote Config [baseline] (660.005 µs) : 0, 660
Remote Config [candidate] (648.668 µs) : 0, 649
Telemetry [baseline] (8.092 ms) : 0, 8092
Telemetry [candidate] (8.091 ms) : 0, 8091
Profiling [baseline] (109.244 ms) : 0, 109244
Profiling [candidate] (102.596 ms) : 0, 102596

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-05-26T14:58:16	2025-05-26T15:06:03
git_branch	master	jpbempel/fix-symdb-compress-check
git_commit_date	1746789389	1748270695
git_commit_sha	`ad6d5fe`	`12d7353`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~12d73538a0
start_time	2025-05-26T14:58:01	2025-05-26T15:05:48

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1748272363	1748272363
ci_job_id	954333822	954333822
ci_pipeline_id	66122599	66122599
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-qshkhgbg-project-304-concurrent-0-6pwihvq6 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-qshkhgbg-project-304-concurrent-0-6pwihvq6 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-symdb-compress-check
git_commit_date	1746789389	1748270695
git_commit_sha	`ad6d5fe`	`12d7353`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~12d73538a0

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1748272785	1748272785
ci_job_id	954333824	954333824
ci_pipeline_id	66122599	66122599
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-dtsgutkg-project-304-concurrent-1-5p7odj6z 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-dtsgutkg-project-304-concurrent-1-5p7odj6z 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~12d73538a0, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1483
.   : milestone, 1472,
appsec (2.401 ms) : 2353, 2450
.   : milestone, 2401,
iast (2.168 ms) : 2107, 2229
.   : milestone, 2168,
iast_GLOBAL (2.22 ms) : 2158, 2282
.   : milestone, 2220,
profiling (2.02 ms) : 1971, 2069
.   : milestone, 2020,
tracing (1.994 ms) : 1947, 2041
.   : milestone, 1994,
section candidate
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.403 ms) : 2354, 2452
.   : milestone, 2403,
iast (2.175 ms) : 2114, 2237
.   : milestone, 2175,
iast_GLOBAL (2.227 ms) : 2165, 2289
.   : milestone, 2227,
profiling (2.02 ms) : 1971, 2069
.   : milestone, 2020,
tracing (1.994 ms) : 1946, 2041
.   : milestone, 1994,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.461 ms, 1.483 ms]	-
appsec	2.401 ms [2.353 ms, 2.45 ms]	929.316 µs (63.1%)
iast	2.168 ms [2.107 ms, 2.229 ms]	695.731 µs (47.3%)
iast_GLOBAL	2.22 ms [2.158 ms, 2.282 ms]	748.03 µs (50.8%)
profiling	2.02 ms [1.971 ms, 2.069 ms]	548.143 µs (37.2%)
tracing	1.994 ms [1.947 ms, 2.041 ms]	522.043 µs (35.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.465 ms, 1.488 ms]	-
appsec	2.403 ms [2.354 ms, 2.452 ms]	926.467 µs (62.8%)
iast	2.175 ms [2.114 ms, 2.237 ms]	699.117 µs (47.4%)
iast_GLOBAL	2.227 ms [2.165 ms, 2.289 ms]	750.635 µs (50.8%)
profiling	2.02 ms [1.971 ms, 2.069 ms]	543.776 µs (36.8%)
tracing	1.994 ms [1.946 ms, 2.041 ms]	517.41 µs (35.0%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~12d73538a0, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.012 s) : 15012000, 15012000
.   : milestone, 15012000,
appsec (14.984 s) : 14984000, 14984000
.   : milestone, 14984000,
iast (18.972 s) : 18972000, 18972000
.   : milestone, 18972000,
iast_GLOBAL (17.904 s) : 17904000, 17904000
.   : milestone, 17904000,
profiling (14.767 s) : 14767000, 14767000
.   : milestone, 14767000,
tracing (15.031 s) : 15031000, 15031000
.   : milestone, 15031000,
section candidate
no_agent (15.284 s) : 15284000, 15284000
.   : milestone, 15284000,
appsec (15.239 s) : 15239000, 15239000
.   : milestone, 15239000,
iast (18.77 s) : 18770000, 18770000
.   : milestone, 18770000,
iast_GLOBAL (18.029 s) : 18029000, 18029000
.   : milestone, 18029000,
profiling (15.144 s) : 15144000, 15144000
.   : milestone, 15144000,
tracing (15.193 s) : 15193000, 15193000
.   : milestone, 15193000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.012 s [15.012 s, 15.012 s]	-
appsec	14.984 s [14.984 s, 14.984 s]	-28.0 ms (-0.2%)
iast	18.972 s [18.972 s, 18.972 s]	3.96 s (26.4%)
iast_GLOBAL	17.904 s [17.904 s, 17.904 s]	2.892 s (19.3%)
profiling	14.767 s [14.767 s, 14.767 s]	-245.0 ms (-1.6%)
tracing	15.031 s [15.031 s, 15.031 s]	19.0 ms (0.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.284 s [15.284 s, 15.284 s]	-
appsec	15.239 s [15.239 s, 15.239 s]	-45.0 ms (-0.3%)
iast	18.77 s [18.77 s, 18.77 s]	3.486 s (22.8%)
iast_GLOBAL	18.029 s [18.029 s, 18.029 s]	2.745 s (18.0%)
profiling	15.144 s [15.144 s, 15.144 s]	-140.0 ms (-0.9%)
tracing	15.193 s [15.193 s, 15.193 s]	-91.0 ms (-0.6%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.49.0` -> `1.50.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.50.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.0): 1.50.0 ### Deprecation Notice > \[!NOTE] > `DD_RUNTIME_ID_ENABLED` has been deprecated and will be removed in future releases. Please use `DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED` instead. ### Components #### Application Security Management (WAF) - 🐛 Add String length truncation limit to ObjectIntrospector and update truncation metrics ([#8825](DataDog/dd-trace-java#8825) - [@jandro996](https://github.com/jandro996)) - 🐛 Adapt standalone ASM to support API Security ([#8804](DataDog/dd-trace-java#8804) - [@jandro996](https://github.com/jandro996)) - ✨ Add appsec.waf.input\_truncated metric ([#8791](DataDog/dd-trace-java#8791) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request body collection ([#8748](DataDog/dd-trace-java#8748) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request/response headers collection ([#8724](DataDog/dd-trace-java#8724) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - ✨ Add artifacts to public s3 bucket ([#8947](DataDog/dd-trace-java#8947) - [@randomanderson](https://github.com/randomanderson)) #### Continuous Integration Visibility - ✨ Improve PR information building ([#8908](DataDog/dd-trace-java#8908) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Truncate span stack traces when Test Optimization is enabled ([#8903](DataDog/dd-trace-java#8903) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Ensure auto-detected service name is the same for every process in the same build ([#8902](DataDog/dd-trace-java#8902) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Use tag as fallback in api requests if no branch is available ([#8876](DataDog/dd-trace-java#8876) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add support for JUnit 5.13-RC1 ([#8865](DataDog/dd-trace-java#8865), [#8871](DataDog/dd-trace-java#8871) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement attempt to fix v3 and v4 and bump capability version ([#8824](DataDog/dd-trace-java#8824) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🧹 Align retry logic for all test framework instrumentations ([#8803](DataDog/dd-trace-java#8803) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Always build ci workspace without trailing separator ([#8788](DataDog/dd-trace-java#8788) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add commit discrepancies telemetry when building repository git information ([#8763](DataDog/dd-trace-java#8763) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 💡 Surface process tags in dsm payloads and use them for base hash calculation ([#8836](DataDog/dd-trace-java#8836) - [@amarziali](https://github.com/amarziali)) #### Dynamic Instrumentation - ✨ Optimized allocations for collection filter functions ([#8896](DataDog/dd-trace-java#8896) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix SymDB upload size check ([#8887](DataDog/dd-trace-java#8887) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for Set in filter function ([#8873](DataDog/dd-trace-java#8873) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for isDefined in log template ([#8859](DataDog/dd-trace-java#8859) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix Max captured frames for Exception Replay ([#8856](DataDog/dd-trace-java#8856) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Remove static inherited fields collection ([#8832](DataDog/dd-trace-java#8832) - [@jpbempel](https://github.com/jpbempel)) - 💡 Add process tags to dynamic instrumentation intake payload ([#8779](DataDog/dd-trace-java#8779) - [@amarziali](https://github.com/amarziali)) #### GraalVM native-image - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) - ✨ Add JMXFetch support for GraalVM Native ([#8569](DataDog/dd-trace-java#8569) - [@ygree](https://github.com/ygree)) #### JMX fetch - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) #### Library Injection - ✨ Deny oracle db jvm based tools ([#8909](DataDog/dd-trace-java#8909) - [@bric3](https://github.com/bric3)) #### OpenTracing - 🐛 Fix OT packaging for exception replay ([#8912](DataDog/dd-trace-java#8912) - [@jpbempel](https://github.com/jpbempel)) #### Profiling - ✨ Bump ddprof to 1.27.0 ([#8893](DataDog/dd-trace-java#8893) - [@jbachorik](https://github.com/jbachorik)) - Properly handle the adaptive sampling interval overflow by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#213 - Fix [#200](DataDog/dd-trace-java#200) Crash related to aligned\_alloc and free in context by [@yanglong1010](https://github.com/yanglong1010) in DataDog/java-profiler#208 - Explicitly initialize empty context page by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#210 - Re-connect crash recursion protection with VM stackwalker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#214 - ✨ Enable ZSTD compression for profiling ([#8862](DataDog/dd-trace-java#8862) - [@MattAlp](https://github.com/MattAlp)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - 💡 Collect process tags for profiling upload requests ([#8780](DataDog/dd-trace-java#8780) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 💡 Surface process tags on telemetry payloads ([#8837](DataDog/dd-trace-java#8837) - [@amarziali](https://github.com/amarziali)) #### Trace context propagation - ✨ Migrating all HttpClient Instrumentations to Inject Full Context ([#8826](DataDog/dd-trace-java#8826) - [@mhlidd](https://github.com/mhlidd)) - ✨ Migrating all HttpServer Instrumentations to Extract full Context ([#8820](DataDog/dd-trace-java#8820) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - ✨⚡ Skip JAXB generated classes classloader ([#9003](DataDog/dd-trace-java#9003) - [@bric3](https://github.com/bric3)) - ✨ Add DD\_RUNTIME\_METRICS\_RUNTIME\_ID\_ENABLED alias for runtime id generation ([#8981](DataDog/dd-trace-java#8981) - [@amarziali](https://github.com/amarziali)) - 🐛 Use resolved address for peer.hostname when available without hitting the cache ([#8915](DataDog/dd-trace-java#8915) - [@amarziali](https://github.com/amarziali)) - 💡 Surface server name process tag for tomcat ([#8894](DataDog/dd-trace-java#8894) - [@amarziali](https://github.com/amarziali)) - 💡 Surface websphere cell and server name on process tags ([#8880](DataDog/dd-trace-java#8880) - [@amarziali](https://github.com/amarziali)) - ✨ Added special lightweight pre-main class that skips installation on incompatible JVMs. ([#8855](DataDog/dd-trace-java#8855) - [@AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add entrypoint type to process tags ([#8839](DataDog/dd-trace-java#8839) - [@amarziali](https://github.com/amarziali)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - ✨ Notify listeners when the scope top changes after switching scope stacks ([#8797](DataDog/dd-trace-java#8797) - [@mcculls](https://github.com/mcculls)) - ✨ Read hsperfdata for Java PIDs if jvmstat is unavailable ([#8792](DataDog/dd-trace-java#8792) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Turn JDK socket support on by default ([#8752](DataDog/dd-trace-java#8752) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Simplify context propagation ([#8719](DataDog/dd-trace-java#8719) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Add JSON parsing support ([#8579](DataDog/dd-trace-java#8579) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer internal logging - ✨ Fix printing format of span identifiers ([#8897](DataDog/dd-trace-java#8897) - [@vandonr](https://github.com/vandonr)) #### Tracer public API - 💡 Track the source of installation ([#8956](DataDog/dd-trace-java#8956) - [@mabdinur](https://github.com/mabdinur)) - ✨ Enforce size limit on application\_monitoring.yaml files ([#8789](DataDog/dd-trace-java#8789) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Enabling baggage cache to support limits and non-ascii characters ([#8713](DataDog/dd-trace-java#8713) - [@mhlidd](https://github.com/mhlidd)) ### Instrumentations #### AWS Lambda instrumentation - ✨ Pass Lambda Request ID to Extension ([#8814](DataDog/dd-trace-java#8814) - [@nhulston](https://github.com/nhulston)) #### Core Java language instrumentation - ✨ Ensure ClassloadingInstrumentation is always applied even with `DD_TRACE_ENABLED=false` ([#8863](DataDog/dd-trace-java#8863) - [@mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - 🐛 Do not override route with / in vertx instrumentation ([#8881](DataDog/dd-trace-java#8881) - [@vandonr](https://github.com/vandonr)) #### IBM Liberty - 🐛 Fix error mark on http status for IBM liberty ([#8822](DataDog/dd-trace-java#8822) - [@amarziali](https://github.com/amarziali)) #### JDBC instrumentation - 🐛 Do not prepend DBM <> APM trace comment in SQLCommenter if there is a pg plan hint ([#8864](DataDog/dd-trace-java#8864) - [@edengorevoy](https://github.com/edengorevoy)) #### JMS instrumentation - ✨ Add jms as an extra integration name where there is JMS involved ([#8933](DataDog/dd-trace-java#8933) - [@vandonr](https://github.com/vandonr)) #### Kotlin instrumentation - ✨ Enable kotlin\_coroutine integration by default ([#8848](DataDog/dd-trace-java#8848) - [@mcculls](https://github.com/mcculls)) - 🧹 Rework Kotlin coroutines instrumentation around coroutine context ([#8774](DataDog/dd-trace-java#8774) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Support WithSpan inheritContext attribute ([#8858](DataDog/dd-trace-java#8858) - [@amarziali](https://github.com/amarziali)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Play Framework instrumentation - 🐛 Fix the Play Framework's span resource name priority so that the client JAX-RS 404 cannot override it ([#8591](DataDog/dd-trace-java#8591) - [@ygree](https://github.com/ygree)) #### Quarkus Instrumentation - 🐛 Ignore quarkus jaxrs stubs and cdi wrapper proxies ([#8891](DataDog/dd-trace-java#8891) - [@amarziali](https://github.com/amarziali)) #### ServiceTalk - ✨ Improve ServiceTalk Captured Context API Instrumentation for v0.42.56+ ([#8821](DataDog/dd-trace-java#8821) - [@ygree](https://github.com/ygree)) #### Spring instrumentation - ✨ Supporting Baggage for Instrumentations used in Weblog Tests ([#8773](DataDog/dd-trace-java#8773) - [@mhlidd](https://github.com/mhlidd)) #### WebSocket Instrumentation - 💡 Trace websocket for spring webflux reactive handlers ([#8831](DataDog/dd-trace-java#8831) - [@amarziali](https://github.com/amarziali)) - 💡:test\_tube: WebSocket support for Netty ([#8632](DataDog/dd-trace-java#8632) - [@ValentinZakharov](https://github.com/ValentinZakharov)) #### Zio Instrumentation - 🧹 Cleanup Zio fiber instrumentation to avoid repeated activation of continuation ([#8798](DataDog/dd-trace-java#8798) - [@mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9207366cdb6a1bd098082305d354a0a3c4622d7a

Fix SymDB upload size check

12d7353

First compress the upload and then check the compressed size against the maximum upload size. If above the limit, split by jar or scope and try again compressed Add it.unimi.dsi.fastutil as third-party libraries

jpbempel added the type: bug label May 26, 2025

jpbempel requested a review from a team as a code owner May 26, 2025 14:46

jpbempel added the comp: debugger Dynamic Instrumentation label May 26, 2025

jpbempel requested review from evanchooly and ojung and removed request for a team May 26, 2025 14:46

ojung approved these changes May 27, 2025

View reviewed changes

jpbempel merged commit cb7783b into master May 27, 2025
533 of 534 checks passed

jpbempel deleted the jpbempel/fix-symdb-compress-check branch May 27, 2025 09:51

github-actions bot added this to the 1.50.0 milestone May 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix SymDB upload size check #8887

Fix SymDB upload size check #8887

Uh oh!

jpbempel commented May 26, 2025 •

edited by jira bot

Loading

Uh oh!

pr-commenter bot commented May 26, 2025

Uh oh!

pr-commenter bot commented May 26, 2025

Uh oh!

Uh oh!

Uh oh!

Fix SymDB upload size check #8887

Fix SymDB upload size check #8887

Uh oh!

Conversation

jpbempel commented May 26, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented May 26, 2025

Debugger benchmarks

Parameters

Summary

Uh oh!

pr-commenter bot commented May 26, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Uh oh!

jpbempel commented May 26, 2025 •

edited by jira bot

Loading