Fix Max captured frames for Exception Replay #8856

jpbempel · 2025-05-21T05:29:17Z

What Does This Do

For recursive frames we were sending snapshot as long as the frame are the same. frame capture was relying on the fact they were different. Now we are limiting the snapshot sent to config parameter

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3390

For recursive frames we were sending snapshot as long as the frame are the same. frame capture was relying on the fact they were different. Now we are limiting the snapshot sent to config parameter

pr-commenter · 2025-05-21T05:51:03Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1747805931	1747806300
end_time	2025-05-21T05:40:11	2025-05-21T05:46:19
git_branch	master	jpbempel/fix-max-capture-frames-rec
git_commit_sha	`b8e7758`	`2ca125e`
start_time	2025-05-21T05:38:52	2025-05-21T05:45:01

See matching parameters

	Baseline	Candidate
ci_job_id	947202217	947202217
ci_pipeline_id	65682482	65682482
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1747804910	1747804910

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-40.028µs; +16.628µs] or [-14.199%; +5.898%]	unstable [-53.817µs; +28.693µs] or [-16.664%; +8.885%]	unstable [-65.487µs; +37.829µs] or [-19.346%; +11.175%]	unstable [-127.208µs; +145.950µs] or [-13.317%; +15.279%]	same
scenario:basic	unsure [-12.262µs; -1.190µs] or [-4.341%; -0.421%]	same	same	unstable [-73.961µs; +128.534µs] or [-9.233%; +16.046%]	same
scenario:loop	same	unsure [+7.493µs; +76.894µs] or [+0.074%; +0.760%]	same	same	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (322.953 µs) : 276, 370
.   : milestone, 323,
basic (315.636 µs) : 304, 327
.   : milestone, 316,
loop (10.114 ms) : 10079, 10148
.   : milestone, 10114,
section candidate
noprobe (310.39 µs) : 281, 339
.   : milestone, 310,
basic (309.009 µs) : 300, 318
.   : milestone, 309,
loop (10.156 ms) : 10126, 10186
.   : milestone, 10156,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	322.953 µs [275.576 µs, 370.33 µs]
basic	315.636 µs [304.305 µs, 326.966 µs]
loop	10.114 ms [10.079 ms, 10.148 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	310.39 µs [281.361 µs, 339.42 µs]
basic	309.009 µs [299.777 µs, 318.24 µs]
loop	10.156 ms [10.126 ms, 10.186 ms]

pr-commenter · 2025-05-21T06:10:24Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-max-capture-frames-rec
git_commit_date	1747755399	1747804910
git_commit_sha	`b8e7758`	`2ca125e`
release_version	1.50.0-SNAPSHOT~b8e77582af	1.50.0-SNAPSHOT~2ca125edc0

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1747807775	1747807775
ci_job_id	947202211	947202211
ci_pipeline_id	65682482	65682482
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-aszuydir-project-304-concurrent-0-lrr6hg1e 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-aszuydir-project-304-concurrent-0-lrr6hg1e 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 14 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~2ca125edc0, baseline=1.50.0-SNAPSHOT~b8e77582af

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1029044
Total [baseline] (10.453 s) : 0, 10453135
Agent [candidate] (1.022 s) : 0, 1022183
Total [candidate] (10.447 s) : 0, 10447128
section appsec
Agent [baseline] (1.162 s) : 0, 1162193
Total [baseline] (10.666 s) : 0, 10666207
Agent [candidate] (1.169 s) : 0, 1168750
Total [candidate] (10.637 s) : 0, 10637419
section iast
Agent [baseline] (1.152 s) : 0, 1152148
Total [baseline] (10.839 s) : 0, 10838980
Agent [candidate] (1.149 s) : 0, 1149268
Total [candidate] (10.849 s) : 0, 10849035
section profiling
Agent [baseline] (1.287 s) : 0, 1286966
Total [baseline] (10.874 s) : 0, 10873528
Agent [candidate] (1.286 s) : 0, 1285732
Total [candidate] (10.828 s) : 0, 10827729

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.029 s	-
Agent	appsec	1.162 s	133.149 ms (12.9%)
Agent	iast	1.152 s	123.104 ms (12.0%)
Agent	profiling	1.287 s	257.922 ms (25.1%)
Total	tracing	10.453 s	-
Total	appsec	10.666 s	213.073 ms (2.0%)
Total	iast	10.839 s	385.845 ms (3.7%)
Total	profiling	10.874 s	420.393 ms (4.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.022 s	-
Agent	appsec	1.169 s	146.567 ms (14.3%)
Agent	iast	1.149 s	127.085 ms (12.4%)
Agent	profiling	1.286 s	263.549 ms (25.8%)
Total	tracing	10.447 s	-
Total	appsec	10.637 s	190.292 ms (1.8%)
Total	iast	10.849 s	401.908 ms (3.8%)
Total	profiling	10.828 s	380.602 ms (3.6%)

gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~2ca125edc0, baseline=1.50.0-SNAPSHOT~b8e77582af

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.282 ms) : 0, 687282
BytebuddyAgent [candidate] (682.804 ms) : 0, 682804
GlobalTracer [baseline] (242.238 ms) : 0, 242238
GlobalTracer [candidate] (241.644 ms) : 0, 241644
AppSec [baseline] (55.498 ms) : 0, 55498
AppSec [candidate] (54.593 ms) : 0, 54593
Debugger [baseline] (9.693 ms) : 0, 9693
Debugger [candidate] (8.989 ms) : 0, 8989
Remote Config [baseline] (703.436 µs) : 0, 703
Remote Config [candidate] (703.275 µs) : 0, 703
Telemetry [baseline] (9.873 ms) : 0, 9873
Telemetry [candidate] (9.825 ms) : 0, 9825
section appsec
BytebuddyAgent [baseline] (701.63 ms) : 0, 701630
BytebuddyAgent [candidate] (706.236 ms) : 0, 706236
GlobalTracer [baseline] (236.646 ms) : 0, 236646
GlobalTracer [candidate] (238.392 ms) : 0, 238392
AppSec [baseline] (175.589 ms) : 0, 175589
AppSec [candidate] (175.434 ms) : 0, 175434
Debugger [baseline] (5.953 ms) : 0, 5953
Debugger [candidate] (5.978 ms) : 0, 5978
Remote Config [baseline] (625.639 µs) : 0, 626
Remote Config [candidate] (623.521 µs) : 0, 624
Telemetry [baseline] (7.387 ms) : 0, 7387
Telemetry [candidate] (7.43 ms) : 0, 7430
IAST [baseline] (21.648 ms) : 0, 21648
IAST [candidate] (21.873 ms) : 0, 21873
section iast
BytebuddyAgent [baseline] (803.44 ms) : 0, 803440
BytebuddyAgent [candidate] (801.586 ms) : 0, 801586
GlobalTracer [baseline] (231.86 ms) : 0, 231860
GlobalTracer [candidate] (230.825 ms) : 0, 230825
AppSec [baseline] (52.717 ms) : 0, 52717
AppSec [candidate] (52.9 ms) : 0, 52900
Debugger [baseline] (5.926 ms) : 0, 5926
Debugger [candidate] (5.939 ms) : 0, 5939
Remote Config [baseline] (592.896 µs) : 0, 593
Remote Config [candidate] (596.214 µs) : 0, 596
Telemetry [baseline] (7.908 ms) : 0, 7908
Telemetry [candidate] (7.872 ms) : 0, 7872
IAST [baseline] (26.306 ms) : 0, 26306
IAST [candidate] (25.972 ms) : 0, 25972
section profiling
BytebuddyAgent [baseline] (678.281 ms) : 0, 678281
BytebuddyAgent [candidate] (677.494 ms) : 0, 677494
GlobalTracer [baseline] (376.724 ms) : 0, 376724
GlobalTracer [candidate] (376.349 ms) : 0, 376349
AppSec [baseline] (62.137 ms) : 0, 62137
AppSec [candidate] (62.11 ms) : 0, 62110
Debugger [baseline] (6.374 ms) : 0, 6374
Debugger [candidate] (6.304 ms) : 0, 6304
Remote Config [baseline] (652.604 µs) : 0, 653
Remote Config [candidate] (651.362 µs) : 0, 651
Telemetry [baseline] (8.251 ms) : 0, 8251
Telemetry [candidate] (8.28 ms) : 0, 8280
ProfilingAgent [baseline] (103.277 ms) : 0, 103277
ProfilingAgent [candidate] (103.497 ms) : 0, 103497
Profiling [baseline] (103.301 ms) : 0, 103301
Profiling [candidate] (103.521 ms) : 0, 103521

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~2ca125edc0, baseline=1.50.0-SNAPSHOT~b8e77582af

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.015 s) : 0, 1015443
Total [baseline] (8.611 s) : 0, 8610644
Agent [candidate] (1.022 s) : 0, 1021852
Total [candidate] (8.677 s) : 0, 8677483
section iast
Agent [baseline] (1.149 s) : 0, 1148713
Total [baseline] (9.18 s) : 0, 9180306
Agent [candidate] (1.156 s) : 0, 1156438
Total [candidate] (9.251 s) : 0, 9250998
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.153 s) : 0, 1153392
Total [baseline] (9.204 s) : 0, 9203711
Agent [candidate] (1.158 s) : 0, 1158492
Total [candidate] (9.237 s) : 0, 9236897
section iast_TELEMETRY_OFF
Agent [baseline] (1.145 s) : 0, 1144793
Total [baseline] (9.257 s) : 0, 9257431
Agent [candidate] (1.155 s) : 0, 1154699
Total [candidate] (9.329 s) : 0, 9328677

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.015 s	-
Agent	iast	1.149 s	133.271 ms (13.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.153 s	137.949 ms (13.6%)
Agent	iast_TELEMETRY_OFF	1.145 s	129.351 ms (12.7%)
Total	tracing	8.611 s	-
Total	iast	9.18 s	569.662 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.204 s	593.067 ms (6.9%)
Total	iast_TELEMETRY_OFF	9.257 s	646.787 ms (7.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.022 s	-
Agent	iast	1.156 s	134.587 ms (13.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.158 s	136.64 ms (13.4%)
Agent	iast_TELEMETRY_OFF	1.155 s	132.847 ms (13.0%)
Total	tracing	8.677 s	-
Total	iast	9.251 s	573.515 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.237 s	559.413 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.329 s	651.193 ms (7.5%)

gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~2ca125edc0, baseline=1.50.0-SNAPSHOT~b8e77582af

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.422 ms) : 0, 680422
BytebuddyAgent [candidate] (683.158 ms) : 0, 683158
GlobalTracer [baseline] (239.253 ms) : 0, 239253
GlobalTracer [candidate] (240.533 ms) : 0, 240533
AppSec [baseline] (54.753 ms) : 0, 54753
AppSec [candidate] (55.968 ms) : 0, 55968
Debugger [baseline] (6.118 ms) : 0, 6118
Debugger [candidate] (8.96 ms) : 0, 8960
Remote Config [baseline] (692.798 µs) : 0, 693
Remote Config [candidate] (689.186 µs) : 0, 689
Telemetry [baseline] (10.702 ms) : 0, 10702
Telemetry [candidate] (9.026 ms) : 0, 9026
section iast
BytebuddyAgent [baseline] (801.92 ms) : 0, 801920
BytebuddyAgent [candidate] (807.954 ms) : 0, 807954
GlobalTracer [baseline] (230.332 ms) : 0, 230332
GlobalTracer [candidate] (231.901 ms) : 0, 231901
IAST [baseline] (27.465 ms) : 0, 27465
IAST [candidate] (28.558 ms) : 0, 28558
AppSec [baseline] (51.151 ms) : 0, 51151
AppSec [candidate] (50.191 ms) : 0, 50191
Debugger [baseline] (5.932 ms) : 0, 5932
Debugger [candidate] (5.882 ms) : 0, 5882
Remote Config [baseline] (588.922 µs) : 0, 589
Remote Config [candidate] (595.705 µs) : 0, 596
Telemetry [baseline] (7.86 ms) : 0, 7860
Telemetry [candidate] (7.879 ms) : 0, 7879
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (806.535 ms) : 0, 806535
BytebuddyAgent [candidate] (808.619 ms) : 0, 808619
GlobalTracer [baseline] (230.923 ms) : 0, 230923
GlobalTracer [candidate] (232.425 ms) : 0, 232425
IAST [baseline] (30.717 ms) : 0, 30717
IAST [candidate] (27.882 ms) : 0, 27882
AppSec [baseline] (47.4 ms) : 0, 47400
AppSec [candidate] (51.344 ms) : 0, 51344
Debugger [baseline] (5.816 ms) : 0, 5816
Debugger [candidate] (5.935 ms) : 0, 5935
Remote Config [baseline] (592.333 µs) : 0, 592
Remote Config [candidate] (593.057 µs) : 0, 593
Telemetry [baseline] (7.854 ms) : 0, 7854
Telemetry [candidate] (7.92 ms) : 0, 7920
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.717 ms) : 0, 796717
BytebuddyAgent [candidate] (805.106 ms) : 0, 805106
GlobalTracer [baseline] (231.304 ms) : 0, 231304
GlobalTracer [candidate] (232.345 ms) : 0, 232345
IAST [baseline] (23.263 ms) : 0, 23263
IAST [candidate] (22.681 ms) : 0, 22681
AppSec [baseline] (55.555 ms) : 0, 55555
AppSec [candidate] (56.384 ms) : 0, 56384
Debugger [baseline] (5.988 ms) : 0, 5988
Debugger [candidate] (6.036 ms) : 0, 6036
Remote Config [baseline] (608.462 µs) : 0, 608
Remote Config [candidate] (619.584 µs) : 0, 620
Telemetry [baseline] (7.822 ms) : 0, 7822
Telemetry [candidate] (7.846 ms) : 0, 7846

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-05-21T05:39:53	2025-05-21T05:47:37
git_branch	master	jpbempel/fix-max-capture-frames-rec
git_commit_date	1747755399	1747804910
git_commit_sha	`b8e7758`	`2ca125e`
release_version	1.50.0-SNAPSHOT~b8e77582af	1.50.0-SNAPSHOT~2ca125edc0
start_time	2025-05-21T05:39:39	2025-05-21T05:47:23

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1747806855	1747806855
ci_job_id	947202212	947202212
ci_pipeline_id	65682482	65682482
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-yh26g23a-project-304-concurrent-0-be4fei7d 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-yh26g23a-project-304-concurrent-0-be4fei7d 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 18 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	better [-87.156µs; -36.021µs] or [-5.596%; -2.313%]	unstable [-448.317op/s; +676.237op/s] or [-15.131%; +22.823%]	1.496ms	3076.923op/s	1.557ms	2962.963op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~2ca125edc0, baseline=1.50.0-SNAPSHOT~b8e77582af
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.372 µs) : 357, 397
.   : milestone, 377,
iast (517.884 µs) : 496, 540
.   : milestone, 518,
iast_FULL (738.53 µs) : 716, 761
.   : milestone, 739,
iast_GLOBAL (560.68 µs) : 539, 582
.   : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (512.34 µs) : 490, 535
.   : milestone, 512,
iast_INACTIVE (461.62 µs) : 439, 484
.   : milestone, 462,
iast_TELEMETRY_OFF (507.859 µs) : 484, 532
.   : milestone, 508,
tracing (452.613 µs) : 431, 474
.   : milestone, 453,
section candidate
no_agent (378.349 µs) : 359, 398
.   : milestone, 378,
iast (522.561 µs) : 501, 544
.   : milestone, 523,
iast_FULL (731.053 µs) : 709, 753
.   : milestone, 731,
iast_GLOBAL (560.927 µs) : 539, 583
.   : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (530.665 µs) : 507, 554
.   : milestone, 531,
iast_INACTIVE (463.628 µs) : 441, 486
.   : milestone, 464,
iast_TELEMETRY_OFF (511.828 µs) : 489, 535
.   : milestone, 512,
tracing (456.827 µs) : 434, 479
.   : milestone, 457,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.372 µs [357.326 µs, 397.418 µs]	-
iast	517.884 µs [495.819 µs, 539.949 µs]	140.511 µs (37.2%)
iast_FULL	738.53 µs [716.391 µs, 760.67 µs]	361.158 µs (95.7%)
iast_GLOBAL	560.68 µs [539.026 µs, 582.334 µs]	183.307 µs (48.6%)
iast_HARDCODED_SECRET_DISABLED	512.34 µs [489.544 µs, 535.135 µs]	134.967 µs (35.8%)
iast_INACTIVE	461.62 µs [439.372 µs, 483.867 µs]	84.247 µs (22.3%)
iast_TELEMETRY_OFF	507.859 µs [484.104 µs, 531.614 µs]	130.486 µs (34.6%)
tracing	452.613 µs [430.741 µs, 474.486 µs]	75.241 µs (19.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.349 µs [358.512 µs, 398.185 µs]	-
iast	522.561 µs [500.72 µs, 544.401 µs]	144.212 µs (38.1%)
iast_FULL	731.053 µs [709.243 µs, 752.864 µs]	352.705 µs (93.2%)
iast_GLOBAL	560.927 µs [538.66 µs, 583.195 µs]	182.578 µs (48.3%)
iast_HARDCODED_SECRET_DISABLED	530.665 µs [507.434 µs, 553.895 µs]	152.316 µs (40.3%)
iast_INACTIVE	463.628 µs [440.955 µs, 486.301 µs]	85.279 µs (22.5%)
iast_TELEMETRY_OFF	511.828 µs [488.545 µs, 535.111 µs]	133.479 µs (35.3%)
tracing	456.827 µs [434.481 µs, 479.173 µs]	78.478 µs (20.7%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~2ca125edc0, baseline=1.50.0-SNAPSHOT~b8e77582af
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.361 ms) : 1342, 1381
.   : milestone, 1361,
appsec (1.721 ms) : 1697, 1745
.   : milestone, 1721,
appsec_no_iast (1.733 ms) : 1709, 1757
.   : milestone, 1733,
code_origins (1.667 ms) : 1640, 1694
.   : milestone, 1667,
iast (1.526 ms) : 1501, 1550
.   : milestone, 1526,
profiling (1.557 ms) : 1533, 1582
.   : milestone, 1557,
tracing (1.493 ms) : 1470, 1516
.   : milestone, 1493,
section candidate
no_agent (1.344 ms) : 1325, 1364
.   : milestone, 1344,
appsec (1.735 ms) : 1711, 1759
.   : milestone, 1735,
appsec_no_iast (1.728 ms) : 1704, 1751
.   : milestone, 1728,
code_origins (1.671 ms) : 1643, 1698
.   : milestone, 1671,
iast (1.526 ms) : 1501, 1551
.   : milestone, 1526,
profiling (1.496 ms) : 1473, 1519
.   : milestone, 1496,
tracing (1.49 ms) : 1466, 1513
.   : milestone, 1490,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.361 ms [1.342 ms, 1.381 ms]	-
appsec	1.721 ms [1.697 ms, 1.745 ms]	359.446 µs (26.4%)
appsec_no_iast	1.733 ms [1.709 ms, 1.757 ms]	371.115 µs (27.3%)
code_origins	1.667 ms [1.64 ms, 1.694 ms]	305.422 µs (22.4%)
iast	1.526 ms [1.501 ms, 1.55 ms]	164.027 µs (12.0%)
profiling	1.557 ms [1.533 ms, 1.582 ms]	195.967 µs (14.4%)
tracing	1.493 ms [1.47 ms, 1.516 ms]	131.672 µs (9.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.344 ms [1.325 ms, 1.364 ms]	-
appsec	1.735 ms [1.711 ms, 1.759 ms]	390.412 µs (29.0%)
appsec_no_iast	1.728 ms [1.704 ms, 1.751 ms]	383.385 µs (28.5%)
code_origins	1.671 ms [1.643 ms, 1.698 ms]	326.327 µs (24.3%)
iast	1.526 ms [1.501 ms, 1.551 ms]	181.734 µs (13.5%)
profiling	1.496 ms [1.473 ms, 1.519 ms]	151.592 µs (11.3%)
tracing	1.49 ms [1.466 ms, 1.513 ms]	145.569 µs (10.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-max-capture-frames-rec
git_commit_date	1747755399	1747804910
git_commit_sha	`b8e7758`	`2ca125e`
release_version	1.50.0-SNAPSHOT~b8e77582af	1.50.0-SNAPSHOT~2ca125edc0

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1747807353	1747807353
ci_job_id	947202213	947202213
ci_pipeline_id	65682482	65682482
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-aszuydir-project-304-concurrent-1-xdp3x8us 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-aszuydir-project-304-concurrent-1-xdp3x8us 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~2ca125edc0, baseline=1.50.0-SNAPSHOT~b8e77582af
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.618 s) : 15618000, 15618000
.   : milestone, 15618000,
appsec (15.183 s) : 15183000, 15183000
.   : milestone, 15183000,
iast (18.456 s) : 18456000, 18456000
.   : milestone, 18456000,
iast_GLOBAL (18.052 s) : 18052000, 18052000
.   : milestone, 18052000,
profiling (15.316 s) : 15316000, 15316000
.   : milestone, 15316000,
tracing (14.974 s) : 14974000, 14974000
.   : milestone, 14974000,
section candidate
no_agent (15.238 s) : 15238000, 15238000
.   : milestone, 15238000,
appsec (15.101 s) : 15101000, 15101000
.   : milestone, 15101000,
iast (18.585 s) : 18585000, 18585000
.   : milestone, 18585000,
iast_GLOBAL (18.172 s) : 18172000, 18172000
.   : milestone, 18172000,
profiling (15.644 s) : 15644000, 15644000
.   : milestone, 15644000,
tracing (14.885 s) : 14885000, 14885000
.   : milestone, 14885000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.618 s [15.618 s, 15.618 s]	-
appsec	15.183 s [15.183 s, 15.183 s]	-435.0 ms (-2.8%)
iast	18.456 s [18.456 s, 18.456 s]	2.838 s (18.2%)
iast_GLOBAL	18.052 s [18.052 s, 18.052 s]	2.434 s (15.6%)
profiling	15.316 s [15.316 s, 15.316 s]	-302.0 ms (-1.9%)
tracing	14.974 s [14.974 s, 14.974 s]	-644.0 ms (-4.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.238 s [15.238 s, 15.238 s]	-
appsec	15.101 s [15.101 s, 15.101 s]	-137.0 ms (-0.9%)
iast	18.585 s [18.585 s, 18.585 s]	3.347 s (22.0%)
iast_GLOBAL	18.172 s [18.172 s, 18.172 s]	2.934 s (19.3%)
profiling	15.644 s [15.644 s, 15.644 s]	406.0 ms (2.7%)
tracing	14.885 s [14.885 s, 14.885 s]	-353.0 ms (-2.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~2ca125edc0, baseline=1.50.0-SNAPSHOT~b8e77582af
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.401 ms) : 2353, 2450
.   : milestone, 2401,
iast (2.18 ms) : 2119, 2240
.   : milestone, 2180,
iast_GLOBAL (2.226 ms) : 2165, 2287
.   : milestone, 2226,
profiling (2.016 ms) : 1967, 2064
.   : milestone, 2016,
tracing (2.004 ms) : 1956, 2051
.   : milestone, 2004,
section candidate
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.396 ms) : 2348, 2444
.   : milestone, 2396,
iast (2.171 ms) : 2110, 2231
.   : milestone, 2171,
iast_GLOBAL (2.219 ms) : 2157, 2280
.   : milestone, 2219,
profiling (2.031 ms) : 1982, 2080
.   : milestone, 2031,
tracing (2.003 ms) : 1956, 2050
.   : milestone, 2003,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.462 ms, 1.485 ms]	-
appsec	2.401 ms [2.353 ms, 2.45 ms]	927.976 µs (63.0%)
iast	2.18 ms [2.119 ms, 2.24 ms]	706.441 µs (47.9%)
iast_GLOBAL	2.226 ms [2.165 ms, 2.287 ms]	752.69 µs (51.1%)
profiling	2.016 ms [1.967 ms, 2.064 ms]	542.389 µs (36.8%)
tracing	2.004 ms [1.956 ms, 2.051 ms]	530.164 µs (36.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.461 ms, 1.484 ms]	-
appsec	2.396 ms [2.348 ms, 2.444 ms]	924.006 µs (62.8%)
iast	2.171 ms [2.11 ms, 2.231 ms]	698.521 µs (47.4%)
iast_GLOBAL	2.219 ms [2.157 ms, 2.28 ms]	746.528 µs (50.7%)
profiling	2.031 ms [1.982 ms, 2.08 ms]	558.611 µs (37.9%)
tracing	2.003 ms [1.956 ms, 2.05 ms]	530.575 µs (36.0%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.49.0` -> `1.50.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.50.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.0): 1.50.0 ### Deprecation Notice > \[!NOTE] > `DD_RUNTIME_ID_ENABLED` has been deprecated and will be removed in future releases. Please use `DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED` instead. ### Components #### Application Security Management (WAF) - 🐛 Add String length truncation limit to ObjectIntrospector and update truncation metrics ([#8825](DataDog/dd-trace-java#8825) - [@jandro996](https://github.com/jandro996)) - 🐛 Adapt standalone ASM to support API Security ([#8804](DataDog/dd-trace-java#8804) - [@jandro996](https://github.com/jandro996)) - ✨ Add appsec.waf.input\_truncated metric ([#8791](DataDog/dd-trace-java#8791) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request body collection ([#8748](DataDog/dd-trace-java#8748) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request/response headers collection ([#8724](DataDog/dd-trace-java#8724) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - ✨ Add artifacts to public s3 bucket ([#8947](DataDog/dd-trace-java#8947) - [@randomanderson](https://github.com/randomanderson)) #### Continuous Integration Visibility - ✨ Improve PR information building ([#8908](DataDog/dd-trace-java#8908) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Truncate span stack traces when Test Optimization is enabled ([#8903](DataDog/dd-trace-java#8903) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Ensure auto-detected service name is the same for every process in the same build ([#8902](DataDog/dd-trace-java#8902) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Use tag as fallback in api requests if no branch is available ([#8876](DataDog/dd-trace-java#8876) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add support for JUnit 5.13-RC1 ([#8865](DataDog/dd-trace-java#8865), [#8871](DataDog/dd-trace-java#8871) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement attempt to fix v3 and v4 and bump capability version ([#8824](DataDog/dd-trace-java#8824) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🧹 Align retry logic for all test framework instrumentations ([#8803](DataDog/dd-trace-java#8803) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Always build ci workspace without trailing separator ([#8788](DataDog/dd-trace-java#8788) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add commit discrepancies telemetry when building repository git information ([#8763](DataDog/dd-trace-java#8763) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 💡 Surface process tags in dsm payloads and use them for base hash calculation ([#8836](DataDog/dd-trace-java#8836) - [@amarziali](https://github.com/amarziali)) #### Dynamic Instrumentation - ✨ Optimized allocations for collection filter functions ([#8896](DataDog/dd-trace-java#8896) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix SymDB upload size check ([#8887](DataDog/dd-trace-java#8887) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for Set in filter function ([#8873](DataDog/dd-trace-java#8873) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for isDefined in log template ([#8859](DataDog/dd-trace-java#8859) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix Max captured frames for Exception Replay ([#8856](DataDog/dd-trace-java#8856) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Remove static inherited fields collection ([#8832](DataDog/dd-trace-java#8832) - [@jpbempel](https://github.com/jpbempel)) - 💡 Add process tags to dynamic instrumentation intake payload ([#8779](DataDog/dd-trace-java#8779) - [@amarziali](https://github.com/amarziali)) #### GraalVM native-image - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) - ✨ Add JMXFetch support for GraalVM Native ([#8569](DataDog/dd-trace-java#8569) - [@ygree](https://github.com/ygree)) #### JMX fetch - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) #### Library Injection - ✨ Deny oracle db jvm based tools ([#8909](DataDog/dd-trace-java#8909) - [@bric3](https://github.com/bric3)) #### OpenTracing - 🐛 Fix OT packaging for exception replay ([#8912](DataDog/dd-trace-java#8912) - [@jpbempel](https://github.com/jpbempel)) #### Profiling - ✨ Bump ddprof to 1.27.0 ([#8893](DataDog/dd-trace-java#8893) - [@jbachorik](https://github.com/jbachorik)) - Properly handle the adaptive sampling interval overflow by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#213 - Fix [#200](DataDog/dd-trace-java#200) Crash related to aligned\_alloc and free in context by [@yanglong1010](https://github.com/yanglong1010) in DataDog/java-profiler#208 - Explicitly initialize empty context page by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#210 - Re-connect crash recursion protection with VM stackwalker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#214 - ✨ Enable ZSTD compression for profiling ([#8862](DataDog/dd-trace-java#8862) - [@MattAlp](https://github.com/MattAlp)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - 💡 Collect process tags for profiling upload requests ([#8780](DataDog/dd-trace-java#8780) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 💡 Surface process tags on telemetry payloads ([#8837](DataDog/dd-trace-java#8837) - [@amarziali](https://github.com/amarziali)) #### Trace context propagation - ✨ Migrating all HttpClient Instrumentations to Inject Full Context ([#8826](DataDog/dd-trace-java#8826) - [@mhlidd](https://github.com/mhlidd)) - ✨ Migrating all HttpServer Instrumentations to Extract full Context ([#8820](DataDog/dd-trace-java#8820) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - ✨⚡ Skip JAXB generated classes classloader ([#9003](DataDog/dd-trace-java#9003) - [@bric3](https://github.com/bric3)) - ✨ Add DD\_RUNTIME\_METRICS\_RUNTIME\_ID\_ENABLED alias for runtime id generation ([#8981](DataDog/dd-trace-java#8981) - [@amarziali](https://github.com/amarziali)) - 🐛 Use resolved address for peer.hostname when available without hitting the cache ([#8915](DataDog/dd-trace-java#8915) - [@amarziali](https://github.com/amarziali)) - 💡 Surface server name process tag for tomcat ([#8894](DataDog/dd-trace-java#8894) - [@amarziali](https://github.com/amarziali)) - 💡 Surface websphere cell and server name on process tags ([#8880](DataDog/dd-trace-java#8880) - [@amarziali](https://github.com/amarziali)) - ✨ Added special lightweight pre-main class that skips installation on incompatible JVMs. ([#8855](DataDog/dd-trace-java#8855) - [@AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add entrypoint type to process tags ([#8839](DataDog/dd-trace-java#8839) - [@amarziali](https://github.com/amarziali)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - ✨ Notify listeners when the scope top changes after switching scope stacks ([#8797](DataDog/dd-trace-java#8797) - [@mcculls](https://github.com/mcculls)) - ✨ Read hsperfdata for Java PIDs if jvmstat is unavailable ([#8792](DataDog/dd-trace-java#8792) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Turn JDK socket support on by default ([#8752](DataDog/dd-trace-java#8752) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Simplify context propagation ([#8719](DataDog/dd-trace-java#8719) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Add JSON parsing support ([#8579](DataDog/dd-trace-java#8579) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer internal logging - ✨ Fix printing format of span identifiers ([#8897](DataDog/dd-trace-java#8897) - [@vandonr](https://github.com/vandonr)) #### Tracer public API - 💡 Track the source of installation ([#8956](DataDog/dd-trace-java#8956) - [@mabdinur](https://github.com/mabdinur)) - ✨ Enforce size limit on application\_monitoring.yaml files ([#8789](DataDog/dd-trace-java#8789) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Enabling baggage cache to support limits and non-ascii characters ([#8713](DataDog/dd-trace-java#8713) - [@mhlidd](https://github.com/mhlidd)) ### Instrumentations #### AWS Lambda instrumentation - ✨ Pass Lambda Request ID to Extension ([#8814](DataDog/dd-trace-java#8814) - [@nhulston](https://github.com/nhulston)) #### Core Java language instrumentation - ✨ Ensure ClassloadingInstrumentation is always applied even with `DD_TRACE_ENABLED=false` ([#8863](DataDog/dd-trace-java#8863) - [@mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - 🐛 Do not override route with / in vertx instrumentation ([#8881](DataDog/dd-trace-java#8881) - [@vandonr](https://github.com/vandonr)) #### IBM Liberty - 🐛 Fix error mark on http status for IBM liberty ([#8822](DataDog/dd-trace-java#8822) - [@amarziali](https://github.com/amarziali)) #### JDBC instrumentation - 🐛 Do not prepend DBM <> APM trace comment in SQLCommenter if there is a pg plan hint ([#8864](DataDog/dd-trace-java#8864) - [@edengorevoy](https://github.com/edengorevoy)) #### JMS instrumentation - ✨ Add jms as an extra integration name where there is JMS involved ([#8933](DataDog/dd-trace-java#8933) - [@vandonr](https://github.com/vandonr)) #### Kotlin instrumentation - ✨ Enable kotlin\_coroutine integration by default ([#8848](DataDog/dd-trace-java#8848) - [@mcculls](https://github.com/mcculls)) - 🧹 Rework Kotlin coroutines instrumentation around coroutine context ([#8774](DataDog/dd-trace-java#8774) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Support WithSpan inheritContext attribute ([#8858](DataDog/dd-trace-java#8858) - [@amarziali](https://github.com/amarziali)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Play Framework instrumentation - 🐛 Fix the Play Framework's span resource name priority so that the client JAX-RS 404 cannot override it ([#8591](DataDog/dd-trace-java#8591) - [@ygree](https://github.com/ygree)) #### Quarkus Instrumentation - 🐛 Ignore quarkus jaxrs stubs and cdi wrapper proxies ([#8891](DataDog/dd-trace-java#8891) - [@amarziali](https://github.com/amarziali)) #### ServiceTalk - ✨ Improve ServiceTalk Captured Context API Instrumentation for v0.42.56+ ([#8821](DataDog/dd-trace-java#8821) - [@ygree](https://github.com/ygree)) #### Spring instrumentation - ✨ Supporting Baggage for Instrumentations used in Weblog Tests ([#8773](DataDog/dd-trace-java#8773) - [@mhlidd](https://github.com/mhlidd)) #### WebSocket Instrumentation - 💡 Trace websocket for spring webflux reactive handlers ([#8831](DataDog/dd-trace-java#8831) - [@amarziali](https://github.com/amarziali)) - 💡:test\_tube: WebSocket support for Netty ([#8632](DataDog/dd-trace-java#8632) - [@ValentinZakharov](https://github.com/ValentinZakharov)) #### Zio Instrumentation - 🧹 Cleanup Zio fiber instrumentation to avoid repeated activation of continuation ([#8798](DataDog/dd-trace-java#8798) - [@mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9207366cdb6a1bd098082305d354a0a3c4622d7a

Fix Max captured frames for Exception Replay

2ca125e

For recursive frames we were sending snapshot as long as the frame are the same. frame capture was relying on the fact they were different. Now we are limiting the snapshot sent to config parameter

jpbempel requested a review from a team as a code owner May 21, 2025 05:29

jpbempel requested review from evanchooly and removed request for a team May 21, 2025 05:29

jpbempel added type: bug comp: debugger Dynamic Instrumentation labels May 21, 2025

evanchooly approved these changes May 21, 2025

View reviewed changes

jpbempel merged commit 3584e51 into master May 21, 2025
595 of 601 checks passed

jpbempel deleted the jpbempel/fix-max-capture-frames-rec branch May 21, 2025 14:52

github-actions bot added this to the 1.50.0 milestone May 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Max captured frames for Exception Replay #8856

Fix Max captured frames for Exception Replay #8856

Uh oh!

jpbempel commented May 21, 2025 •

edited by jira bot

Loading

Uh oh!

pr-commenter bot commented May 21, 2025

Uh oh!

pr-commenter bot commented May 21, 2025

Uh oh!

Uh oh!

Uh oh!

Fix Max captured frames for Exception Replay #8856

Fix Max captured frames for Exception Replay #8856

Uh oh!

Conversation

jpbempel commented May 21, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented May 21, 2025

Debugger benchmarks

Parameters

Summary

Uh oh!

pr-commenter bot commented May 21, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Uh oh!

jpbempel commented May 21, 2025 •

edited by jira bot

Loading