-
Notifications
You must be signed in to change notification settings - Fork 318
Fix AssertionError when ServiceTalk context captured with no activeSpan #8951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1031632
Total [baseline] (8.533 s) : 0, 8532521
Agent [candidate] (1.035 s) : 0, 1035314
Total [candidate] (8.548 s) : 0, 8547921
section iast
Agent [baseline] (1.16 s) : 0, 1160248
Total [baseline] (9.233 s) : 0, 9232822
Agent [candidate] (1.156 s) : 0, 1155903
Total [candidate] (9.228 s) : 0, 9227564
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.153 s) : 0, 1152745
Total [baseline] (9.171 s) : 0, 9170791
Agent [candidate] (1.161 s) : 0, 1161406
Total [candidate] (9.19 s) : 0, 9189652
section iast_TELEMETRY_OFF
Agent [baseline] (1.151 s) : 0, 1151491
Total [baseline] (9.18 s) : 0, 9179946
Agent [candidate] (1.157 s) : 0, 1157222
Total [candidate] (9.201 s) : 0, 9200673
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.268 ms) : 0, 688268
BytebuddyAgent [candidate] (689.071 ms) : 0, 689071
GlobalTracer [baseline] (241.975 ms) : 0, 241975
GlobalTracer [candidate] (242.431 ms) : 0, 242431
AppSec [baseline] (59.693 ms) : 0, 59693
AppSec [candidate] (60.21 ms) : 0, 60210
Debugger [baseline] (6.195 ms) : 0, 6195
Debugger [candidate] (6.207 ms) : 0, 6207
Remote Config [baseline] (738.511 µs) : 0, 739
Remote Config [candidate] (748.89 µs) : 0, 749
Telemetry [baseline] (11.244 ms) : 0, 11244
Telemetry [candidate] (12.969 ms) : 0, 12969
section iast
BytebuddyAgent [baseline] (808.486 ms) : 0, 808486
BytebuddyAgent [candidate] (805.064 ms) : 0, 805064
GlobalTracer [baseline] (231.878 ms) : 0, 231878
GlobalTracer [candidate] (231.132 ms) : 0, 231132
IAST [baseline] (26.245 ms) : 0, 26245
IAST [candidate] (28.581 ms) : 0, 28581
AppSec [baseline] (55.622 ms) : 0, 55622
AppSec [candidate] (53.155 ms) : 0, 53155
Debugger [baseline] (6.02 ms) : 0, 6020
Debugger [candidate] (6.017 ms) : 0, 6017
Remote Config [baseline] (609.96 µs) : 0, 610
Remote Config [candidate] (586.045 µs) : 0, 586
Telemetry [baseline] (7.921 ms) : 0, 7921
Telemetry [candidate] (7.964 ms) : 0, 7964
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.289 ms) : 0, 802289
BytebuddyAgent [candidate] (808.817 ms) : 0, 808817
GlobalTracer [baseline] (230.638 ms) : 0, 230638
GlobalTracer [candidate] (232.107 ms) : 0, 232107
IAST [baseline] (28.666 ms) : 0, 28666
IAST [candidate] (27.925 ms) : 0, 27925
AppSec [baseline] (53.21 ms) : 0, 53210
AppSec [candidate] (54.431 ms) : 0, 54431
Debugger [baseline] (6.052 ms) : 0, 6052
Debugger [candidate] (6.038 ms) : 0, 6038
Remote Config [baseline] (592.526 µs) : 0, 593
Remote Config [candidate] (606.581 µs) : 0, 607
Telemetry [baseline] (7.921 ms) : 0, 7921
Telemetry [candidate] (7.945 ms) : 0, 7945
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.254 ms) : 0, 801254
BytebuddyAgent [candidate] (805.499 ms) : 0, 805499
GlobalTracer [baseline] (231.325 ms) : 0, 231325
GlobalTracer [candidate] (232.361 ms) : 0, 232361
IAST [baseline] (27.893 ms) : 0, 27893
IAST [candidate] (28.939 ms) : 0, 28939
AppSec [baseline] (53.183 ms) : 0, 53183
AppSec [candidate] (52.379 ms) : 0, 52379
Debugger [baseline] (6.044 ms) : 0, 6044
Debugger [candidate] (6.027 ms) : 0, 6027
Remote Config [baseline] (590.366 µs) : 0, 590
Remote Config [candidate] (599.527 µs) : 0, 600
Telemetry [baseline] (7.791 ms) : 0, 7791
Telemetry [candidate] (7.909 ms) : 0, 7909
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1029286
Total [baseline] (10.63 s) : 0, 10630175
Agent [candidate] (1.026 s) : 0, 1026114
Total [candidate] (10.689 s) : 0, 10688765
section appsec
Agent [baseline] (1.177 s) : 0, 1176874
Total [baseline] (10.678 s) : 0, 10678219
Agent [candidate] (1.177 s) : 0, 1177377
Total [candidate] (10.729 s) : 0, 10728833
section iast
Agent [baseline] (1.155 s) : 0, 1155499
Total [baseline] (10.854 s) : 0, 10854025
Agent [candidate] (1.154 s) : 0, 1154078
Total [candidate] (10.962 s) : 0, 10961828
section profiling
Agent [baseline] (1.28 s) : 0, 1280379
Total [baseline] (10.872 s) : 0, 10871975
Agent [candidate] (1.28 s) : 0, 1279647
Total [candidate] (10.968 s) : 0, 10967589
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.388 ms) : 0, 684388
BytebuddyAgent [candidate] (683.786 ms) : 0, 683786
GlobalTracer [baseline] (241.441 ms) : 0, 241441
GlobalTracer [candidate] (240.564 ms) : 0, 240564
AppSec [baseline] (61.174 ms) : 0, 61174
AppSec [candidate] (60.336 ms) : 0, 60336
Debugger [baseline] (6.074 ms) : 0, 6074
Debugger [candidate] (6.105 ms) : 0, 6105
Remote Config [baseline] (718.948 µs) : 0, 719
Remote Config [candidate] (730.317 µs) : 0, 730
Telemetry [baseline] (11.981 ms) : 0, 11981
Telemetry [candidate] (11.266 ms) : 0, 11266
section appsec
BytebuddyAgent [baseline] (705.231 ms) : 0, 705231
BytebuddyAgent [candidate] (705.17 ms) : 0, 705170
GlobalTracer [baseline] (234.304 ms) : 0, 234304
GlobalTracer [candidate] (234.426 ms) : 0, 234426
IAST [baseline] (21.694 ms) : 0, 21694
IAST [candidate] (21.773 ms) : 0, 21773
AppSec [baseline] (178.342 ms) : 0, 178342
AppSec [candidate] (178.991 ms) : 0, 178991
Debugger [baseline] (5.899 ms) : 0, 5899
Debugger [candidate] (5.84 ms) : 0, 5840
Remote Config [baseline] (600.963 µs) : 0, 601
Remote Config [candidate] (604.213 µs) : 0, 604
Telemetry [baseline] (7.286 ms) : 0, 7286
Telemetry [candidate] (7.198 ms) : 0, 7198
section iast
BytebuddyAgent [baseline] (804.004 ms) : 0, 804004
BytebuddyAgent [candidate] (803.298 ms) : 0, 803298
GlobalTracer [baseline] (231.451 ms) : 0, 231451
GlobalTracer [candidate] (231.05 ms) : 0, 231050
IAST [baseline] (27.771 ms) : 0, 27771
IAST [candidate] (26.975 ms) : 0, 26975
AppSec [baseline] (54.221 ms) : 0, 54221
AppSec [candidate] (54.851 ms) : 0, 54851
Debugger [baseline] (6.023 ms) : 0, 6023
Debugger [candidate] (5.995 ms) : 0, 5995
Remote Config [baseline] (579.517 µs) : 0, 580
Remote Config [candidate] (587.364 µs) : 0, 587
Telemetry [baseline] (7.905 ms) : 0, 7905
Telemetry [candidate] (7.895 ms) : 0, 7895
section profiling
BytebuddyAgent [baseline] (679.499 ms) : 0, 679499
BytebuddyAgent [candidate] (679.624 ms) : 0, 679624
GlobalTracer [baseline] (362.682 ms) : 0, 362682
GlobalTracer [candidate] (361.485 ms) : 0, 361485
AppSec [baseline] (64.942 ms) : 0, 64942
AppSec [candidate] (64.626 ms) : 0, 64626
Debugger [baseline] (6.208 ms) : 0, 6208
Debugger [candidate] (6.119 ms) : 0, 6119
Remote Config [baseline] (677.398 µs) : 0, 677
Remote Config [candidate] (643.768 µs) : 0, 644
Telemetry [baseline] (8.243 ms) : 0, 8243
Telemetry [candidate] (8.111 ms) : 0, 8111
ProfilingAgent [baseline] (107.123 ms) : 0, 107123
ProfilingAgent [candidate] (107.944 ms) : 0, 107944
Profiling [baseline] (107.148 ms) : 0, 107148
Profiling [candidate] (107.97 ms) : 0, 107970
LoadRequest duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section baseline
no_agent (8.68 ms) : 8657, 8703
. : milestone, 8680,
appsec (40.846 ms) : 40305, 41386
. : milestone, 40846,
code_origins (54.774 ms) : 53622, 55926
. : milestone, 54774,
iast (48.884 ms) : 48188, 49580
. : milestone, 48884,
profiling (10.793 ms) : 10717, 10870
. : milestone, 10793,
tracing (7.858 ms) : 7833, 7883
. : milestone, 7858,
section candidate
no_agent (76.469 ms) : 74740, 78198
. : milestone, 76469,
appsec (96.64 ms) : 93597, 99683
. : milestone, 96640,
code_origins (109.693 ms) : 102985, 116401
. : milestone, 109693,
iast (104.249 ms) : 99888, 108611
. : milestone, 104249,
profiling (89.686 ms) : 87329, 92043
. : milestone, 89686,
tracing (82.518 ms) : 80547, 84488
. : milestone, 82518,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section baseline
no_agent (15.348 s) : 15348000, 15348000
. : milestone, 15348000,
appsec (14.928 s) : 14928000, 14928000
. : milestone, 14928000,
iast (18.398 s) : 18398000, 18398000
. : milestone, 18398000,
iast_GLOBAL (18.27 s) : 18270000, 18270000
. : milestone, 18270000,
profiling (15.883 s) : 15883000, 15883000
. : milestone, 15883000,
tracing (14.714 s) : 14714000, 14714000
. : milestone, 14714000,
section candidate
no_agent (15.455 s) : 15455000, 15455000
. : milestone, 15455000,
appsec (14.907 s) : 14907000, 14907000
. : milestone, 14907000,
iast (18.591 s) : 18591000, 18591000
. : milestone, 18591000,
iast_GLOBAL (18.089 s) : 18089000, 18089000
. : milestone, 18089000,
profiling (15.343 s) : 15343000, 15343000
. : milestone, 15343000,
tracing (14.913 s) : 14913000, 14913000
. : milestone, 14913000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~140762e689, baseline=1.50.0-SNAPSHOT~3e93f43e63
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.413 ms) : 2364, 2463
. : milestone, 2413,
iast (2.198 ms) : 2136, 2261
. : milestone, 2198,
iast_GLOBAL (2.237 ms) : 2174, 2299
. : milestone, 2237,
profiling (2.04 ms) : 1990, 2090
. : milestone, 2040,
tracing (2.013 ms) : 1964, 2061
. : milestone, 2013,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.416 ms) : 2367, 2465
. : milestone, 2416,
iast (2.21 ms) : 2148, 2273
. : milestone, 2210,
iast_GLOBAL (2.244 ms) : 2181, 2307
. : milestone, 2244,
profiling (2.031 ms) : 1981, 2081
. : milestone, 2031,
tracing (2.009 ms) : 1962, 2057
. : milestone, 2009,
|
amarziali
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: others
All other instrumentations
tag: no release notes
Changes to exclude from release notes
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes
Motivation
Fix for #8821
Additional Notes
Should be part of the 1.50.0 release as it's a critical fix for #8821
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]