Skip to content

slim exported swig interface#1425

Merged
FFroehlich merged 10 commits intodevelopfrom
slim_swig
Feb 18, 2021
Merged

slim exported swig interface#1425
FFroehlich merged 10 commits intodevelopfrom
slim_swig

Conversation

@FFroehlich
Copy link
Member

@FFroehlich FFroehlich commented Feb 17, 2021

fixes #1217

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #1425 (be544f8) into develop (ec8d8d8) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1425      +/-   ##
===========================================
+ Coverage    78.74%   78.84%   +0.09%     
===========================================
  Files           66       66              
  Lines        10061    10061              
===========================================
+ Hits          7923     7933      +10     
+ Misses        2138     2128      -10     
Flag Coverage Δ
cpp 75.46% <ø> (+0.14%) ⬆️
petab 69.48% <ø> (ø)
python 67.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sundials_matrix_wrapper.cpp 84.04% <0.00%> (+0.21%) ⬆️
src/spline.cpp 71.57% <0.00%> (+6.31%) ⬆️
include/amici/vector.h 87.50% <0.00%> (+18.75%) ⬆️

@FFroehlich FFroehlich requested a review from dweindl February 17, 2021 21:24
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #1217, I'd say

👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@FFroehlich FFroehlich merged commit fb08ed4 into develop Feb 18, 2021
@FFroehlich FFroehlich deleted the slim_swig branch February 18, 2021 00:23
@dweindl dweindl linked an issue Feb 19, 2021 that may be closed by this pull request
@dweindl dweindl mentioned this pull request Feb 19, 2021
dweindl added a commit that referenced this pull request Feb 20, 2021
….13)

Breaking changes:
* AMICI requires Python>=3.7
* Updated package installation (PEP517/518): 
  Creating source distributions requires https://github.com/pypa/build (#1384)
  (but now handles all package building dependencies properly)

Features:
* More flexible state reinitialization (#1417)

Updated dependencies:
* Upgrade to sundials 5.7.0 (#1392)

Fixes:
* Python: account for heaviside functions in expressions (#1382)
* Python: allow loading of existing models in import_petab_problem (#1383)
* Python: Don't override user-provided compiler/linker flags (#1389)
* Python: PEtab import reinitialization fixes (#1417)
* Python: Fix PEtab observables for pysb models (#1390)
* Python: Substitute expressions in event condition expressions (#1404)
* Python: Unspecified initial states in PEtab conditions table default to SBML initial value (#1397)
* C++: Fix timepoint out of bounds access (#1402)
* C++: Fix exported CMake config (#1388)
* Fixed Dockerfile: add python3-venv (#1398, #1408)

Other:
* Slim exported swig interface (#1425)
* Updated documentation
    * Getting started tutorial (#1423)
    * List supported SBML test tags (#1428)
    * Add AMICI C++/Python/Matlab feature comparison (#1409)
    * ...
* Various minor CI improvements
* ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up swig interface

2 participants