Skip to content

Fix Dockerfile: add python3-venv#1408

Merged
dweindl merged 1 commit intodevelopfrom
fixup_dockerfile
Feb 11, 2021
Merged

Fix Dockerfile: add python3-venv#1408
dweindl merged 1 commit intodevelopfrom
fixup_dockerfile

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Feb 11, 2021

Not sure what changed, but seems to be required now... https://github.com/AMICI-dev/AMICI/runs/1882360437?check_suite_focus=true

@dweindl dweindl requested a review from FFroehlich February 11, 2021 20:26
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #1408 (46ec68c) into develop (ff13ea2) will decrease coverage by 2.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1408      +/-   ##
===========================================
- Coverage    78.74%   76.57%   -2.18%     
===========================================
  Files           65       22      -43     
  Lines        10061     3185    -6876     
===========================================
- Hits          7923     2439    -5484     
+ Misses        2138      746    -1392     
Flag Coverage Δ
cpp ?
petab 69.48% <ø> (ø)
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/pandas.py 10.96% <0.00%> (-87.10%) ⬇️
python/amici/pysb_import.py 57.19% <0.00%> (-36.70%) ⬇️
python/amici/import_utils.py 69.76% <0.00%> (-30.24%) ⬇️
python/amici/numpy.py 67.16% <0.00%> (-14.93%) ⬇️
python/amici/setuptools.py 50.00% <0.00%> (-7.70%) ⬇️
python/amici/__init__.py 83.58% <0.00%> (-7.47%) ⬇️
python/amici/parameter_mapping.py 69.09% <0.00%> (-6.37%) ⬇️
python/amici/gradient_check.py 81.39% <0.00%> (-5.82%) ⬇️
python/amici/sbml_import.py 93.57% <0.00%> (-2.50%) ⬇️
python/amici/custom_commands.py 36.80% <0.00%> (-1.61%) ⬇️
... and 44 more

@dweindl dweindl merged commit 372c618 into develop Feb 11, 2021
@dweindl dweindl deleted the fixup_dockerfile branch February 11, 2021 20:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dweindl dweindl mentioned this pull request Feb 19, 2021
dweindl added a commit that referenced this pull request Feb 20, 2021
….13)

Breaking changes:
* AMICI requires Python>=3.7
* Updated package installation (PEP517/518): 
  Creating source distributions requires https://github.com/pypa/build (#1384)
  (but now handles all package building dependencies properly)

Features:
* More flexible state reinitialization (#1417)

Updated dependencies:
* Upgrade to sundials 5.7.0 (#1392)

Fixes:
* Python: account for heaviside functions in expressions (#1382)
* Python: allow loading of existing models in import_petab_problem (#1383)
* Python: Don't override user-provided compiler/linker flags (#1389)
* Python: PEtab import reinitialization fixes (#1417)
* Python: Fix PEtab observables for pysb models (#1390)
* Python: Substitute expressions in event condition expressions (#1404)
* Python: Unspecified initial states in PEtab conditions table default to SBML initial value (#1397)
* C++: Fix timepoint out of bounds access (#1402)
* C++: Fix exported CMake config (#1388)
* Fixed Dockerfile: add python3-venv (#1398, #1408)

Other:
* Slim exported swig interface (#1425)
* Updated documentation
    * Getting started tutorial (#1423)
    * List supported SBML test tags (#1428)
    * Add AMICI C++/Python/Matlab feature comparison (#1409)
    * ...
* Various minor CI improvements
* ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants