Skip to content

Don't override user-provided compiler/linker flags#1389

Merged
dweindl merged 2 commits intodevelopfrom
fix_noomp
Jan 29, 2021
Merged

Don't override user-provided compiler/linker flags#1389
dweindl merged 2 commits intodevelopfrom
fix_noomp

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jan 29, 2021

Allows specifying e.g. -fno-openmp via AMICI_CXXFLAGS

@dweindl dweindl requested a review from FFroehlich January 29, 2021 17:20
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #1389 (3c6f186) into develop (8c440e9) will increase coverage by 3.40%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1389      +/-   ##
===========================================
+ Coverage    75.31%   78.71%   +3.40%     
===========================================
  Files           22       63      +41     
  Lines         3168     9920    +6752     
===========================================
+ Hits          2386     7809    +5423     
- Misses         782     2111    +1329     
Flag Coverage Δ
cpp 75.23% <ø> (?)
petab 69.50% <50.00%> (ø)
python 68.09% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/setuptools.py 57.69% <50.00%> (+7.69%) ⬆️
src/exception.cpp 82.60% <0.00%> (ø)
include/amici/abstract_model.h 0.00% <0.00%> (ø)
src/solver_idas.cpp 36.57% <0.00%> (ø)
include/amici/solver_idas.h 100.00% <0.00%> (ø)
src/forwardproblem.cpp 91.51% <0.00%> (ø)
src/model.cpp 83.59% <0.00%> (ø)
src/backwardproblem.cpp 64.77% <0.00%> (ø)
src/steadystateproblem.cpp 78.75% <0.00%> (ø)
src/solver.cpp 76.17% <0.00%> (ø)
... and 43 more

@dweindl dweindl merged commit 3e50a8d into develop Jan 29, 2021
@dweindl dweindl deleted the fix_noomp branch January 29, 2021 18:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl mentioned this pull request Feb 19, 2021
dweindl added a commit that referenced this pull request Feb 20, 2021
….13)

Breaking changes:
* AMICI requires Python>=3.7
* Updated package installation (PEP517/518): 
  Creating source distributions requires https://github.com/pypa/build (#1384)
  (but now handles all package building dependencies properly)

Features:
* More flexible state reinitialization (#1417)

Updated dependencies:
* Upgrade to sundials 5.7.0 (#1392)

Fixes:
* Python: account for heaviside functions in expressions (#1382)
* Python: allow loading of existing models in import_petab_problem (#1383)
* Python: Don't override user-provided compiler/linker flags (#1389)
* Python: PEtab import reinitialization fixes (#1417)
* Python: Fix PEtab observables for pysb models (#1390)
* Python: Substitute expressions in event condition expressions (#1404)
* Python: Unspecified initial states in PEtab conditions table default to SBML initial value (#1397)
* C++: Fix timepoint out of bounds access (#1402)
* C++: Fix exported CMake config (#1388)
* Fixed Dockerfile: add python3-venv (#1398, #1408)

Other:
* Slim exported swig interface (#1425)
* Updated documentation
    * Getting started tutorial (#1423)
    * List supported SBML test tags (#1428)
    * Add AMICI C++/Python/Matlab feature comparison (#1409)
    * ...
* Various minor CI improvements
* ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants