Conversation
dweindl
commented
Jan 30, 2021
dweindl
commented
- Upgrade to sundials 5.7.0
- Remove a load of unused sundials components
Codecov Report
@@ Coverage Diff @@
## develop #1392 +/- ##
===========================================
+ Coverage 78.69% 78.70% +0.01%
===========================================
Files 63 63
Lines 9925 9925
===========================================
+ Hits 7810 7811 +1
+ Misses 2115 2114 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@FFroehlich Any idea what could be wrong with ( |
| #define SUNLS_ATIMES_FAIL_UNREC -804 /* atimes unrecoverable failure */ | ||
| #define SUNLS_PSET_FAIL_UNREC -805 /* pset unrecoverable failure */ | ||
| #define SUNLS_PSOLVE_FAIL_UNREC -806 /* psolve unrecoverable failure */ | ||
| #define SUNLS_PACKAGE_FAIL_UNREC -807 /* external package unrec. fail */ | ||
| #define SUNLS_GS_FAIL -808 /* Gram-Schmidt failure */ | ||
| #define SUNLS_QRSOL_FAIL -809 /* QRsol found singular R */ | ||
| #define SUNLS_VECTOROP_ERR -810 /* vector operation error */ | ||
| #define SUNLS_ATIMES_NULL -804 /* atimes function is NULL */ | ||
| #define SUNLS_ATIMES_FAIL_UNREC -805 /* atimes unrecoverable failure */ | ||
| #define SUNLS_PSET_FAIL_UNREC -806 /* pset unrecoverable failure */ | ||
| #define SUNLS_PSOLVE_NULL -807 /* psolve function is NULL */ | ||
| #define SUNLS_PSOLVE_FAIL_UNREC -808 /* psolve unrecoverable failure */ | ||
| #define SUNLS_PACKAGE_FAIL_UNREC -809 /* external package unrec. fail */ | ||
| #define SUNLS_GS_FAIL -810 /* Gram-Schmidt failure */ | ||
| #define SUNLS_QRSOL_FAIL -811 /* QRsol found singular R */ | ||
| #define SUNLS_VECTOROP_ERR -812 /* vector operation error */ |
There was a problem hiding this comment.
Return codes for linear solvers have changed here (new ones + changed values), that is why test_compare_conservation_laws_sbml fails. @paulstapor or @FFroehlich , could you please have a look how SteadystateProblem and defines.h needs to be updated?
We should either get rid of the AMICI_* defines copying these values or adding respective static assertions somewhere, as done for other values.
FFroehlich
left a comment
FFroehlich
left a comment
There was a problem hiding this comment.
Nice 👍 , was deleting python/tests/solverSettings.hdf5 intentional?
I wasn't aware of deleting it. But that file never should have been added to version control. So yes, intentional :) |
|
Kudos, SonarCloud Quality Gate passed!
|
….13) Breaking changes: * AMICI requires Python>=3.7 * Updated package installation (PEP517/518): Creating source distributions requires https://github.com/pypa/build (#1384) (but now handles all package building dependencies properly) Features: * More flexible state reinitialization (#1417) Updated dependencies: * Upgrade to sundials 5.7.0 (#1392) Fixes: * Python: account for heaviside functions in expressions (#1382) * Python: allow loading of existing models in import_petab_problem (#1383) * Python: Don't override user-provided compiler/linker flags (#1389) * Python: PEtab import reinitialization fixes (#1417) * Python: Fix PEtab observables for pysb models (#1390) * Python: Substitute expressions in event condition expressions (#1404) * Python: Unspecified initial states in PEtab conditions table default to SBML initial value (#1397) * C++: Fix timepoint out of bounds access (#1402) * C++: Fix exported CMake config (#1388) * Fixed Dockerfile: add python3-venv (#1398, #1408) Other: * Slim exported swig interface (#1425) * Updated documentation * Getting started tutorial (#1423) * List supported SBML test tags (#1428) * Add AMICI C++/Python/Matlab feature comparison (#1409) * ... * Various minor CI improvements * ...
2 participants
