Allow loading of existing models in import_petab_problem#1383
Merged
Allow loading of existing models in import_petab_problem#1383
Conversation
dweindl
approved these changes
Jan 28, 2021
Member
The only reason is that it's hard to ensure that an existing model matches the possibly changed petab.Problem. But that is independent of the proposed changes... |
Member
|
@ failing doxygen:
Not sure what's going on there again. Can be ignored here. |
Codecov Report
@@ Coverage Diff @@
## develop #1383 +/- ##
===========================================
- Coverage 78.80% 78.75% -0.06%
===========================================
Files 63 63
Lines 9944 9920 -24
===========================================
- Hits 7836 7812 -24
Misses 2108 2108
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Kudos, SonarCloud Quality Gate passed!
|
yannikschaelte
approved these changes
Jan 28, 2021
Merged
dweindl
added a commit
that referenced
this pull request
Feb 20, 2021
….13) Breaking changes: * AMICI requires Python>=3.7 * Updated package installation (PEP517/518): Creating source distributions requires https://github.com/pypa/build (#1384) (but now handles all package building dependencies properly) Features: * More flexible state reinitialization (#1417) Updated dependencies: * Upgrade to sundials 5.7.0 (#1392) Fixes: * Python: account for heaviside functions in expressions (#1382) * Python: allow loading of existing models in import_petab_problem (#1383) * Python: Don't override user-provided compiler/linker flags (#1389) * Python: PEtab import reinitialization fixes (#1417) * Python: Fix PEtab observables for pysb models (#1390) * Python: Substitute expressions in event condition expressions (#1404) * Python: Unspecified initial states in PEtab conditions table default to SBML initial value (#1397) * C++: Fix timepoint out of bounds access (#1402) * C++: Fix exported CMake config (#1388) * Fixed Dockerfile: add python3-venv (#1398, #1408) Other: * Slim exported swig interface (#1425) * Updated documentation * Getting started tutorial (#1423) * List supported SBML test tags (#1428) * Add AMICI C++/Python/Matlab feature comparison (#1409) * ... * Various minor CI improvements * ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import_petab_problemwill fail if a model module has already been generated. This PR makes it possible.Is there any reason why a pre-existent model should not be loaded when
force_compileis false? If so then maybe we could add a keyword argument to only turn on this behaviour when needed.