Update remaining shaders to GLSL 300 #8373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 29, 2023
Collaborator
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
felixpalmer
approved these changes
Jan 2, 2024
modules/aggregation-layers/src/heatmap-layer/triangle-layer-fragment.glsl.ts
Outdated
Show resolved
Hide resolved
Collaborator
As all these changes are basically search/replace I think we can merge. We need to make these changes at some point anyway, as it'll make the PRs for fixing aggregation layers easier to review |
donmccurdy
force-pushed
the
donmccurdy/layers-glsl300-pt4
branch
from
ed429cf to
a482218
Compare
donmccurdy
force-pushed
the
donmccurdy/layers-glsl300-pt5
branch
from
61e4045 to
b22de97
Compare
donmccurdy
force-pushed
the
donmccurdy/layers-glsl300-pt4
branch
from
a482218 to
5c66097
Compare
…agment.glsl.ts Co-authored-by: felixpalmer <felixpalmer@gmail.com>
donmccurdy
force-pushed
the
donmccurdy/layers-glsl300-pt5
branch
from
fdb2218 to
9c40b56
Compare
felixpalmer
added a commit
that referenced
this pull request
Jan 4, 2024
Basic picking working useNormalizedColors Forward undefined/null log on null object Co-authored-by: Ib Green <ib@foursquare.com> Move uniformStore binding to _getModel Type uniformStore Tidy Tidy Bump luma API update chore(ci): Update CI dependencies (#8331) * chore(ci): Update CI to Node.js v18 * chore(ci): Update checkout, setup-node, and setup-python actions [website] Fix FirstPersonView broken video URL (#8330) Bump luma Improve types Tidy Remove unneeded state.uniformStore carto/fetchMap: fix support for quantile color scale in numeric columns for static quadbin/h3 tilesets (#8347) docs: fix source link for `fly-to-interpolator` (#8320) carto: add typedocs to source types (#8343) Remove use of deprecated BufferWithAccessor (#8345) [v9] Fix GoogleMapsOverlay by not clearing canvas (#8351) [website] GEOMATICO-371 | Taxo map biodiversity map showcase (#8169) Update Scatterplot to GLSL 300 (#8369) Update PathLayer to GLSL 300 (#8370) Update ArcLayer, LineLayer, PolygonLayer to GLSL 300 (#8371) Update BitmapLayer, IconLayer, PointCloudLayer, TripsLayer to GLSL 300 (#8372) Update remaining shaders to GLSL 300 (#8373) Co-authored-by: felixpalmer <felixpalmer@gmail.com> Bump vite from 4.4.9 to 4.5.1 (#8341) Bump luma Fix build Switch to ShaderInputs in ScatterployLayer Picking working again (without highlight)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR as a draft for now. Unlike the previous few PRs,
tests are failing here andI haven't worked out how to test most of these changes, as they depend on things like aggregation layers that aren't working in v9 yet.