TextureTransform and GPUGridAggregator updates #8374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 29, 2023
Collaborator
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
felixpalmer
reviewed
Jan 2, 2024
| // @ts-expect-error TODO - no longer supported in v9? | ||
| attributes: this.getAttributes(), | ||
| moduleSettings: this.getModuleSettings() | ||
| clearColor: [0, 0, 0, 0] |
Collaborator
There was a problem hiding this comment.
clearColor is also being set via withGLParameters, should remove it
donmccurdy
force-pushed
the
donmccurdy/layers-glsl300-pt5
branch
from
61e4045 to
b22de97
Compare
donmccurdy
force-pushed
the
donmccurdy/texture-transform
branch
from
ae8136c to
1c95e3a
Compare
donmccurdy
force-pushed
the
donmccurdy/layers-glsl300-pt5
branch
from
fdb2218 to
9c40b56
Compare
donmccurdy
force-pushed
the
donmccurdy/texture-transform
branch
from
1c95e3a to
87fba8c
Compare
donmccurdy
force-pushed
the
donmccurdy/texture-transform
branch
from
87fba8c to
33429a3
Compare
donmccurdy
force-pushed
the
donmccurdy/texture-transform
branch
from
4943b12 to
2b93afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Updates intended to get DeckGL compiling against latest LumaGL TextureTransform/BufferTransform changes, and (eventually) to get tests passing for GPUGridAggregator again.