[website] Update FirstPersonView example for v9 #8330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
felixpalmer
approved these changes
Dec 1, 2023
donmccurdy
changed the title
donmccurdy
force-pushed
the
donmccurdy/v9-examples-firstpersonview
branch
from
09d32df to
19a9ba8
Compare
felixpalmer
added a commit
that referenced
this pull request
Jan 4, 2024
Basic picking working useNormalizedColors Forward undefined/null log on null object Co-authored-by: Ib Green <ib@foursquare.com> Move uniformStore binding to _getModel Type uniformStore Tidy Tidy Bump luma API update chore(ci): Update CI dependencies (#8331) * chore(ci): Update CI to Node.js v18 * chore(ci): Update checkout, setup-node, and setup-python actions [website] Fix FirstPersonView broken video URL (#8330) Bump luma Improve types Tidy Remove unneeded state.uniformStore carto/fetchMap: fix support for quantile color scale in numeric columns for static quadbin/h3 tilesets (#8347) docs: fix source link for `fly-to-interpolator` (#8320) carto: add typedocs to source types (#8343) Remove use of deprecated BufferWithAccessor (#8345) [v9] Fix GoogleMapsOverlay by not clearing canvas (#8351) [website] GEOMATICO-371 | Taxo map biodiversity map showcase (#8169) Update Scatterplot to GLSL 300 (#8369) Update PathLayer to GLSL 300 (#8370) Update ArcLayer, LineLayer, PolygonLayer to GLSL 300 (#8371) Update BitmapLayer, IconLayer, PointCloudLayer, TripsLayer to GLSL 300 (#8372) Update remaining shaders to GLSL 300 (#8373) Co-authored-by: felixpalmer <felixpalmer@gmail.com> Bump vite from 4.4.9 to 4.5.1 (#8341) Bump luma Fix build Switch to ShaderInputs in ScatterployLayer Picking working again (without highlight)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My guess is that my changes to manually bind picking uniforms insimple-mesh-layer.tsdo not really belong in this file, but I've left that part in place for now since it did resolve the errors. Currently the mesh renders entirely in the picking color#00ffff, but if I comment that line of the shader out we do see the 360º video as expected, so I think all that's left is the fixes to picking discussed in #1850.Since there are a few related PRs and discussions in flight, I'm just opening this PR for visibility.Fixes broken link to 360º video. Earlier commits in this PR included a partial workaround for broken picking, but I've removed the workarounds here and left that to Felix in #8334.