Skip to content

Conversation

@donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Nov 30, 2023

Updating CI to Node.js v18 LTS and current versions of GitHub Actions. Fixes a few errors in the CI logs. Security support for Node.js v16 ended in September. Some older GitHub Actions were still relying on Node.js v12.

https://endoflife.date/nodejs

We could also configure Dependabot or Renovate Bot to do this automatically, if that's of interest.

@donmccurdy donmccurdy changed the title chore(ci): Update CI to Node.js v18 chore(ci): Update CI dependencies Nov 30, 2023
@donmccurdy
Copy link
Collaborator Author

Resolves errors:

The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@ee0669b, actions/setup-python@75f3110. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Rules appear to be based on job name
@donmccurdy donmccurdy marked this pull request as ready for review November 30, 2023 17:54
@donmccurdy donmccurdy merged commit 5c97f25 into master Dec 1, 2023
@donmccurdy donmccurdy deleted the donmccurdy/ci-node18 branch December 1, 2023 17:00
felixpalmer added a commit that referenced this pull request Jan 4, 2024
Basic picking working

useNormalizedColors

Forward undefined/null

log on null object

Co-authored-by: Ib Green <ib@foursquare.com>

Move uniformStore binding to _getModel

Type uniformStore

Tidy

Tidy

Bump luma

API update

chore(ci): Update CI dependencies (#8331)

* chore(ci): Update CI to Node.js v18
* chore(ci): Update checkout, setup-node, and setup-python actions

[website] Fix FirstPersonView broken video URL (#8330)

Bump luma

Improve types

Tidy

Remove unneeded state.uniformStore

carto/fetchMap: fix support for quantile color scale in numeric columns for static quadbin/h3 tilesets (#8347)

docs: fix source link for `fly-to-interpolator` (#8320)

carto: add typedocs to source types (#8343)

Remove use of deprecated BufferWithAccessor (#8345)

[v9] Fix GoogleMapsOverlay by not clearing canvas (#8351)

[website] GEOMATICO-371 | Taxo map biodiversity map showcase (#8169)

Update Scatterplot to GLSL 300 (#8369)

Update PathLayer to GLSL 300 (#8370)

Update ArcLayer, LineLayer, PolygonLayer to GLSL 300 (#8371)

Update BitmapLayer, IconLayer, PointCloudLayer, TripsLayer to GLSL 300 (#8372)

Update remaining shaders to GLSL 300 (#8373)

Co-authored-by: felixpalmer <felixpalmer@gmail.com>

Bump vite from 4.4.9 to 4.5.1 (#8341)

Bump luma

Fix build

Switch to ShaderInputs in ScatterployLayer

Picking working again (without highlight)
@donmccurdy donmccurdy added this to the v9.0 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants