carto: add typedocs to source types #8343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbigg
force-pushed
the
zbigg/carto-types-docs
branch
from
bd1095b to
6e47784
Compare
felixpalmer
requested changes
Dec 11, 2023
modules/carto/src/sources/types.ts
Outdated
| /** | ||
| * Defines the tile aggregation resolution. | ||
| * | ||
| * If not present, |
Collaborator
There was a problem hiding this comment.
Remove 'if not present'
modules/carto/src/sources/types.ts
Outdated
| * Values for named or positional paramteres in the query. | ||
| * | ||
| * | ||
| * The way query parameters are determined by data ware house. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * The way query parameters are determined by data ware house. | |
| * The way query parameters are determined by data warehouse. |
|
|
||
| /** | ||
| * Values for named or positional paramteres in the query. | ||
| * |
modules/carto/src/sources/types.ts
Outdated
| * | ||
| * The way query parameters are determined by data ware house. | ||
| * | ||
| * * BigQuery has named query parameters as `@name` and they can be specified as dictionary |
Collaborator
There was a problem hiding this comment.
Suggested change
| * * BigQuery has named query parameters as `@name` and they can be specified as dictionary | |
| * * BigQuery has named query parameters, specified with a dictionary, and referenced by key (`@key`) |
modules/carto/src/sources/types.ts
Outdated
| * sqlQuery: "SELECT * FROM carto-demo-data.demo_tables.retail_stores WHERE storetype = @type AND revenue > @minRevenue" | ||
| * queryParameters: { type: 'Supermarket', minRevenue: 1000000 } | ||
| * ``` | ||
| * * Snowflake supports positional parametes, in form `:1`, `:2`, etc. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * * Snowflake supports positional parametes, in form `:1`, `:2`, etc. | |
| * * Snowflake supports positional parameters, in the form `:1`, `:2`, etc. |
modules/carto/src/sources/types.ts
Outdated
| * sqlQuery: "SELECT * FROM demo_db.public.import_retail_stores WHERE storetype = :2 AND revenue > :1 | ||
| * queryParameters: [100000, "Supermarket"] | ||
| * ``` | ||
| * * Postgres and Redhisft supports positional parametes, but in form `$1`, `$2`, etc. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * * Postgres and Redhisft supports positional parametes, but in form `$1`, `$2`, etc. | |
| * * Postgres and Redhisft supports positional parameters, but in the form `$1`, `$2`, etc. |
modules/carto/src/sources/types.ts
Outdated
| /** | ||
| * Columns to retrieve from the table. | ||
| * | ||
| * If not specidfied, default all columns are returned. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * If not specidfied, default all columns are returned. | |
| * If not specified, all columns are returned. |
zbigg
force-pushed
the
zbigg/carto-types-docs
branch
from
eb5ba21 to
221f752
Compare
felixpalmer
approved these changes
Dec 11, 2023
2 tasks
felixpalmer
added a commit
that referenced
this pull request
Jan 4, 2024
Basic picking working useNormalizedColors Forward undefined/null log on null object Co-authored-by: Ib Green <ib@foursquare.com> Move uniformStore binding to _getModel Type uniformStore Tidy Tidy Bump luma API update chore(ci): Update CI dependencies (#8331) * chore(ci): Update CI to Node.js v18 * chore(ci): Update checkout, setup-node, and setup-python actions [website] Fix FirstPersonView broken video URL (#8330) Bump luma Improve types Tidy Remove unneeded state.uniformStore carto/fetchMap: fix support for quantile color scale in numeric columns for static quadbin/h3 tilesets (#8347) docs: fix source link for `fly-to-interpolator` (#8320) carto: add typedocs to source types (#8343) Remove use of deprecated BufferWithAccessor (#8345) [v9] Fix GoogleMapsOverlay by not clearing canvas (#8351) [website] GEOMATICO-371 | Taxo map biodiversity map showcase (#8169) Update Scatterplot to GLSL 300 (#8369) Update PathLayer to GLSL 300 (#8370) Update ArcLayer, LineLayer, PolygonLayer to GLSL 300 (#8371) Update BitmapLayer, IconLayer, PointCloudLayer, TripsLayer to GLSL 300 (#8372) Update remaining shaders to GLSL 300 (#8373) Co-authored-by: felixpalmer <felixpalmer@gmail.com> Bump vite from 4.4.9 to 4.5.1 (#8341) Bump luma Fix build Switch to ShaderInputs in ScatterployLayer Picking working again (without highlight)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8304
Change List