Remove use of deprecated BufferWithAccessor #8345
Conversation
| const source = bufferWithAccessor.getData({length: fromLength}); | ||
| const data = new Float32Array(toLength); | ||
| // TODO(donmccurdy): Might need a helper function here. | ||
| const sourceData = buffer.getData(); |
There was a problem hiding this comment.
What has happened to fromLength?
There was a problem hiding this comment.
Short answer: Oversight, and I've restored it for now, thanks!
Long answer: I think this is being used in combination with dynamic resizing of buffers, which is something we're going to want to avoid in v9. I'm also not sure whether we're keeping a synchronous method for reading buffers, since that doesn't appear to be supported in WebGPU, but switching to an async method here is a larger change than I wanted to try in this PR.
donmccurdy
force-pushed
the
donmccurdy/remove-bufferwithaccessor
branch
from
8f7f2e5 to
e25f50f
Compare
|
Merging. I will also look into removing reliance on the |
Basic picking working useNormalizedColors Forward undefined/null log on null object Co-authored-by: Ib Green <ib@foursquare.com> Move uniformStore binding to _getModel Type uniformStore Tidy Tidy Bump luma API update chore(ci): Update CI dependencies (#8331) * chore(ci): Update CI to Node.js v18 * chore(ci): Update checkout, setup-node, and setup-python actions [website] Fix FirstPersonView broken video URL (#8330) Bump luma Improve types Tidy Remove unneeded state.uniformStore carto/fetchMap: fix support for quantile color scale in numeric columns for static quadbin/h3 tilesets (#8347) docs: fix source link for `fly-to-interpolator` (#8320) carto: add typedocs to source types (#8343) Remove use of deprecated BufferWithAccessor (#8345) [v9] Fix GoogleMapsOverlay by not clearing canvas (#8351) [website] GEOMATICO-371 | Taxo map biodiversity map showcase (#8169) Update Scatterplot to GLSL 300 (#8369) Update PathLayer to GLSL 300 (#8370) Update ArcLayer, LineLayer, PolygonLayer to GLSL 300 (#8371) Update BitmapLayer, IconLayer, PointCloudLayer, TripsLayer to GLSL 300 (#8372) Update remaining shaders to GLSL 300 (#8373) Co-authored-by: felixpalmer <felixpalmer@gmail.com> Bump vite from 4.4.9 to 4.5.1 (#8341) Bump luma Fix build Switch to ShaderInputs in ScatterployLayer Picking working again (without highlight)
Applies changes required for removing BufferWithAccessor from luma.gl v9.
We'll have to do something about sync
getData, but I'm leaving that for another PR.