Bug 1652842 - Add a blocklist field so the environment schema works with pre- and post-bug-1647225 data #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
wlach
suggested changes
Jul 17, 2020
Contributor
wlach
left a comment
wlach
left a comment
There was a problem hiding this comment.
This looks good, but I have a suggestion for some additional documentation while we're here.
Comment on lines
893
to
896
| "blocklisted": { | ||
| "type": [ |
Contributor
There was a problem hiding this comment.
Since we're here, we may as well add a description field for this for future reference in the BigQuery console and the (upcoming) schema dictionary. You can probably think of a better string than me:
Suggested change
| "blocklisted": { | |
| "type": [ | |
| "blocklisted": { | |
| "description": "Indicates whether the driver was blocklisted (replaces blacklisted, see bug 1652842)", | |
| "type": [ |
We should also add something similar for the previous blacklisted string.
…nment.system.gfx.d3d11.blocklisted to allow both
…sure they pass too
Contributor
Author
|
Patches updated to include descriptions on the two fields. |
wlach
approved these changes
Jul 17, 2020
Contributor
wlach
left a comment
wlach
left a comment
There was a problem hiding this comment.
Excellent, thank you! Data should start appearing in the right bigquery column after the next schema deploy
acmiyaguchi
pushed a commit
that referenced
this pull request
Jul 22, 2020
361c16d 2020-07-22 20:48:09 +0000 Add xfocsp-error-report schema (#581) 8b05ee6 2020-07-21 14:27:14 -0700 Add regrets-reporter schemas (#556) e724d79 2020-07-17 11:02:54 -0400 Bug 1652842 - Add a blocklist field so the environment schema works with pre- and post-bug-1647225 data (#576) 7400dc8 2020-07-15 12:46:09 +0200 Bug 1652834 - Add gfx.EmbeddedInFirefoxReality field to environment. 490cfe0 2020-07-14 16:39:13 -0400 AET update: 64-char user_ids and relaxing validation 8f22589 2020-07-14 11:56:08 -0400 Specify yaml loader in extract_crash_annotation_fields script (#573) f0f50c4 2020-07-14 11:55:40 -0400 Bug 1652777 - Add experimental features to crash ping schema (#574) 97bac7a 2020-06-30 15:16:36 -0700 Add 'openglCompositing' and 'wrCompositor' to schema (#569) c47313b 2020-06-29 18:40:32 +0000 Remove ecosystem_device_id fields (#567) 2cfd30a 2020-06-26 15:09:52 -0400 Make ecosystem_device_id an optional field 3f11d8b 2020-06-23 18:03:10 +0200 Update sync ping schema to make all migration fields transpiled into BQ e678002 2020-06-22 14:12:25 -0400 add history_average_days_per_month to schema be61e13 2020-06-22 14:12:25 -0400 fix schema to contain all fields 6ecd201 2020-06-22 14:12:25 -0400 add schema for normandy-login-study bug 1643383 2e62aac 2020-06-22 12:53:32 -0400 Pin Centos image
5 tasks
5 tasks
This was referenced Nov 19, 2020
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
This was referenced Feb 1, 2021
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
This was referenced Jun 12, 2024
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
4 tasks
5 tasks
This was referenced Mar 10, 2025
3 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for reviewer:
.circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logsintegrationCI test by pushing this revision as discussed in the README and review the report posted in the comments.For glean changes:
include/glean/CHANGELOG.md