Skip to content

Conversation

@chutten
Copy link
Contributor

@chutten chutten commented Mar 27, 2025

Checklist for reviewer:

For glean changes:

  • Update templates/include/glean/CHANGELOG.md

For modifications to schemas in restricted namespaces (see CODEOWNERS):

@auto-assign auto-assign bot requested a review from akkomar March 27, 2025 21:01
@chutten
Copy link
Contributor Author

chutten commented Mar 27, 2025

@chutten chutten requested review from BenWu and removed request for BenWu March 27, 2025 21:07
@chutten
Copy link
Contributor Author

chutten commented Mar 27, 2025

(whoops, didn't see auto-assign bot there.)

@chutten
Copy link
Contributor Author

chutten commented Mar 28, 2025

@BenWu Actually, come to think on it, will these need to have space for client_info.{attribution|distribution}.ext for the column replacement in mozilla/bigquery-etl#7252 to work?

@BenWu
Copy link
Contributor

BenWu commented Mar 28, 2025

Yes I think the column needs to exist for REPLACE to work but I also think replacements don't work for nested columns so it wouldn't work anyway. You might need to recreate the client info struct like this normalization UDF does https://github.com/mozilla/bigquery-etl/blob/df42f75dd3a48a8eaaa98abc72d7665369c2dbb8/sql/mozfun/norm/glean_baseline_client_info/udf.sql#L12-L15

@chutten
Copy link
Contributor Author

chutten commented Mar 31, 2025

With column replacement being taken as a follow-up in https://mozilla-hub.atlassian.net/browse/DENG-8208, this can merge as-is.

@chutten chutten merged commit 4a23a9d into mozilla-services:main Mar 31, 2025
2 checks passed
@chutten chutten deleted the bug1955428-attributionDistribution branch March 31, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants