Skip to content

Conversation

@acmiyaguchi
Copy link
Contributor

This should fix #543 by using the --new-file option for diff. This should also post diffs of the compact column view.

Checklist for reviewer:

For glean changes:

  • Update templates/include/glean/CHANGELOG.md

@acmiyaguchi acmiyaguchi changed the title Update CI to follow MSG and post conpact columns Update CI to follow MSG and post compact columns Nov 19, 2020
@auto-assign auto-assign bot requested a review from fbertsch November 19, 2020 23:59
@dataops-ci-bot
Copy link

Integration report for "Update tests for new behaviors"

bq_schema_8e4c511f-9695b567.diff

No content detected.

compact_schema_8e4c511f-9695b567.diff

No content detected.

@dataops-ci-bot
Copy link

Integration report for "[testing] add schema to test diff"

bq_schema_8e4c511f-1e205f9b.diff

Click to expand!
Only in /app/integration/1e205f9b: test.testing.1.bq
Only in /app/integration/1e205f9b: test.testing.1.txt

compact_schema_8e4c511f-1e205f9b.diff

Click to expand!
Only in /app/integration/1e205f9b: test.testing.1.bq
Only in /app/integration/1e205f9b: test.testing.1.txt

@dataops-ci-bot
Copy link

Integration report for "Fix location of option"

bq_schema_8e4c511f-03f3b407.diff

Click to expand!
diff --new-file --exclude '*.txt' /app/integration/8e4c511f/test.testing.1.bq /app/integration/03f3b407/test.testing.1.bq
0a1,36
> [
>   {
>     "mode": "NULLABLE",
>     "name": "leaf",
>     "type": "INT64"
>   },
>   {
>     "fields": [
>       {
>         "mode": "NULLABLE",
>         "name": "leaf",
>         "type": "INT64"
>       }
>     ],
>     "mode": "NULLABLE",
>     "name": "nested",
>     "type": "RECORD"
>   },
>   {
>     "mode": "REPEATED",
>     "name": "repeated",
>     "type": "INT64"
>   },
>   {
>     "fields": [
>       {
>         "mode": "NULLABLE",
>         "name": "leaf",
>         "type": "INT64"
>       }
>     ],
>     "mode": "REPEATED",
>     "name": "repeated_nested",
>     "type": "RECORD"
>   }
> ]

compact_schema_8e4c511f-03f3b407.diff

Click to expand!
diff --new-file --exclude '*.bq' /app/integration/8e4c511f/test.testing.1.txt /app/integration/03f3b407/test.testing.1.txt
0a1,4
> root.leaf INT64
> root.nested.leaf INT64
> root.repeated.[] INT64
> root.repeated_nested.[].leaf INT64
\ No newline at end of file

@dataops-ci-bot
Copy link

Integration report for "Revert "[testing] add schema to test diff""

bq_schema_8e4c511f-b2f7209b.diff

No content detected.

compact_schema_8e4c511f-b2f7209b.diff

No content detected.

@acmiyaguchi
Copy link
Contributor Author

The output of mps bigquery diff is available in the artifact tab of the circleci page now.

Copy link
Contributor

@fbertsch fbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+. Can you add the issue to the commit when you rebase?

import os
import shutil
import tempfile
import argparse
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black doesn't change imports, that's the job of isort.

Co-authored-by: Frank Bertsch <fbertsch@mozilla.com>
import os
import shutil
import tempfile
import argparse
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black doesn't change imports, that's the job of isort.

@dataops-ci-bot
Copy link

Integration report for "Update mozilla_pipeline_schemas/cli/bigquery.py"

bq_schema_8e4c511f-61100f14.diff

No content detected.

compact_schema_8e4c511f-61100f14.diff

No content detected.

@acmiyaguchi acmiyaguchi merged commit 698fdb1 into master Nov 20, 2020
@acmiyaguchi acmiyaguchi deleted the columns-on-diff branch November 20, 2020 17:02
dataops-pipeline-schemas added a commit that referenced this pull request Nov 24, 2020
698fdb1	2020-11-20 09:01:07 -0800	Fix #543 - Update CI to follow MSG and post compact columns (#643)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The dataops-ci-bot should show the results of new schemas

4 participants