-
Notifications
You must be signed in to change notification settings - Fork 97
Update CI to follow MSG and post compact columns #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Integration report for "Update tests for new behaviors"
|
Integration report for "[testing] add schema to test diff"
|
Integration report for "Fix location of option"
|
This reverts commit 1e205f9.
Integration report for "Revert "[testing] add schema to test diff""
|
|
The output of |
fbertsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+. Can you add the issue to the commit when you rebase?
| import os | ||
| import shutil | ||
| import tempfile | ||
| import argparse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
black doesn't change imports, that's the job of isort.
Co-authored-by: Frank Bertsch <fbertsch@mozilla.com>
| import os | ||
| import shutil | ||
| import tempfile | ||
| import argparse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
black doesn't change imports, that's the job of isort.
Integration report for "Update mozilla_pipeline_schemas/cli/bigquery.py"
|
This should fix #543 by using the
--new-fileoption for diff. This should also post diffs of the compact column view.Checklist for reviewer:
.circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logsintegrationCI test by pushing this revision as discussed in the README and review the report posted in the comments.For glean changes:
templates/include/glean/CHANGELOG.md