Add xfocsp-error-report schema #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #570 This pulls in the commit from that PR and duplicates it in a new namespace. We will be rerouting these pings in the pipeline so that they can have stricter access controls. There is a test case added here so that CI will fail if these two schemas get out of sync.
Integration report for "Bug 1654558 Add xfocsp-error-report schema"Report for upstream
|
acmiyaguchi
reviewed
Jul 22, 2020
Contributor
acmiyaguchi
left a comment
acmiyaguchi
left a comment
There was a problem hiding this comment.
The schema itself looks fine. Why does the schema need to exist in the telemetry namespace if it will be rerouted to another pipeline family?
acmiyaguchi
approved these changes
Jul 22, 2020
Contributor
acmiyaguchi
left a comment
acmiyaguchi
left a comment
There was a problem hiding this comment.
This is actually consistent with the regrets-reporter schema in #556, though in that case I believe all the pings will actually be available in the Telemetry namespace as an exceptional case.
whd
approved these changes
Jul 22, 2020
Member
whd
left a comment
whd
left a comment
There was a problem hiding this comment.
I'll be responsible for merging this PR as we roll out the ACL pieces.
Contributor
Author
I had thought we would need to validate based on the telemetry schema, but then create the table based on the other schema, but it looks like we can do the rerouting immediately after parsing the URI. For sanity, though, I think it makes sense to keep a copy under Assuming the pipeline metadata schema proposal moves forward, we would refactor this in the future such that only the schema under |
jklukas
added a commit
to mozilla/gcp-ingestion
that referenced
this pull request
Jul 22, 2020
whd
pushed a commit
to mozilla/gcp-ingestion
that referenced
this pull request
Jul 22, 2020
acmiyaguchi
pushed a commit
that referenced
this pull request
Jul 22, 2020
361c16d 2020-07-22 20:48:09 +0000 Add xfocsp-error-report schema (#581) 8b05ee6 2020-07-21 14:27:14 -0700 Add regrets-reporter schemas (#556) e724d79 2020-07-17 11:02:54 -0400 Bug 1652842 - Add a blocklist field so the environment schema works with pre- and post-bug-1647225 data (#576) 7400dc8 2020-07-15 12:46:09 +0200 Bug 1652834 - Add gfx.EmbeddedInFirefoxReality field to environment. 490cfe0 2020-07-14 16:39:13 -0400 AET update: 64-char user_ids and relaxing validation 8f22589 2020-07-14 11:56:08 -0400 Specify yaml loader in extract_crash_annotation_fields script (#573) f0f50c4 2020-07-14 11:55:40 -0400 Bug 1652777 - Add experimental features to crash ping schema (#574) 97bac7a 2020-06-30 15:16:36 -0700 Add 'openglCompositing' and 'wrCompositor' to schema (#569) c47313b 2020-06-29 18:40:32 +0000 Remove ecosystem_device_id fields (#567) 2cfd30a 2020-06-26 15:09:52 -0400 Make ecosystem_device_id an optional field 3f11d8b 2020-06-23 18:03:10 +0200 Update sync ping schema to make all migration fields transpiled into BQ e678002 2020-06-22 14:12:25 -0400 add history_average_days_per_month to schema be61e13 2020-06-22 14:12:25 -0400 fix schema to contain all fields 6ecd201 2020-06-22 14:12:25 -0400 add schema for normandy-login-study bug 1643383 2e62aac 2020-06-22 12:53:32 -0400 Pin Centos image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #570
This pulls in the commit from that PR and duplicates it in a new namespace.
We will be rerouting these pings in the pipeline so that they can have
stricter access controls.
There is a test case added here so that CI will fail if these two schemas
get out of sync.
Checklist for reviewer:
.circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logsintegrationCI test by pushing this revision as discussed in the README and review the report posted in the comments.For glean changes:
include/glean/CHANGELOG.md