Skip to content

Conversation

@artines1
Copy link
Contributor

@artines1 artines1 commented Jul 10, 2020

Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)
  • Scan the PR and verify that no changes (particularly to .circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logs
  • If the PR comes from a fork, trigger the integration CI test by pushing this revision as discussed in the README and review the report posted in the comments.

For glean changes:

  • Update include/glean/CHANGELOG.md

@auto-assign auto-assign bot requested a review from sunahsuh July 10, 2020 12:09
@acmiyaguchi acmiyaguchi requested review from acmiyaguchi and removed request for sunahsuh July 10, 2020 16:15
Copy link
Contributor

@acmiyaguchi acmiyaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the data review in the bug, this data collection contains category 4 data and is therefore blocked on bug 1651005. /cc @whd for visibility.

@artines1
Copy link
Contributor Author

@acmiyaguchi Could you trigger the integration CI test for this?

And does this PR need to wait until bug 1651005 been resolved? Thanks.

@acmiyaguchi
Copy link
Contributor

Running the integration tests now. And yes, in general we have only collected category 1 and 2 data in Telemetry. While there are crash pings, the more sensitive crash reports are submitted into a separate Socorro pipeline. I am not comfortable making category 4 data available in the system until we have strict access controls in place. Merging this PR will deploy the schema to the ingestion system and BigQuery, which allow all moco access to any submitted data.

cc @mreid-moz

jklukas added a commit that referenced this pull request Jul 22, 2020
Closes #570

This pulls in the commit from that PR and duplicates it in a new namespace.
We will be rerouting these pings in the pipeline so that they can have
stricter access controls.

There is a test case added here so that CI will fail if these two schemas
get out of sync.
@jklukas jklukas mentioned this pull request Jul 22, 2020
4 tasks
@whd whd closed this in #581 Jul 22, 2020
whd pushed a commit that referenced this pull request Jul 22, 2020
* Bug 1647825 - Add a schema for the new ping 'xfocsp-error=report'.

* Bug 1654558 Add xfocsp-error-report schema

Closes #570

This pulls in the commit from that PR and duplicates it in a new namespace.
We will be rerouting these pings in the pipeline so that they can have
stricter access controls.

There is a test case added here so that CI will fail if these two schemas
get out of sync.

Co-authored-by: Tim Huang <tihuang@mozilla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants