Add 'openglCompositing' and 'wrCompositor' to schema #569
Conversation
jklukas
requested review from
acmiyaguchi and
jklukas
and removed request for
sunahsuh
|
This looks good to me. I'm tagging @acmiyaguchi for additional review since this touches all pings with environment. Do you concur that the test results here indicate no regressions in validation for existing pings? |
|
Yes, although the corresponding field should be added to one of the validation pings to ensure it's being captured in a unit test. |
acmiyaguchi
left a comment
acmiyaguchi
left a comment
There was a problem hiding this comment.
Can you add a validation document with some expected values, using https://github.com/mozilla-services/mozilla-pipeline-schemas/blob/master/validation/telemetry/main.4.min.pass.json as a base?
These correspond to telemetry added in https://bugzilla.mozilla.org/show_bug.cgi?id=1649215 and https://bugzilla.mozilla.org/show_bug.cgi?id=1648304
Done. |
|
Thanks. When can I expect the schema change to be applied? |
|
It should be applied about 1-2 hours after midnight UTC. You'll see the fields in the "live" tables (e.g. https://docs.telemetry.mozilla.org/cookbooks/bigquery/querying.html#table-layout-and-naming |
361c16d 2020-07-22 20:48:09 +0000 Add xfocsp-error-report schema (#581) 8b05ee6 2020-07-21 14:27:14 -0700 Add regrets-reporter schemas (#556) e724d79 2020-07-17 11:02:54 -0400 Bug 1652842 - Add a blocklist field so the environment schema works with pre- and post-bug-1647225 data (#576) 7400dc8 2020-07-15 12:46:09 +0200 Bug 1652834 - Add gfx.EmbeddedInFirefoxReality field to environment. 490cfe0 2020-07-14 16:39:13 -0400 AET update: 64-char user_ids and relaxing validation 8f22589 2020-07-14 11:56:08 -0400 Specify yaml loader in extract_crash_annotation_fields script (#573) f0f50c4 2020-07-14 11:55:40 -0400 Bug 1652777 - Add experimental features to crash ping schema (#574) 97bac7a 2020-06-30 15:16:36 -0700 Add 'openglCompositing' and 'wrCompositor' to schema (#569) c47313b 2020-06-29 18:40:32 +0000 Remove ecosystem_device_id fields (#567) 2cfd30a 2020-06-26 15:09:52 -0400 Make ecosystem_device_id an optional field 3f11d8b 2020-06-23 18:03:10 +0200 Update sync ping schema to make all migration fields transpiled into BQ e678002 2020-06-22 14:12:25 -0400 add history_average_days_per_month to schema be61e13 2020-06-22 14:12:25 -0400 fix schema to contain all fields 6ecd201 2020-06-22 14:12:25 -0400 add schema for normandy-login-study bug 1643383 2e62aac 2020-06-22 12:53:32 -0400 Pin Centos image
3 participants
These correspond to telemetry added in
https://bugzilla.mozilla.org/show_bug.cgi?id=1649215
and https://bugzilla.mozilla.org/show_bug.cgi?id=1648304
Checklist for reviewer:
.circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logsintegrationCI test by pushing this revision as discussed in the README and review the report posted in the comments.For glean changes:
include/glean/CHANGELOG.md