Set cmake minimum to 3.18 #848
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cmake 4.0.0 removed compatibility for versions <3.5: https://cmake.org/cmake/help/latest/release/4.0.html#deprecated-and-removed-features. I updated recently so build fails for me. Setting to 3.18 which is the version in the debian docker image.
Checklist for reviewer:
./.github/push-to-trigger-integration <username>:<branchname>For glean changes:
templates/include/glean/CHANGELOG.mdFor modifications to schemas in restricted namespaces (see
CODEOWNERS):