Skip to content

Conversation

@scholtzan
Copy link
Contributor

@scholtzan scholtzan commented Nov 4, 2024

https://bugzilla.mozilla.org/show_bug.cgi?id=1929078
This should fix the increase we are seeing in org.everit.json.schema.ValidationException: #/metrics/labeled_boolean/browser.ui.mirror_for_toolbar_widgets/<some long label>: expected maxLength: 61, actual: <some number bigger than 61>

Checklist for reviewer:

For glean changes:

  • Update templates/include/glean/CHANGELOG.md

For modifications to schemas in restricted namespaces (see CODEOWNERS):

@scholtzan scholtzan requested a review from chutten November 4, 2024 19:38
@auto-assign auto-assign bot requested a review from akkomar November 4, 2024 19:38
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chutten
Copy link
Contributor

chutten commented Nov 4, 2024

Oh, I think we need a CHANGELOG entry here: https://github.com/mozilla-services/mozilla-pipeline-schemas/blob/main/templates/include/glean/CHANGELOG.md

@scholtzan scholtzan merged commit 7eeb9eb into main Nov 4, 2024
2 checks passed
@scholtzan scholtzan deleted the fix-max-length-labeled-group branch November 4, 2024 19:50
@akkomar akkomar removed their request for review November 5, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants