fix(sales): say which kind of missing list price a line has

[mforce]

Why

A sales line with no list price rendered the same whether the farm never had a comparable price or the order simply predates the feature. The domain already knew which: ListPriceBasis models Recorded, ProductUnpriced, NotComparable and PreDating, and only PreDating is missing data. It reached no JSON API, so the SPA had one null for three reasons and told the reader the product had no price to compare — which it may well have had.

GLOSSARY.md called a null "a real answer distinct from missing data" and the Help text said "when the product had none to compare". Both are false for PreDating.

Closes #773

Scope

• ListPriceBasis on SalesOrderItemResponse as the enum member name, like DiscountReasonCode (Sales: require a discount reason when confirming a below-list order #721). Both the list and detail routes share the mapper.
• web/src/api/cluckwork.ts: required on OrderItem, so the screen branches on a real value.
• listPriceBasisLabel in web/src/i18n/enums.ts. Two labels for four values: ProductUnpriced and NotComparable are both honestly "no comparable list price"; only PreDating says "List price not recorded".
• Three render sites in SalesPage.tsx, plus the order-level sentence and the Orders-list cell.
• Glossary and Help prose in en/es/tl.

Tradeoffs

An order-level statement cannot be read off one line. A mixed order (one line pre-dating, one genuinely unpriced) may claim neither universal, so it gets its own sentence rather than borrowing either; the Orders-list cell, having room for one short label, reports the weaker truth that at least one price was never recorded.

No backfill. The snapshot is the catalogue price as it stood when the line was added, and filling old lines from today's catalogue would invent discounts that never happened.

Blast Radius

Read-path only, no migration, no schema change. A line whose basis is Recorded never reaches a basis label, so priced lines render exactly as before.

Verification

Backend 491 + 10 + 290 + 1793, web 2916, typecheck clean, build clean at zero warnings.

Proved on a genuine fixture rather than a hand-made one: seeded at 5240d73 (which has neither list-price migration), then migrated forward so the migration's own default backfilled 17 order lines to PreDating — the same path every real farm's rows took. Screenshots below are that fixture.

Adversarial review by Codex (gpt-6-astra) found four defects, all fixed here. The substantive one: a mixed order asserted "No list price on any line", the same misstatement this issue exists to end, one level up. Its two tests had pinned the old behaviour and went red against the fix. Also corrected: a chip guard that counted text only and located its cell by an index borrowed from a different table, and two comments that had become false.

[mforce]

Screenshots (#662)

Same order, same viewport (1280x760), captured 1:1 from stacks rebuilt for each side against the same PreDating fixture.

Before — three claims that the product had no price, on a line whose price is simply unrecorded.

After — the same line now says its price was never recorded, and the order-level sentence names the reason.

The before shot caught the panel before its Payments block had loaded, so that section appears only in the after. It sits outside the region this change touches.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 22baa4a2-57f4-48a1-b420-acca3f36a5ba

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}