docs(web): the help text stops describing a cap the filters no longer have (#666, #667)

Author: mforce

docs/designs/666-667-spa-date-range-filters.md

@@ -164,6 +164,13 @@ serialises `from`/`to`. The client, the endpoint and the repository are all read
    is in flight and still withheld when `meta` is null (`ExpensesPage.tsx:508-520`). Those two guards
    exist because a figure from the previous window under the new window's control is the defect this
    screen was fixed for. **Do not simplify them.**
+7. **`from`/`to` live in `useState`, not the URL — a deliberate choice nobody had stated.** This mirrors
+   Feed, Water and History, which all hold their filters the same way; Audit is the outlier, and it is an
+   outlier for a reason already on record — its own header comment made the URL the single source of truth
+   for `action` and `entityId` before this PR touched it, so `from`/`to` joining that same source keeps one
+   screen's existing contract rather than establishing a new one. The consequence is real and user-visible:
+   an Audit window survives a refresh, Back, and a shared link; an Expenses window survives none of them.
+   Recorded here so the next reader does not rediscover the asymmetry as a bug.
 
 ### Files
 
@@ -238,8 +245,7 @@ clamps.
 **Decision: no client-side validation, and no new error state.** An inverted range renders the
 filtered-empty message this slice is already adding, which is a true statement about that window. Adding
 a bespoke "your dates are backwards" path would be a fifth code path on two screens for a state the user
-resolves by looking at the two controls they just set. `max={today}` is kept on both inputs on Expenses,
-preserving the cap the month picker had. What is *not* acceptable is the current Audit behaviour of
+resolves by looking at the two controls they just set. What is *not* acceptable is the current Audit behaviour of
 saying "No audit events yet." to a user who inverted a range — that is INV-4, and it is why the third
 message is required rather than optional.
 

web/src/i18n/en.ts

@@ -2828,7 +2828,8 @@ export const en = {
     expensesHeading: "Expenses (admin)",
     expensesRecording:
       "Record money going out: date, category, description, and amount (in the farm's currency), optionally "
-      + "tied to a flock. The date range shows a running total for the period you pick; categories are managed on the same screen "
+      + "tied to a flock. The date range — the farm's own dates, not a browser clock elsewhere — shows a running "
+      + "total for the period you pick; categories are managed on the same screen "
       + "(deactivating one hides it from new expenses — recorded ones keep it).",
     expensesCorrections:
       "Corrections edit the expense in place (<strong>correct</strong> on the row). If someone else "
@@ -2931,10 +2932,10 @@ export const en = {
     farmSettingsTimezone:
       "The <strong>timezone</strong> is the farm's day. Every field that records <em>when something "
       + "happened</em> — daily entry, flocks, water, feed usage and purchases, expenses, orders and payments "
-      + "— opens on it and refuses to go past it, whatever day the phone or laptop in your hand is on, so a "
-      + "device travelling ahead of the farm can no longer offer a date the save then refuses. Dates that are "
-      + "meant to be in the future are not capped: a feed batch's <strong>expiry</strong>, and the date "
-      + "ranges you filter History and Water by.",
+      + "— opens on it and refuses to go past it for what you record, whatever day the phone or laptop in "
+      + "your hand is on, so a device travelling ahead of the farm can no longer offer a date the save then "
+      + "refuses. That cap is on recording, not on filtering: dates that are meant to be in the future are "
+      + "not capped — a feed batch's <strong>expiry</strong>, and the date ranges you filter a list by.",
     farmSettingsCurrency:
       "The <strong>currency</strong> locks the moment the farm records its first amount — a sale, a payment, "
       + "an expense, a priced product, or money spent on feed. The field shows as locked with the reason "
@@ -3134,8 +3135,9 @@ export const en = {
       + "somewhere else. It is the same \"today\" everywhere: what counts as a future date when you record "
       + "work, when eggs leave a withdrawal period, which eggs a sale can take, the day a flock is depleted "
       + "or archived on, and the range reports open on. Every field that records WHEN SOMETHING HAPPENED "
-      + "opens on it and will not go past it, whatever day the device in your hand is on. Dates meant to "
-      + "fall in the future are not capped — a feed batch's expiry, and the History and Water filters.",
+      + "opens on it and will not go past it, whatever day the device in your hand is on — that cap is on "
+      + "recording, not on filtering. Dates meant to fall in the future are not capped — a feed batch's "
+      + "expiry, and the date ranges you filter a list by.",
 
     glossaryInstallToHomeScreenTerm: "Install to home screen",
     glossaryInstallToHomeScreenDef:

web/src/i18n/es.ts

@@ -2305,8 +2305,8 @@ export const es = {
     expensesHeading: "Gastos (admin)",
     expensesRecording:
       "Registre el dinero que sale: fecha, categoría, descripción y monto (en la moneda de la granja), "
-      + "opcionalmente vinculado a un lote. El rango de fechas muestra un total acumulado para el período "
-      + "elegido; las categorías "
+      + "opcionalmente vinculado a un lote. El rango de fechas — las fechas propias de la granja, no un "
+      + "reloj del navegador en otro lugar — muestra un total acumulado para el período elegido; las categorías "
       + "se administran en la misma pantalla (desactivar una la oculta de los gastos nuevos — los ya "
       + "registrados la conservan).",
     expensesCorrections:
@@ -2410,11 +2410,12 @@ export const es = {
     farmSettingsTimezone:
       "La <strong>zona horaria</strong> es el día de la granja. Cada campo que registra <em>cuándo sucedió "
       + "algo</em> — entrada diaria, lotes, agua, uso y compras de alimento, gastos, pedidos y pagos — se "
-      + "abre en ella y se niega a ir más allá, sea cual sea el día en el teléfono o la laptop que tiene en "
-      + "la mano, para que un dispositivo adelantado a la granja ya no pueda ofrecer una fecha que el "
-      + "guardado luego rechace. Las fechas que están destinadas a estar en el futuro no tienen tope: la "
-      + "<strong>caducidad</strong> de un lote de alimento, y los rangos de fechas por los que filtra "
-      + "Historial y Agua.",
+      + "abre en ella y se niega a ir más allá para lo que usted registra, sea cual sea el día en el "
+      + "teléfono o la laptop que tiene en la mano, para que un dispositivo adelantado a la granja ya no "
+      + "pueda ofrecer una fecha que el guardado luego rechace. Ese tope es sobre el registro, no sobre el "
+      + "filtrado: las fechas que están destinadas a estar en el futuro no tienen tope — la "
+      + "<strong>caducidad</strong> de un lote de alimento, y los rangos de fechas por los que filtra una "
+      + "lista.",
     farmSettingsCurrency:
       "La <strong>moneda</strong> se bloquea en el momento en que la granja registra su primer monto — una "
       + "venta, un pago, un gasto, un producto con precio, o dinero gastado en alimento. El campo se "
@@ -2615,9 +2616,9 @@ export const es = {
       + "fecha futura al registrar trabajo, cuándo salen los huevos de un período de retiro, qué huevos "
       + "puede tomar una venta, el día en que se agota o archiva un lote, y el rango en que se abren los "
       + "informes. Todo campo que registra CUÁNDO OCURRIÓ ALGO se abre en ese día y no permite ir más "
-      + "allá, sin importar en qué día esté el dispositivo que tiene en la mano. Las fechas que deben caer "
-      + "en el futuro no tienen ese límite — el vencimiento de un lote de alimento, y los filtros de "
-      + "Historial y Agua.",
+      + "allá, sin importar en qué día esté el dispositivo que tiene en la mano — ese límite es sobre el "
+      + "registro, no sobre el filtrado. Las fechas que deben caer en el futuro no tienen ese límite — el "
+      + "vencimiento de un lote de alimento, y los rangos de fechas por los que filtra una lista.",
 
     glossaryInstallToHomeScreenTerm: "Instalar en la pantalla de inicio",
     glossaryInstallToHomeScreenDef:

web/src/i18n/tl.ts

@@ -2393,8 +2393,8 @@ export const tl = {
     expensesHeading: "Mga Gastos (admin)",
     expensesRecording:
       "Itala ang lumalabas na pera: petsa, kategorya, deskripsyon, at halaga (sa currency ng bukid), "
-      + "opsyonal na naka-link sa isang kawan. Ipinapakita ng hanay ng petsa ang tumatakbong total para sa "
-      + "panahong pinili mo; "
+      + "opsyonal na naka-link sa isang kawan. Ipinapakita ng hanay ng petsa — ang sariling petsa ng bukid, "
+      + "hindi ng orasan ng browser sa ibang lugar — ang tumatakbong total para sa panahong pinili mo; "
       + "pinapamahalaan ang mga kategorya sa parehong screen (ang pag-deactivate ng isa ay nagtatago nito "
       + "mula sa mga bagong gastos — pinapanatili ito ng mga naitala na).",
     expensesCorrections:
@@ -2502,11 +2502,12 @@ export const tl = {
     farmSettingsTimezone:
       "Ang <strong>time zone</strong> ang araw ng bukid. Ang bawat field na nagtatala ng <em>kung kailan "
       + "nangyari ang isang bagay</em> — araw-araw na entry, kawan, tubig, paggamit at pagbili ng feed, "
-      + "gastos, order at bayad — ay bumubukas dito at tumatanggi lumampas dito, anuman ang araw sa "
-      + "telepono o laptop na hawak mo, para hindi na makapag-alok ang isang device na nauuna sa bukid ng "
-      + "petsang tatanggihan din naman ng pag-save. Ang mga petsang nakatakdang mangyari sa hinaharap ay "
-      + "walang cap: ang <strong>expiry</strong> ng isang lote ng feed, at ang mga date range na ginagamit "
-      + "mo para i-filter ang History at Tubig.",
+      + "gastos, order at bayad — ay bumubukas dito at tumatanggi lumampas dito para sa itinatala mo, "
+      + "anuman ang araw sa telepono o laptop na hawak mo, para hindi na makapag-alok ang isang device na "
+      + "nauuna sa bukid ng petsang tatanggihan din naman ng pag-save. Ang cap na iyon ay para sa "
+      + "pagtatala, hindi sa pag-filter: ang mga petsang nakatakdang mangyari sa hinaharap ay walang cap "
+      + "— ang <strong>expiry</strong> ng isang lote ng feed, at ang mga date range na ginagamit mo para "
+      + "i-filter ang isang listahan.",
     farmSettingsCurrency:
       "Naka-lock ang <strong>currency</strong> sa sandaling itala ng bukid ang una nitong halaga — isang "
       + "benta, isang bayad, isang gastos, isang produktong may presyo, o perang ginastos sa feed. "
@@ -2713,9 +2714,10 @@ export const tl = {
       + "darating kapag nagtatala ka ng trabaho, kailan aalis ang itlog sa withdrawal period, kung aling "
       + "itlog ang puwedeng kunin ng isang benta, ang araw na na-deplete o na-archive ang isang kawan, at "
       + "ang range na binubuksan ng mga report. Bawat field na nagtatala kung KAILAN NANGYARI ANG ISANG "
-      + "BAGAY ay nagbubukas dito at hindi ito lalagpasan, kahit anong araw ang nasa device mo. Hindi "
-      + "limitado ang mga petsang dapat mahulog sa hinaharap — ang expiry ng isang batch ng feed, at ang "
-      + "mga filter ng History at Tubig.",
+      + "BAGAY ay nagbubukas dito at hindi ito lalagpasan, kahit anong araw ang nasa device mo — ang limitasyong "
+      + "iyon ay para sa pagtatala, hindi sa pag-filter. Hindi limitado ang mga petsang dapat mahulog sa "
+      + "hinaharap — ang expiry ng isang batch ng feed, at ang mga date range na ginagamit mo para "
+      + "i-filter ang isang listahan.",
 
     glossaryInstallToHomeScreenTerm: "Pag-install sa home screen",
     glossaryInstallToHomeScreenDef:

web/src/lib/dates.test.ts

@@ -193,11 +193,13 @@ const REJECTED = [
   "abcd-ef-gh", // non-numeric
   "10000-01-01", // five-digit year
   // Whitespace is URL-reachable: searchParams.get() decodes "+" and "%20" to a
-  // space, so ?from=+2026-08-01 arrives as " 2026-08-01". These rows exist to
-  // fail the tempting future edit — trim the input, or allow \s* in the regex —
-  // which every other row in this table survives. .NET binds a padded date
-  // fine (DateTimeStyles.AllowWhiteSpaces is the default), so a lenient client
-  // would send a value the server accepts and the control cannot display.
+  // space, so ?from=+2026-08-01 arrives as " 2026-08-01" and ?from=2026+-08-01
+  // as "2026 -08-01". These rows exist to fail the tempting future edit — trim
+  // the input, or allow \s* at the anchors — which every other row in this
+  // table survives. What the server would do with a padded value is not
+  // asserted here: this function's contract is that the client sends only what
+  // the CONTROL can display, and <input type="date"> cannot display any of
+  // these three.
   " 2026-08-01",  // leading space, the "+" decoding
   "2026-08-01 ",  // trailing space
   "2026 -08-01",  // interior space

web/src/routes/AuditPage.tsx

@@ -178,7 +178,7 @@ export function AuditPage() {
       ? rawActionFilter
       : "";
 
-  // The non-scope narrowings. `entityId` is the fourth axis that can empty this
+  // The non-scope narrowings. `entityId` is the scope axis that can empty this
   // view and is deliberately NOT here — it selects which of the two sentence
   // families applies, in the ternary below, rather than whether the view is
   // narrowed at all.